bug#2994: Recent change to font.c:font_load_for_lface affects variable-pitch face in the modeline

[Juanma Barranquero <lekktu@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

Package: emacs
X-Debbugs-CC: <handa@m17n.org>

This change affects using variable-pitch on the modeline:

--------------------------------------------------------------------------------
2009-04-13  Kenichi Handa  <handa@m17n.org>

        * font.c [...]
        (font_load_for_lface): Get a font that supports at least ASCII
        characters.

--------------------------------------------------------------------------------
@@ -3455,7 +3461,8 @@ font_load_for_lface (f, attrs, spec)
 {
   Lisp_Object entity;

-  entity = font_find_for_lface (f, attrs, spec, -1);
+  /* We assume that a font that supports 'A' supports ASCII chars.  */
+  entity = font_find_for_lface (f, attrs, spec, 'A');
   if (NILP (entity))
     {
       /* No font is listed for SPEC, but each font-backend may have
--------------------------------------------------------------------------------

Running

   emacs -Q --eval "(push '(propertize \" \" 'face 'variable-pitch)
mode-line-format)"

The attached PNGs show the difference. In both cases,

M-x describe-face variable-pitch <RET>

Face: variable-pitch (sample) (customize this face)
Documentation: The basic variable-pitch face.
Defined in `faces.el'.

        Family: Sans Serif
       Foundry: unspecified
         Width: unspecified
        Height: unspecified
        Weight: unspecified
         Slant: unspecified
    Foreground: unspecified
    Background: unspecified
     Underline: unspecified
      Overline: unspecified
Strike-through: unspecified
           Box: unspecified
       Inverse: unspecified
       Stipple: unspecified
          Font: unspecified
       Fontset: unspecified
       Inherit: unspecified

    Juanma

[-- Attachment #2: good.png --]
[-- Type: image/png, Size: 1191 bytes --]

[-- Attachment #3: bad.png --]
[-- Type: image/png, Size: 1287 bytes --]