From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in ibuffer Date: Wed, 25 Feb 2009 17:51:22 +0100 Message-ID: References: Reply-To: Juanma Barranquero , 2439@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1235581909 423 80.91.229.12 (25 Feb 2009 17:11:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2009 17:11:49 +0000 (UTC) Cc: Geoff Gole To: Stefan Monnier , 2439@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 18:13:05 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LcNJc-0007WG-Ss for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 18:13:01 +0100 Original-Received: from localhost ([127.0.0.1]:59008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNII-0001fi-43 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 12:11:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LcNAg-0000ar-Fz for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:03:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LcNAe-0000YR-02 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:03:45 -0500 Original-Received: from [199.232.76.173] (port=42953 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNAd-0000Xr-O9 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:03:43 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38207) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LcNAc-0004Fs-Io for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:03:43 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PH3bJ5006010; Wed, 25 Feb 2009 09:03:38 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1PGt5ol003326; Wed, 25 Feb 2009 08:55:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 25 Feb 2009 16:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2439 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 2439-submit@emacsbugs.donarmstrong.com id=B2439.12355806862835 (code B ref 2439); Wed, 25 Feb 2009 16:55:05 +0000 Original-Received: (at 2439) by emacsbugs.donarmstrong.com; 25 Feb 2009 16:51:26 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PGpNFH002826 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 08:51:24 -0800 Original-Received: by nf-out-0910.google.com with SMTP id g16so45860nfd.31 for <2439@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 08:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/cH26eSHZCs5momqr+gAJF/4LO9kjq7PV+l4rfeEP90=; b=Ctd245CWSb5fnIsEuqsKJx+3u36SAY7LeoZUqNgKr7kQOoYMGW1fZa5rQ5e7WwaV3C n32R7MA4YiQ0gC4hMFLgdEuLZnQeAfBV1uIYmZtl4dLIJgjxDwvxhor9u9ckJAXfuPaz I2SfSjgHlf01RlXXXVD24aBQwEbm/WLpBUWeM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QLkevjlQZfru0uOvlLRn5t0Khc6CUdVLkT6HmkmIPv5qaXP6jA5kSzDrUrJZvFBMRb YgUfyCBxFG1QoQj31OG2SWNsD77KZfO7V70eeqigmsPbZxcqIAfMI/aUG3hbREmH0Ol7 n1XnHjVwuCFb4VmtgD+ydg3euSXPIPua4IloI= Original-Received: by 10.210.66.1 with SMTP id o1mr100033eba.92.1235580682480; Wed, 25 Feb 2009 08:51:22 -0800 (PST) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 25 Feb 2009 12:03:44 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25696 Archived-At: On Wed, Feb 25, 2009 at 17:30, Stefan Monnier wrote: > Thanks for your patch, but please try to avoid hardcoding "1" as above. > Just use (point-min) instead. What is the point, when having a narrowed buffer would be an error? In this case, (goto-char 1) (forward-line orig) is not the same as (goto-line (1+ orig)) because `goto-line' uses `(save-restriction (widen) ...)'. So, if anything, is not that the patch should use `point-min', but that it should use (save-restriction (widen) (goto-char 1) (forward-line orig)) though I don't think narrowing the ibuffer buffer and then sorting is a common enough operation to worry about it. Same for bs-down, where I implemented the same fix. Juanma