From: Juanma Barranquero <lekktu@gmail.com>
To: Eric Hanchrow <eric.hanchrow@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 2259@emacsbugs.donarmstrong.com
Subject: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS
Date: Tue, 10 Feb 2009 17:10:20 +0100 [thread overview]
Message-ID: <f7ccd24b0902100810j52c99699vbfa917e6b6457992@mail.gmail.com> (raw)
In-Reply-To: <f7ccd24b0902100224p59dfdd09qc2726be2b3e2ccf6@mail.gmail.com>
On Tue, Feb 10, 2009 at 11:24, Juanma Barranquero <lekktu@gmail.com> wrote:
> or it
> is known at that point that the ENV arg of `server-with-environment'
> will never contain negative entries (i.e., can the output of
> (process-get process 'env) contain negative entries)? If it is
> intended, perhaps a comment would be in order.
OK, I see now that "ENV should be in the same format as
`process-environment'", and that, in `process-environment', "[e]ach
element should be a string of the form ENVVARNAME=VALUE". So yes, it
is known that there shouldn't be negative entries, and it is even
documented.
Still, perhaps this change would be useful...
Juanma
Index: server.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/server.el,v
retrieving revision 1.188
diff -u -2 -r1.188 server.el
--- server.el 7 Feb 2009 21:59:35 -0000 1.188
+++ server.el 10 Feb 2009 15:55:04 -0000
@@ -241,7 +241,7 @@
(dolist (,var ,vars)
(let ((,value (getenv-internal ,var ,env)))
- (push (if (null ,value)
- ,var
- (concat ,var "=" ,value))
+ (push (if (stringp ,value)
+ (concat ,var "=" ,value)
+ ,var)
process-environment)))
(progn ,@body))))
next prev parent reply other threads:[~2009-02-10 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0902100224p59dfdd09qc2726be2b3e2ccf6@mail.gmail.com>
2009-02-10 3:37 ` bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS Eric Hanchrow
2009-02-10 10:30 ` bug#2259: marked as done (23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS) Emacs bug Tracking System
2009-02-10 16:10 ` Juanma Barranquero [this message]
2009-02-11 1:45 ` bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0902100810j52c99699vbfa917e6b6457992@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=2259@emacsbugs.donarmstrong.com \
--cc=eric.hanchrow@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).