From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#2062: PATH can contain non-expanded variables Date: Mon, 26 Jan 2009 14:00:15 +0100 Message-ID: Reply-To: Juanma Barranquero , 2062@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233005064 24352 80.91.229.12 (26 Jan 2009 21:24:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Jan 2009 21:24:24 +0000 (UTC) To: Emacs Bug Tracker Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 26 22:25:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRYwv-0002cY-67 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2009 22:24:53 +0100 Original-Received: from localhost ([127.0.0.1]:36091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRYvd-0008Vb-B9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2009 16:23:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRX0C-0002P4-UE for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 14:20:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRX0B-0002OB-Jz for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 14:20:07 -0500 Original-Received: from [199.232.76.173] (port=44224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRX0B-0002Ny-76 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 14:20:07 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:51774) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRV7O-0003pp-92 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 12:19:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRRVv-0007Mu-HN for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2009 08:28:31 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0QDNThQ006358; Mon, 26 Jan 2009 05:23:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0QDA4WX002909; Mon, 26 Jan 2009 05:10:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Mon, 26 Jan 2009 13:10:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2062 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.1232974825605 (code B ref -1); Mon, 26 Jan 2009 13:10:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 26 Jan 2009 13:00:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0QD0LVZ032728 for ; Mon, 26 Jan 2009 05:00:22 -0800 Original-Received: by ewy3 with SMTP id 3so7135058ewy.1 for ; Mon, 26 Jan 2009 05:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=t2ivXmiO+1uL+J8pYlpX7NQQiKdP2JgbJlRYEQc58mw=; b=Xpl44wKZlyRcGkg+MmADaOINGG3Mr53T7OSdmyzBBHS5rqOIEgxANPUjdvYwVYnIHc 7ytpNvAygDpX6H/mtn7R1kQea9fL4flq9+o0PK5Sa/ZSL2/uhJeNIzhcmbp5otfx6+ZI bRfXDFCh2pyvC6d0eCPsU0N0wNLbL1Rp4cxUU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=bymMYHUEeOpi5IUCEvQ2LVqAZ1pc7o8zpv77bqgDdb37asYQFCu69yATbHN9meMJZM f1MLrbzu5KGJVNTigVEnzzjAxiddznTJ85H79TdeIds/ulSdI5KB/qd9s1C/MYm07QRx AgGVJyhPzYMPbqBb51W1pgCVhts/ItAXQi0nw= Original-Received: by 10.210.130.14 with SMTP id c14mr3990754ebd.118.1232974815310; Mon, 26 Jan 2009 05:00:15 -0800 (PST) X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Mon, 26 Jan 2009 14:20:07 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24578 Archived-At: Package: emacs,w32 Version: 23.0.60 It is possible for PATH (or other path-like variables, like EMACSPATH and EMACSLOADPATH) to contain unexpanded variables: ELISP> exec-path ("c:/emacs/bin" "%MYTEST%" "C:/WINDOWS/system32" "C:/WINDOWS" "C:/WINDOWS/system32/Wbem" "c:/emacs/trunk/bin") for example, if the user has set "HKLM\Microsoft\Windows\CurrentVersion\App Paths\emacs.exe\Path" as a REG_EXPAND_SZ. These variables should be expanded, but currently emacs.c:decode_env_path does not. The following patch fixes it. Comments? Juanma Index: emacs.c =================================================================== RCS file: /sources/emacs/emacs/src/emacs.c,v retrieving revision 1.461 diff -u -2 -r1.461 emacs.c --- emacs.c 23 Jan 2009 14:53:11 -0000 1.461 +++ emacs.c 26 Jan 2009 12:48:49 -0000 @@ -2467,6 +2467,12 @@ if (path) { +#ifdef WINDOWSNT + DWORD required = ExpandEnvironmentStrings (path, NULL, 0); + p = (char *) alloca (required); + ExpandEnvironmentStrings (path, p, required); +#else p = alloca (strlen (path) + 1); strcpy (p, path); +#endif path = p;