bug#1952: 23.0.60[W32-Mingw]; opening etc/HELLO is slower than before

[Juanma Barranquero <lekktu@gmail.com>]

On Tue, Jan 20, 2009 at 13:52, Jason Rumney <jasonr@gnu.org> wrote:

> This function was supposed to abort the font
> enumeration as soon as a match was found. But previously the logic was wrong
> so it was aborting if the first font did not match the given font-spec. So
> in the majority of cases, it would only enumerate one font and return nil,
> only if the first font matched would it go through every font in the system
> and return all the fonts that matched. After the fix, it will go through all
> the fonts for characters that do not have a matching font installed, and
> will go through enough fonts to find a match for others.

The change that causes the slowdown in my system is not the one to
add_one_font_entity_to_list, but this one to add_font_entity_to_list:

@@ -1449,6 +1449,5 @@
                    && !EQ (spec_charset, Qunicode_bmp)
                    && !EQ (spec_charset, Qunicode_sip)
-                   && match_data->pattern.lfCharSet == DEFAULT_CHARSET
-                   && logical_font->elfLogFont.lfCharSet != DEFAULT_CHARSET)
+                   && match_data->pattern.lfCharSet == DEFAULT_CHARSET)
             return 0;

Reverting this bit eliminates the problem.

    Juanma