unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Erik <esigra@gmail.com>
Cc: 1913@emacsbugs.donarmstrong.com
Subject: bug#1913: Identifier after reserved word "raise" is not always highlighted in Ada-mode
Date: Fri, 16 Jan 2009 00:10:44 +0100	[thread overview]
Message-ID: <f7ccd24b0901151510y542059e7p9d745f2d8c9403e@mail.gmail.com> (raw)
In-Reply-To: <496FC0B1.3020207@gmail.com>

On Fri, Jan 16, 2009 at 00:03, Erik <esigra@gmail.com> wrote:

> Actually I do notice the highlighting and take advantage of it as an
> early error detector. If it makes me notice an error immediately, before
> I move on to another part of the code or try to compile things, it is
> useful. If a word is not highlighted as expected when I have typed it, I
> automatically stop to see what I did wrong.

But we're not talking of something that is highlighted "when you move
to another part of the code"; more like "when you finish the next
token in the line".

> Did you have a performance problem with that regexp? I do not really
> believe that there is a reason to worry about it without some
> measurements. I have a 1.6 GHz CPU and want to take advantage of it. I
> think it should be able to recognize Ada identifiers as a type them.

I don't have a performance problem, but font-locking isn't the fastest
of Emacs features. You have a 1,6 GHz CPU; mine is fast, too. But
Emacs is used in all kinds of computers. That said, if you write a
patch to make the font-locking more correct without sacrificing
performance, I'm sure it'll be very welcome.

> The (?:) is equivalent to () but faster since it is a so-called
> non-capturing group, which should always be used when capturing is not
> needed. Maybe that helps?

Not really. Font-lock patterns have capturing groups for a reason
(that's what the 1, 2 in the next line refer to).

    Juanma






  reply	other threads:[~2009-01-15 23:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15  7:59 bug#1913: Identifier after reserved word "raise" is not always highlighted in Ada-mode Erik
2009-01-15  9:12 ` Juanma Barranquero
2009-01-15 13:40   ` Erik
2009-01-15 14:42     ` Juanma Barranquero
2009-01-15 23:03       ` Erik
2009-01-15 23:10         ` Juanma Barranquero [this message]
2009-01-16  2:16         ` Stefan Monnier
2009-01-16  2:22           ` Juanma Barranquero
2020-04-16 18:42 ` Stephen Leake
2020-07-02 18:11 ` bug#1913: closed by ada-mode version 7.1 Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0901151510y542059e7p9d745f2d8c9403e@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=1913@emacsbugs.donarmstrong.com \
    --cc=esigra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).