From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Jason Rumney" <jasonr@gnu.org>
Cc: 870@emacsbugs.donarmstrong.com, Emacs Devel <emacs-devel@gnu.org>
Subject: bug#870: Repeatable instance of bug#870
Date: Mon, 5 Jan 2009 12:12:48 +0100 [thread overview]
Message-ID: <f7ccd24b0901050312r10286531q1c19da99d1779447__11136.0664516271$1231154717$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <4961E7F7.2000509@gnu.org>
On Mon, Jan 5, 2009 at 11:59, Jason Rumney <jasonr@gnu.org> wrote:
> It appears that there is a bug in all the decode_coding_* functions when a
> CR lies on a CHARBUF_SIZE (0x4000) boundary with a matching LF on the other
> side of the boundary.
>
> They all do something like:
>
> if (eol_crlf && c1 == '\r')
> ONE_MORE_BYTE (byte_after_cr);
>
> but ONE_MORE_BYTE will abort the decode if it reaches the end of the buffer,
> leaving the CR in limbo between having been read and being added to the
> buffer. Then on decoding the subsequent block, the initial LF does not trip
> the normal CRLF decoding, so it is put into the buffer.
Wouldn't that mean that, on writing the buffer, the file would end
with extra CRs, instead of missing LFs?
Juanma
next prev parent reply other threads:[~2009-01-05 11:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f7ccd24b0901042103u5b241a60u7842ed51ca9249fb@mail.gmail.com>
2009-01-05 10:59 ` bug#870: Repeatable instance of bug#870 Jason Rumney
[not found] ` <4961E7F7.2000509@gnu.org>
2009-01-05 11:12 ` Juanma Barranquero [this message]
[not found] ` <f7ccd24b0901050312r10286531q1c19da99d1779447@mail.gmail.com>
2009-01-05 11:22 ` Jason Rumney
[not found] ` <4961ED68.1090609@gnu.org>
2009-01-05 11:31 ` Juanma Barranquero
[not found] ` <f7ccd24b0901050331w4d35bb66ue2323dde8c8ac6a2@mail.gmail.com>
2009-01-05 13:50 ` Jason Rumney
[not found] ` <4962100E.4060808@gnu.org>
2009-01-05 14:28 ` Juanma Barranquero
2009-01-07 1:07 ` Kenichi Handa
[not found] ` <E1LKMsw-0005wG-G6@etlken.m17n.org>
2009-01-07 6:53 ` Kenichi Handa
[not found] ` <E1LKSIW-00083J-BE@etlken.m17n.org>
[not found] ` <f7ccd24b0901070143s394f66adq79a7a6ca2d25dea3@mail.gmail.com>
[not found] ` <496489D2.8030902@gnu.org>
2008-09-03 11:03 ` bug#870: Missing ^J in ChangeLog Juanma Barranquero
2008-09-03 12:50 ` martin rudalics
2008-09-03 15:20 ` Juanma Barranquero
2008-10-22 15:14 ` Juanma Barranquero
2008-10-22 19:45 ` Eli Zaretskii
2008-10-22 20:15 ` Lennart Borgman (gmail)
2008-10-22 21:08 ` Eli Zaretskii
2008-10-22 21:22 ` Lennart Borgman (gmail)
2008-10-22 22:06 ` Eli Zaretskii
2008-10-22 22:26 ` Lennart Borgman
2008-10-22 23:10 ` Lennart Borgman
2008-10-22 21:58 ` Juanma Barranquero
2008-10-22 22:17 ` Eli Zaretskii
2008-10-22 23:32 ` Juanma Barranquero
2008-10-22 23:41 ` Juanma Barranquero
2008-10-23 0:39 ` Lennart Borgman
2008-10-23 13:34 ` Juanma Barranquero
2009-01-07 11:00 ` bug#870: marked as done (Missing ^J in ChangeLog) Emacs bug Tracking System
[not found] ` <f7ccd24b0901070301t221f906atf75f8632dcf1c41@mail.gmail.com>
2009-01-07 11:10 ` bug#870: Repeatable instance of bug#870 Jason Rumney
2009-01-07 8:19 ` martin rudalics
2009-01-07 12:29 ` Kenichi Handa
2009-01-07 15:33 ` martin rudalics
2009-01-13 2:30 ` Kenichi Handa
2009-01-13 4:06 ` Eli Zaretskii
2009-01-07 9:43 ` Juanma Barranquero
2009-01-05 5:03 Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='f7ccd24b0901050312r10286531q1c19da99d1779447__11136.0664516271$1231154717$gmane$org@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=870@emacsbugs.donarmstrong.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).