bug#947: Recursive load of ido after unload-feature and reload

bug#947: Recursive load of ido after unload-feature and reload

[Juanma Barranquero]

Package: emacs
Severity: minor

emacs -Q -D
M-x ido-mode <RET>
M-x unload-feature <RET> ido <RET>
M-x ido-mode <RET>

Recursive load: "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc"

The problem is that after unloading ido, the variable ido-mode is
void, and calling ido-mode without an argument runs this code:

  (setq ido-mode
	(cond
	 ((null arg) (if ido-mode nil 'both))
         ; ...

and setting the variable ido-mode runs this code:

  :set #'(lambda (symbol value)
	   (ido-mode value))

so there's really a recursion.

I can think of several crude workarounds, but they aren't pretty and
I'm not sure they will play fair with customize.

bug#947: Recursive load of ido after unload-feature and reload

[Glenn Morris]

"Juanma Barranquero" wrote:

> and setting the variable ido-mode runs this code:
>
>   :set #'(lambda (symbol value)
> 	   (ido-mode value))
>
> so there's really a recursion.

Isn't this enough, so long as ido-mode is not enabled by default?

*** ido.el	9 Sep 2008 14:01:03 -0000	1.150
--- ido.el	10 Sep 2008 18:44:43 -0000
***************
*** 353,359 ****
  use either \\[customize] or the function `ido-mode'."
    :set #'(lambda (symbol value)
  	   (ido-mode value))
!   :initialize 'custom-initialize-set
    :require 'ido
    :link '(emacs-commentary-link "ido.el")
    :set-after '(ido-save-directory-list-file
--- 353,359 ----
  use either \\[customize] or the function `ido-mode'."
    :set #'(lambda (symbol value)
  	   (ido-mode value))
!   :initialize 'custom-initialize-default
    :require 'ido
    :link '(emacs-commentary-link "ido.el")
    :set-after '(ido-save-directory-list-file

bug#947: Recursive load of ido after unload-feature and reload

[Juanma Barranquero]

On Wed, Sep 10, 2008 at 20:44, Glenn Morris <rgm@gnu.org> wrote:

> Isn't this enough

Yes, it apparently fixes the problem.

> so long as ido-mode is not enabled by default?

What do you mean, "not enabled by default"?

   Juanma

bug#947: marked as done (Recursive load of ido after unload-feature and reload)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 880 bytes --]


Your message dated Thu, 11 Sep 2008 02:11:29 -0400
with message-id <ga7i9jgqjy.fsf@fencepost.gnu.org>
and subject line Re: bug#947: Recursive load of ido after unload-feature and reload
has caused the Emacs bug report #947,
regarding Recursive load of ido after unload-feature and reload
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
947: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=947
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2970 bytes --]

From: "Juanma Barranquero" <lekktu@gmail.com>
To: "Emacs Bug Tracker" <submit@emacsbugs.donarmstrong.com>
Subject: Recursive load of ido after unload-feature and reload
Date: Tue, 9 Sep 2008 16:29:40 +0200
Message-ID: <f7ccd24b0809090729j50d222b3od335d21c4b6db62e@mail.gmail.com>

Package: emacs
Severity: minor

emacs -Q -D
M-x ido-mode <RET>
M-x unload-feature <RET> ido <RET>
M-x ido-mode <RET>

Recursive load: "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc",
"c:/emacs/trunk/lisp/ido.elc", "c:/emacs/trunk/lisp/ido.elc"

The problem is that after unloading ido, the variable ido-mode is
void, and calling ido-mode without an argument runs this code:

  (setq ido-mode
	(cond
	 ((null arg) (if ido-mode nil 'both))
         ; ...

and setting the variable ido-mode runs this code:

  :set #'(lambda (symbol value)
	   (ido-mode value))

so there's really a recursion.

I can think of several crude workarounds, but they aren't pretty and
I'm not sure they will play fair with customize.



[-- Attachment #3: Type: message/rfc822, Size: 1936 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: 947-done@emacsbugs.donarmstrong.com
Subject: Re: bug#947: Recursive load of ido after unload-feature and reload
Date: Thu, 11 Sep 2008 02:11:29 -0400
Message-ID: <ga7i9jgqjy.fsf@fencepost.gnu.org>

"Juanma Barranquero" wrote:

> Yes, it apparently fixes the problem.

Installed.

>> so long as ido-mode is not enabled by default?

> What do you mean, "not enabled by default"?

So long as ido-mode the variable has a default value of nil, which I
imagine will always be true.