From: "Juanma Barranquero" <lekktu@gmail.com>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: other-window: say there is none if none
Date: Tue, 14 Nov 2006 16:31:22 +0100 [thread overview]
Message-ID: <f7ccd24b0611140731uae0586ap37482b48bd772153@mail.gmail.com> (raw)
In-Reply-To: <E1GjxNS-00044P-5j@fencepost.gnu.org>
On 11/14/06, Richard Stallman <rms@gnu.org> wrote:
> - Fselect_window (window, Qnil);
> + if (!EQ (window, old))
> + Fselect_window (window, Qnil);
> + else if (Finteractive_p () && EQ (window, Fnext_window (window, Qnil, Qnil)))
> + error ("No other windows");
>
> Displaying a message can't hurt
> when the command is called interactively, but this change would cause
> programs that call other-window to get errors where they didn't get
> errors before.
Hmmm. According to interactive-p's docstring:
Return t if the function was run directly by user input.
This means that the function was called with `call-interactively'
(which includes being called as the binding of a key)
and input is currently coming from the keyboard (not in keyboard macro),
and Emacs is not running in batch mode (`noninteractive' is nil).
so if a program gets an error from a section of code protected by
interactive-p, it is trying *very hard* to fake being interactive, and
it gets what it asked for. :)
> This doesn't need to be changed now, so please leave it alone.
Of course. I was just trying to be helpful. Perhaps Dan wants to patch
his own Emacs :)
/L/e/k/t/u
next prev parent reply other threads:[~2006-11-14 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 19:22 other-window: say there is none if none Dan Jacobson
2006-11-13 0:39 ` Drew Adams
2006-11-13 15:50 ` Kevin Rodgers
2006-11-13 17:19 ` Juanma Barranquero
2006-11-14 12:26 ` Richard Stallman
2006-11-14 15:31 ` Juanma Barranquero [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-20 11:32 Dan Jacobson
2006-11-21 16:14 ` Kevin Rodgers
2006-11-21 16:24 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccd24b0611140731uae0586ap37482b48bd772153@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).