From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.bugs Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Date: Tue, 14 May 2024 18:19:10 -0700 Message-ID: References: <877cnn4z2v.fsf@hyperspace> <87ttq5u9fj.fsf@posteo.net> <87ttq5bx2y.fsf@hyperspace> <87r0l91vww.fsf@posteo.net> <87r0l9fsl1.fsf@hyperspace> <871qd91l9e.fsf@posteo.net> <87bkc59wv8.fsf@hyperspace> <87wmutfe8l.fsf@posteo.net> <87pm0hvmwj.fsf@hyperspace> <87msve9mri.fsf@posteo.net> <874jbg11p6.fsf@hyperspace> <868r0rjtco.fsf@gnu.org> <87cypogyux.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10666"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-455-g0aad06e44-fm-20240509.001-g0aad06e4 Cc: Philip Kaludercic , 66567@debbugs.gnu.org To: "Tony Zorman" , "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 15 03:20:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s73Je-0002X0-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 May 2024 03:20:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s73JO-0006Ks-BD; Tue, 14 May 2024 21:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s73JI-0006K2-Mq for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 21:20:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s73JI-00029k-Ej for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 21:20:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s73JJ-0005O6-Jg for bug-gnu-emacs@gnu.org; Tue, 14 May 2024 21:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "John Wiegley" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2024 01:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66567-submit@debbugs.gnu.org id=B66567.171573598420686 (code B ref 66567); Wed, 15 May 2024 01:20:01 +0000 Original-Received: (at 66567) by debbugs.gnu.org; 15 May 2024 01:19:44 +0000 Original-Received: from localhost ([127.0.0.1]:41635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s73J2-0005Na-EX for submit@debbugs.gnu.org; Tue, 14 May 2024 21:19:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s73Iy-0005NF-9E for 66567@debbugs.gnu.org; Tue, 14 May 2024 21:19:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s73Iq-00024K-59; Tue, 14 May 2024 21:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:References:In-Reply-To: MIME-Version; bh=2rVxtZjVJRX/p7f0aDRH0pBPwmPEr+q0QCZWAAdKywU=; b=KHNJSW2eW7L4 nTbIW9KkHNjZP0GYHJx2FeqIZHTry7zqMQUPLLHKIE+hcKG+2o23J964w+XlJgdIjOURs4RSo8pEm pPLX2XDCkjeZkIXPQFSS5N6ldEcplLldG3iKA89I4Gk4Ez5TSJpRBrWZkpAIfMvxkAecl9KY2Xw27 RYUorh8pYjbX5dyV5Qkx7omMFiIc2R0N306ga3fT6frUKG96aRa0kqZQcuawUTbXfcw7Uhu2wqgWs GVJSLyB5N92gLTUPbrzqgqFRnZEhyUnzGo3Bzlt2BAC75jPHQJGJZRfvm/YAq4J/eFbdYFBFwV4vU iEHjEAno3KfaTg1DZJx0bw==; X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegjedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdfl ohhhnhcuhghivghglhgvhidfuceojhhohhhnfiesghhnuhdrohhrgheqnecuggftrfgrth htvghrnhepvdffudeujeekteeviedvffejteduteekjedvfeffhfekffehteeigeektdel hfdvnecuffhomhgrihhnpehtohhnhidqiihorhhmrghnrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhohhhnfidomhgvshhmthhp rghuthhhphgvrhhsohhnrghlihhthidqieekjeektdelgeegqddujeejheefkeduiedqjh hohhhnfieppehgnhhurdhorhhgsehnvgifrghrthhishgrnhhsrdgtohhm X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <87cypogyux.fsf@hyperspace> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285059 Archived-At: That all makes sense to me then. Looks good to go. John On Tue, May 14, 2024, at 9:08 AM, Tony Zorman wrote: > Hi, > > On Fri, May 03 2024 23:16, John Wiegley wrote: >>>>>>> Eli Zaretskii writes: >> >>>> I'd really like to see this merged; if it helps move things along a >>>> bit quicker, I can also make the necessary changes to package-vc.el. >> >>> John, could you please review the patches and comment? >> >> Hi Eli, I=E2=80=99ve read through the proposed patches. What=E2=80=99= s being proposed looks >> good to me, except that I find it odd that it mentions two new keywor= ds in the >> ChangeLog that have nothing to do with the :vc keyword. Why conflate = that into >> this changeset? I don=E2=80=99t see those keywords mentioned anywhere= else but the >> valid keywords list, so is this for economy rather than creating two = patches? > > I did attach two patches to the original message, separating these out. > Though you are right that perhaps I should have also created two > separate bugs for this. It's just something I noticed along the way and > figured I'd forget again if I didn't fix it immediately. > > These keywords (I hope I haven't misunderstood you and you are referri= ng > to :make and :shell-command) do, however, have something to do with :vc > in the sense that they are sub-keywords of it, much like :ignored-files > is. > > Tony > > --=20 > Tony Zorman | https://tony-zorman.com/