From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Date: Fri, 31 May 2024 02:23:24 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71209@debbugs.gnu.org To: Noah Peart , Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 01:24:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCp84-0001PD-DB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 01:24:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCp7h-0005gQ-3V; Thu, 30 May 2024 19:23:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCp7g-0005g9-2t for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 19:23:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCp7f-00013Y-Nl for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 19:23:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCp7q-0005OY-Dc for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 19:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2024 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71209-submit@debbugs.gnu.org id=B71209.171711143220722 (code B ref 71209); Thu, 30 May 2024 23:24:02 +0000 Original-Received: (at 71209) by debbugs.gnu.org; 30 May 2024 23:23:52 +0000 Original-Received: from localhost ([127.0.0.1]:52814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCp7c-0005O6-MJ for submit@debbugs.gnu.org; Thu, 30 May 2024 19:23:52 -0400 Original-Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:47921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCp7X-0005Nq-W1 for 71209@debbugs.gnu.org; Thu, 30 May 2024 19:23:47 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id C002913800C5; Thu, 30 May 2024 19:23:27 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 30 May 2024 19:23:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1717111407; x=1717197807; bh=C6YJKN4f3mMTHFN8GFhBnY7TI7LSvfowAsQcJprHZgk=; b= i1oj6I6Wlpgw9ZYwyoBtwFsdEpB+uFe8MCy2Qgpi2d+s+dm9BC29h7U8AoyBN2No YrcFZt1chne5DT9oOHlv4o1QK6XUN6uLg1XekEJLFyGcmVKAzTEh69JGflHzE7tW HVeAhcsW9j5/EDK1w1PfL/8un+TMeeuo5ypsGQM4dl8yP9Wjc8moXpDNHVTwPAC0 jl9Jk58NQoE0JgvilTMTN5uoBwN0o5k7OFFBxx9kQ1hCdFSozXS+FYy6vajAqnD2 qpFWYkWlidi/3TcYqLS9JDp3jnkX8XMn9GJdmacWJDoGukN2xzRyFQENGW3HZrEU HmwNvwqvCwTEh0sKxdRXaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717111407; x= 1717197807; bh=C6YJKN4f3mMTHFN8GFhBnY7TI7LSvfowAsQcJprHZgk=; b=A DosBaaMbS8fLGDSwc7q9fSDHkc5oKNR9yqP4WVaj0k8iESvFy2b47dqWe/i5oZtN OX0GIWvZLCIlCdYmIEpx8VSNJae+AsZSK+L1L7CnNnAXY5YVpE0IoWZ3ZjE5h0j3 LpNluxOSt0LUUs3k07Utvl5zk1uoSUdI3zdZWAZknoF/tAwvrcPdfBQgWrzUlaXS +PY+v4kJl0iZNOt3M5WHhlzHEZKJp93kRIcs5jd6SimEgv8LtvFvJuyZv3kYa+YF rDKa+4eC4bleQGj2ChE7dnz5kE1BAH7wuFGvlvaYWCM669iW5JW7PvovBw7TXcco xC5CA0MUIorndthUkhxqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekhedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 May 2024 19:23:26 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286247 Archived-At: On 30/05/2024 16:25, Noah Peart wrote: > > it seems we already highlight this when at treesit-font-lock-level 4? > > They get highlighted with `font-lock-variable-use-face` at level 4, but > shouldn't > they be getting `font-lock-variable-name-face` in the 'definition feature? I think that's a good idea: the local variables idx and val are introduced on that line, so we could indeed call those occurrences "definitions".