From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Mon, 24 Dec 2018 04:29:39 +0200 Message-ID: References: <878t18j4is.fsf@mail.linkov.net> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <09b2c002-1519-61dd-6e8b-2e87794077e2@yandex.ru> <87zht1jjdf.fsf@mail.linkov.net> <75267609-e167-c26e-82e8-d6c2609dbf30@yandex.ru> <8736qrkgel.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545618488 22623 195.159.176.226 (24 Dec 2018 02:28:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Dec 2018 02:28:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 24 03:28:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbFyM-0005km-2g for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Dec 2018 03:28:02 +0100 Original-Received: from localhost ([127.0.0.1]:32772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbG0S-0001VZ-VH for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 21:30:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbG0L-0001VG-Vj for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:30:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbG0J-0006qB-Bu for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:30:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbG0J-0006pT-74 for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbG0J-0003Vx-0Z for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 21:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Dec 2018 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154561859013466 (code B ref 33567); Mon, 24 Dec 2018 02:30:02 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 24 Dec 2018 02:29:50 +0000 Original-Received: from localhost ([127.0.0.1]:34178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbG06-0003V8-Ad for submit@debbugs.gnu.org; Sun, 23 Dec 2018 21:29:50 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:54177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbG04-0003Un-Q8 for 33567@debbugs.gnu.org; Sun, 23 Dec 2018 21:29:49 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id d15so10167945wmb.3 for <33567@debbugs.gnu.org>; Sun, 23 Dec 2018 18:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+jOhh+q2nYnPJPPmSqzIfyE+4fxx8TznU3DK3ZTlb4k=; b=k4J6aQW+BUhaAgE2DSDrKPKTBbpaDMfVG657BwRyJol0/if2cpt5Zu+0dmdXdWLMZC nV0uWaRDG4Kt2G3hVS6zggkka3XdI7s35vDmcsHNx8tGMAgTziBprbnJ1qltreXPlZGu e2ou5xnX9pIJ+yOWXbHRSysWFDo9mptVYayBl2YDCRwBNhsqfWm4lNbfvF7/2GJBqeE+ Mc6JHDcU0nbOCcRCm7QzYn3oomEVMPNMp3pb6ZHNY12KAlm4Eep2qRa4mvc7lCdOW6o6 HhTJvJaQIALWUGpp6J+B47J72LgTkjiQ0+Y/c4cUAoffBvA+bjCD/lBg7sS2Ve8IzLpq +j8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+jOhh+q2nYnPJPPmSqzIfyE+4fxx8TznU3DK3ZTlb4k=; b=P7l9Fvp1t4Dm28fW3BZuol6nCNNDfYXYKOuYZ0QtzyKUv2lY1fFqE8aAZb0wlaJ1ua qZd/h2O0qV+8gM6fzb+shrwlaHuHzAbu7oAqK4YB/ivF8yQ9UknCrWwfZIYE6OTOTFY8 +qJcVvg3JlzZ4ofFz40XEnkgLwqQe38++NnLeuiHUGOpXhgrlTTgVvUluiqs9De0qoIV oulEkXoVPkC6N0IWrpbbXM+GS0zW7hl6bj1Xovuu620zBRaDr7+iuNYtUFhDlJ8lKqI2 Gdar+aCa69FxCMM/CwlW6awr9R/LSCrme0bbhAszr0rjTRLJV5EuZMvF38RVmU12jlOl Fsug== X-Gm-Message-State: AJcUukdwVT6RnMBU+4KAwZptpbcHgztJEkOl12bEa+q3HYeJpgODDQVH bXZqbMrjpCPGbXAQLjtFTRCK5wFe X-Google-Smtp-Source: AFSGD/X50Cz15C8qbu17+0zwTb7pRj13SHCh03231Kc5GYTZNngyCfRxL8NK74D0OLIGp5vpUdloTw== X-Received: by 2002:a1c:990c:: with SMTP id b12mr11103465wme.106.1545618582711; Sun, 23 Dec 2018 18:29:42 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id j24sm19153818wrd.86.2018.12.23.18.29.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Dec 2018 18:29:41 -0800 (PST) In-Reply-To: <8736qrkgel.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153816 Archived-At: On 21.12.2018 0:00, Juri Linkov wrote: > I don't know. We have two options for tty: highlight indicators only > or use red/green foreground without syntax highlighting. Ouch. All this time I've been talking about a personal customization that's too old for me to remember about. Sorry about that, I'm dropping that part of the proposal. Speaking of ttys, green and red look foreground looks kind of okay for me in that context. However, diff-refine-* faces are simply defined as :inverse-video. And now, with the new feature, when e.g. there is a face that spans the whole line (like a comment), both diff-refine-added and diff-refine-removed faces look the same. Which is a problem. I don't have easy suggestions except defining specific background for them instead of inverse-video. And at that point we can drop the green/red foregrounds if people prefer. > By default it used the black foreground. Only Magit uses red/green foreground. So I'd propose Magit to follow the core here. And, like we discussed, other popular tools. > Maybe with conditional face definitions like > > (if (boundp 'diff-font-lock-syntax) > (defface blabla)) Fair enough.