From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers Date: Fri, 1 Nov 2024 02:49:24 +0200 Message-ID: References: <3b9816c7-bec3-4743-ad1a-49332c158099@gutov.dev> <1a2ab2c3-272a-41c8-af6f-6ed7348189df@gutov.dev> <86sesf58zz.fsf@gnu.org> <9dc6f220-1748-4ed0-9c36-fffed80071f0@gutov.dev> <86r07w37tk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25290"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: i@fuzy.me, 73801-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 01 01:50:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6fri-0006Fh-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Nov 2024 01:50:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6frY-0005Ay-Pu; Thu, 31 Oct 2024 20:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6frX-0005Ah-85 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 20:50:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6frW-0003rJ-Pf for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 20:50:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=eaVcy5T2oQ0wiygU5vCKi6f91EN5VpRwMn9EvmO0lCA=; b=JddKMLQys+6yjSKjYa5VvqDJ9HqwDGwAsYlnM8pbdobnMZMszZdscDqfLW8eZ+1z1dvyARHkMTB6ElxT1kbgKF5TpfJTabpTYDcmDnd1MrAYo5RZ8IOfkeCIHoh4AbVq0doR+NQpifGadS3JP03KWr50vkKkUBl7tBAnO+5096KaFFnCZiJFIJo6GEIapGl6CVH6F1z+h77Iv6RS2zAAxqJQXfUntHsbyZD1BJhK8Rr9GoGQSQ8RkyMw55jx9NZRmFOtxBnClC9r7yqIPRFmLhf6+Jye+nqpdVrnArVNzwLlf6A+Ufv61uSBkXfmGmESyHOY2wWzv5k9sIS3tt+7Tw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6frW-0000VA-Kd for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 20:50:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2024 00:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73801 X-GNU-PR-Package: emacs Mail-Followup-To: 73801@debbugs.gnu.org, dmitry@gutov.dev, i@fuzy.me Original-Received: via spool by 73801-done@debbugs.gnu.org id=D73801.17304221771895 (code D ref 73801); Fri, 01 Nov 2024 00:50:02 +0000 Original-Received: (at 73801-done) by debbugs.gnu.org; 1 Nov 2024 00:49:37 +0000 Original-Received: from localhost ([127.0.0.1]:45377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6fr6-0000UV-VI for submit@debbugs.gnu.org; Thu, 31 Oct 2024 20:49:37 -0400 Original-Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]:52641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6fr3-0000UM-QX for 73801-done@debbugs.gnu.org; Thu, 31 Oct 2024 20:49:35 -0400 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id 71585138025A; Thu, 31 Oct 2024 20:49:28 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Thu, 31 Oct 2024 20:49:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1730422168; x=1730508568; bh=eaVcy5T2oQ0wiygU5vCKi6f91EN5VpRwMn9EvmO0lCA=; b= iQun4PmaieUQ9vKqWj2c2mV9SKtoKcCVXXiTJiQrYRhydyjNFawLATvpNAAuQPJd 1+jblwRdt5zgJKjAq1FlqIUblNW0vgV9lwPntfX7+FeyVdoQGS80eBLLGxQWsXSx baS5ffcpGLSWg5BzKIMlAaNL/8bCLyIw9wV2hsIFjYbg+j6jSORj4POni5uTrJCI l72qGTPHKc7tW9W5F02+5JaK+aEiXdKT4nhNFB+WHnmTlBWSOdMeM9+xLZywla2g xzyw8KGplXYrKLeWAS84TylgHboYZBLGKlciKR7X1jSPgULZ15HqB6Xa4ZOIr4Qd j7+FrIIb4T9vscJ4lwk0zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730422168; x= 1730508568; bh=eaVcy5T2oQ0wiygU5vCKi6f91EN5VpRwMn9EvmO0lCA=; b=K pv1Ac8R2Q1bHjU4z2l2Q6P/Iy/z2td2mZ6BRZNt9Lepf0g9dufJ1MPD7IpjonzOz XDSit3gY42Jz/tOR7IBbsW0fh6KGzjfC+ngHIpfnnogdyWbfHnQYNsiFYoy1ARkG +bOvMgnlzIkbdjnOGkr2B640fjQp0RZn+XM8bDGu3QK39OS3csoCb/H3s8P+iHTW pfdxYG8Us0iS0NIDwYxGrYhgpVsOHMT4LTvrr1GgohbOqvYcZkeBH2ByElHJCHcQ 6cSxrFirIZ2/9CGP0aIQDSOr1pTHupEkJy2kKbBlY3kUKxRaLJfBA7/1DYfdRRmS QXSmTo6EGl18IprEMsJ7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekkedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopeejfeektdduqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrghdp rhgtphhtthhopehisehfuhiihidrmhgv X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Oct 2024 20:49:27 -0400 (EDT) Content-Language: en-US In-Reply-To: <86r07w37tk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294644 Archived-At: Version: 30.1 On 31/10/2024 12:06, Eli Zaretskii wrote: >>> How do we know that catering to this corner case will not screw >>> other corner cases? >> Difficult to guarantee that 100%, but this specific case seems important >> enough, while at the same time we can infer that the change won't affect >> the majority scenario because the code is guarded by these conditions: >> >> (when root >> (when (not backend) >> ... > FWIW, I have a bad feeling about this, but if you are confident, feel > free to backport. Thanks, I've cherry-picked the longer (but more transparent) fix and a new regression test as well, to the release branch. And thanks to Zhengyi Fu for trying it out.