unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>,
	Pankaj Jangid <pankaj@codeisgreat.org>,
	Lars Ingebrigtsen <larsi@gnus.org>
Cc: 63344@debbugs.gnu.org
Subject: bug#63344: 29.0.90; (shr-zoom-image) doesn't zoom to buffer size
Date: Thu, 4 Jul 2024 12:30:20 -0700	[thread overview]
Message-ID: <f76a93d0-06a3-71e2-8e3f-600bb07eb518@gmail.com> (raw)
In-Reply-To: <83mt2fcb04.fsf@gnu.org>

forcemerge 71666 63344
thanks

On 5/8/2023 4:34 AM, Eli Zaretskii wrote:
> "Full buffer size" wrt an image is confusing in any case (an Emacs
> buffer has no "dimensions"), but my reading of the code is that it is
> interpreted as the window dimensions, unless the original size is
> smaller than that.  Not sure if I'm right, though.

In bug#71666, I did some archaeology on the Gnus commit history to 
figure out what this was, and found that the "full buffer size" meant 
"rescale the image to the height of the window". Over in that bug, I've 
fixed the issue described here as well as improving the wording in the 
docstrings to be more precise.





      reply	other threads:[~2024-07-04 19:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07  6:56 bug#63344: 29.0.90; (shr-zoom-image) doesn't zoom to buffer size Pankaj Jangid
2023-05-07  9:26 ` Eli Zaretskii
2023-05-07 12:42   ` Pankaj Jangid
2023-05-07 13:14     ` Eli Zaretskii
2023-05-08  5:06       ` Pankaj Jangid
2023-05-08 11:34         ` Eli Zaretskii
2024-07-04 19:30           ` Jim Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f76a93d0-06a3-71e2-8e3f-600bb07eb518@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=63344@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=pankaj@codeisgreat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).