From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.bugs Subject: bug#60974: 30.0.50; byte-compile-preprocess mutates self evaluating forms in expanded macro bodies Date: Tue, 07 Feb 2023 18:32:46 +0530 Message-ID: References: <6eb5f27bf591c3d52766d8b9da46e7301f2ff0ab.camel@gmail.com> <5ccd0d1f9f64a5fd20e5403a07b06d6074b6c8f6.camel@gmail.com> <2d72943db9995af6a98744f4a4da3cef98773b86.camel@gmail.com> <22ab766cb75ceedac14976e02aebe02711ef6aad.camel@gmail.com> <51cc5308368f09c02a315970275bd3968008c421.camel@gmail.com> <0883890C-6FB6-4501-867A-6684CBA3D9F4@acm.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-KSo9Ok7Greuz1sQEVd6c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5704"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.46.3 Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 60974 <60974@debbugs.gnu.org> To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 07 14:04:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPNeA-0001MG-J2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Feb 2023 14:04:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPNdl-000471-Rc; Tue, 07 Feb 2023 08:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPNdi-000462-SK for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 08:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPNdi-0008Kb-K5 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 08:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPNdi-00079u-7K for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 08:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Vibhav Pant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60974 X-GNU-PR-Package: emacs Original-Received: via spool by 60974-submit@debbugs.gnu.org id=B60974.167577498527445 (code B ref 60974); Tue, 07 Feb 2023 13:04:02 +0000 Original-Received: (at 60974) by debbugs.gnu.org; 7 Feb 2023 13:03:05 +0000 Original-Received: from localhost ([127.0.0.1]:51484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPNcm-00078b-NM for submit@debbugs.gnu.org; Tue, 07 Feb 2023 08:03:05 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:42548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPNck-000786-5m for 60974@debbugs.gnu.org; Tue, 07 Feb 2023 08:03:02 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id d14so13463715wrr.9 for <60974@debbugs.gnu.org>; Tue, 07 Feb 2023 05:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=l+6JHdhpxIFs8ePXQiOuvkadfdEVxGp5ujxIzBx2Jyw=; b=Ci5DkTpbK6pwHuj9DxCTz8WX1PLVNHwgVMBoljnYlFhWW+/2j/Jeov3YOjqN0fD5ud nwqBpepPaXuOp38Kk6xGwMfWLJHkKFtWaKHuKIIAzQ5Z4wzJJkF8qXHVAFUvjLCJ/Jij obZPJxDcRmtb+qBgSF8l5pc7SSvez+a06fBYjdg0wJxwHwuMIM7QxKYpY1Tt4cL98rrx Xe8qhEQhwbahPfoRnbmKkR4GLFRAXDgUC2q0Ng48QYKJkQ0tiAaX0Jdt0zoeKYcR00Mv iJfm/HYFVb2ogNi2TfdUAAmgbtaIg3zBHnHlpbwAYMV/oniUmKbUaeQin0Ukzs9aGPJI UDZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l+6JHdhpxIFs8ePXQiOuvkadfdEVxGp5ujxIzBx2Jyw=; b=gASZbbE6FGLxXmubxLbqziqaZI5uB038o1SF+dPaLeoKqN61skA3gbiukcoti4eU+l 7fG4fVFhTY/KkuQFRSDTnTcu7gkAFDw4Mp1wqREP23EKpqg5ojfW7n0aLZ97ZsCLLY8v R9joqT0rtn5mkWZUwGkVbvRw5kCkly5yp5KSH1MRrFXSBRbKQuvPA5kC6DGKqwEU5/jY ptay9z43xUaEtpe9UNZLI0JcMfzkcH5sAk+mpqQQZ//Fc5ntZAaV+Nr4jO3uz8CBruVS KJA5ZfY6989NP3N+0dtAI1PzbsGByrz5kS0YyPWuzje6JKVJysOp8aBT97zky8AcLx3n F7mA== X-Gm-Message-State: AO0yUKUXU3230vMr0Pg/8iR6Y2DgJ12IS+uArvl6XOD5a640A+BfR85l xW5Lg+wXATbeBwLlisjE32I= X-Google-Smtp-Source: AK7set9tBihuCjToxBeSk69YGbJR4n3Ajl+Iv4xTshyU6Z+L55wVieybozT08RHbt+eF7tbriMSuow== X-Received: by 2002:a5d:43c9:0:b0:2be:691c:a584 with SMTP id v9-20020a5d43c9000000b002be691ca584mr3118569wrr.49.1675774975995; Tue, 07 Feb 2023 05:02:55 -0800 (PST) Original-Received: from vibhavp-mbp.local ([182.69.182.68]) by smtp.gmail.com with ESMTPSA id o13-20020a5d408d000000b002c3f42f3687sm1595582wrp.72.2023.02.07.05.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 05:02:54 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255042 Archived-At: --=-KSo9Ok7Greuz1sQEVd6c Content-Type: multipart/mixed; boundary="=-cQV0tduUelR8ljl3UFSJ" --=-cQV0tduUelR8ljl3UFSJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2023-02-02 at 11:04 -0500, Stefan Monnier wrote: > > Alternatively, we could define a macro, store its expanded form in > > a > > variable and run it through `cconv-closure-convert`, checking > > afterwards whether the original value changed or not. It feels a > > little > > more reliable, but writing it might be a little tricky. >=20 > I was thinking of doing something like: >=20 > =C2=A0=C2=A0=C2=A0 (let ((f '(lambda () (interactive ...) ...))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (should (equal f > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let ((fc (copy-tree f))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (byte-compile = fc) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fc)))) >=20 >=20 > -- Stefan >=20 I wrote a variant of this that specifically calls `cconv-closure- convert`, and checks if the interactive spec has been modified, using `eq`. It fails on master, and passes with the patch installed. --=20 Vibhav Pant vibhavp@gmail.com GPG: 7ED1 D48C 513C A024 BE3A 785F E3FB 28CB 6AB5 9598 --=-cQV0tduUelR8ljl3UFSJ Content-Disposition: attachment; filename="60974-tests.diff" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="60974-tests.diff"; charset="UTF-8" ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jY29udi5lbCBiL2xpc3AvZW1hY3MtbGlzcC9j Y29udi5lbAppbmRleCBlOGQ2Mzk5MDNjMS4uODFmOGQ1YWQzNjIgMTAwNjQ0Ci0tLSBhL2xpc3Av ZW1hY3MtbGlzcC9jY29udi5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvY2NvbnYuZWwKQEAgLTQ3 Nyw3ICs0NzcsNyBAQCBjY29udi1jb252ZXJ0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYnJhbmNoKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmQt Zm9ybXMpKSkKIAotICAgIChgKGZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MgLiAsYm9keSkgLiAsXykK KyAgICAoYChmdW5jdGlvbiAobGFtYmRhICxhcmdzIC4gLGJvZHkpIC4gLHJlc3QpCiAgICAgIChs ZXQqICgoZG9jc3RyaW5nIChpZiAoZXEgOmRvY3VtZW50YXRpb24gKGNhci1zYWZlIChjYXIgYm9k eSkpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNjb252LWNvbnZlcnQgKGNhZHIgKHBv cCBib2R5KSkgZW52IGV4dGVuZCkpKQogICAgICAgICAgICAgKGJmIChpZiAoc3RyaW5ncCAoY2Fy IGJvZHkpKSAoY2RyIGJvZHkpIGJvZHkpKQpAQCAtNDg1LDE1ICs0ODUsMzIgQEAgY2NvbnYtY29u dmVydAogICAgICAgICAgICAgICAgICAgKGdldGhhc2ggZm9ybSBjY29udi0taW50ZXJhY3RpdmUt Zm9ybS1mdW5zKSkpCiAgICAgICAgICAgICAod3JhcHBlZCAocGNhc2UgaWYgKGAjJyhsYW1iZGEg KF9jY29udi0tZHVtbXkpIC4sXykgdCkgKF8gbmlsKSkpCiAgICAgICAgICAgICAoY2lmICh3aGVu IGlmIChjY29udi1jb252ZXJ0IGlmIGVudiBleHRlbmQpKSkKLSAgICAgICAgICAgIChfIChwY2Fz ZSBjaWYKLSAgICAgICAgICAgICAgICAgKCduaWwgbmlsKQotICAgICAgICAgICAgICAgICAoYCMn LGYKLSAgICAgICAgICAgICAgICAgIChzZXRmIChjYWRyIChjYXIgYmYpKSAoaWYgd3JhcHBlZCAo bnRoIDIgZikgY2lmKSkKLSAgICAgICAgICAgICAgICAgIChzZXRxIGNpZiBuaWwpKQotICAgICAg ICAgICAgICAgICA7OyBUaGUgaW50ZXJhY3RpdmUgZm9ybSBuZWVkcyBzcGVjaWFsIHRyZWF0bWVu dCwgc28gdGhlIGZvcm0KLSAgICAgICAgICAgICAgICAgOzsgaW5zaWRlIHRoZSBgaW50ZXJhY3Rp dmUnIHdvbid0IGJlIHVzZWQgYW55IGZ1cnRoZXIuCi0gICAgICAgICAgICAgICAgIChfIChzZXRm IChjYWRyIChjYXIgYmYpKSBuaWwpKSkpCi0gICAgICAgICAgICAoY2YgKGNjb252LS1jb252ZXJ0 LWZ1bmN0aW9uIGFyZ3MgYm9keSBlbnYgZm9ybSBkb2NzdHJpbmcpKSkKKyAgICAgICAgICAgIChj ZiBuaWwpKQorICAgICAgIDs7IFRPRE86IEJlY2F1c2Ugd2UgbmVlZCB0byBub24tZGVzdHJ1Y3Rp dmVseSBtb2RpZnkgYm9keSwgdGhpcyBjb2RlCisgICAgICAgOzsgaXMgcGFydGljdWxhcmx5IHVn bHkuICBUaGlzIHNob3VsZCBpZGVhbGx5IGJlIG1vdmVkIHRvCisgICAgICAgOzsgY2NvbnYtLWNv bnZlcnQtZnVuY3Rpb24uCisgICAgICAgKHBjYXNlIGNpZgorICAgICAgICAgKCduaWwgKHNldHEg YmYgbmlsKSkKKyAgICAgICAgIChgIycsZgorICAgICAgICAgIChwY2FzZS1sZXQgKChgKCgsZjEg LiAoLF8gLiAsZjIpKSAuICxmMykgYmYpKQorICAgICAgICAgICAgKHNldHEgYmYgYCgoLGYxIC4g KCwoaWYgd3JhcHBlZCAobnRoIDIgZikgY2lmKSAuICxmMikpIC4gLGYzKSkpCisgICAgICAgICAg KHNldHEgY2lmIG5pbCkpCisgICAgICAgICA7OyBUaGUgaW50ZXJhY3RpdmUgZm9ybSBuZWVkcyBz cGVjaWFsIHRyZWF0bWVudCwgc28gdGhlIGZvcm0KKyAgICAgICAgIDs7IGluc2lkZSB0aGUgYGlu dGVyYWN0aXZlJyB3b24ndCBiZSB1c2VkIGFueSBmdXJ0aGVyLgorICAgICAgICAgKF8gKHBjYXNl LWxldCAoKGAoKCxmMSAuICgsXyAuICxmMikpIC4gLGYzKSBiZikpCisgICAgICAgICAgICAgIChz ZXRxIGJmIGAoKCxmMSAuIChuaWwgLiAsZjIpKSAuICxmMykpKSkpCisgICAgICAgKHdoZW4gYmYK KyAgICAgICAgIDs7IElmIHdlIG1vZGlmaWVkIGJmLCByZS1idWlsZCBib2R5IGFuZCBmb3JtIGFz CisgICAgICAgICA7OyBjb3BpZXMgd2l0aCB0aGUgbW9kaWZpZWQgYml0cy4KKyAgICAgICAgIChz ZXRxIGJvZHkgKGlmIChzdHJpbmdwIChjYXIgYm9keSkpCisgICAgICAgICAgICAgICAgICAgICAg ICAoY29ucyAoY2FyIGJvZHkpIGJmKQorICAgICAgICAgICAgICAgICAgICAgIGJmKQorICAgICAg ICAgICAgICAgZm9ybSBgKGZ1bmN0aW9uIChsYW1iZGEgLGFyZ3MgLiAsYm9keSkgLiAscmVzdCkp CisgICAgICAgICA7OyBBbHNvLCByZW1vdmUgdGhlIGN1cnJlbnQgb2xkIGVudHJ5IG9uIHRoZSBh bGlzdCwgcmVwbGFjaW5nCisgICAgICAgICA7OyBpdCB3aXRoIHRoZSBuZXcgb25lLgorICAgICAg ICAgKGxldCAoKGVudHJ5IChwb3AgY2NvbnYtZnJlZXZhcnMtYWxpc3QpKSkKKyAgICAgICAgICAg KHB1c2ggKGNvbnMgYm9keSAoY2RyIGVudHJ5KSkgY2NvbnYtZnJlZXZhcnMtYWxpc3QpKSkKKyAg ICAgICAoc2V0cSBjZiAoY2NvbnYtLWNvbnZlcnQtZnVuY3Rpb24gYXJncyBib2R5IGVudiBmb3Jt IGRvY3N0cmluZykpCiAgICAgICAgKGlmIChub3QgY2lmKQogICAgICAgICAgICA7OyBOb3JtYWwg Y2FzZSwgdGhlIGludGVyYWN0aXZlIGZvcm0gbmVlZHMgbm8gc3BlY2lhbCB0cmVhdG1lbnQuCiAg ICAgICAgICAgIGNmCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9jY29udi10ZXN0 cy5lbCBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2Njb252LXRlc3RzLmVsCmluZGV4IDgzMDEzY2Y0 NmE5Li5jNzIxMzdlNWQ0NyAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2NvbnYt dGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvY2NvbnYtdGVzdHMuZWwKQEAgLTM2 NCw1ICszNjQsMTggQEAgY2NvbnYtdGVzdHMtaW50ZXJhY3RpdmUtY2xvc3VyZS1idWc1MTY5NQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSBmKSkKICAgICAg ICAgICAgICAgICAgICAgICcoKHQgNTE2OTYpIChuaWwgNTE2OTUpICh0IDUxNjk3KSkpKSkpKQog CisoZXJ0LWRlZnRlc3QgY2NvbnYtdGVzdHMtaW50ZXJhY3RpdmUtZm9ybS1tb2RpZnktYnVnNjA5 NzQgKCkKKyAgKGxldCogKChmICcoZnVuY3Rpb24gKGxhbWJkYSAoJm9wdGlvbmFsIGFyZykKKwkJ ICAgICAgICAgKGludGVyYWN0aXZlCisJCSAgICAgICAgICAobGlzdCAoaWYgY3VycmVudC1wcmVm aXgtYXJnCisJCQkJICAgIChwcmVmaXgtbnVtZXJpYy12YWx1ZSBjdXJyZW50LXByZWZpeC1hcmcp CisJCQkgICAgICAgICAgJ3RvZ2dsZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgIChpZ25v cmUgYXJnKSkpKQorICAgICAgICAgKGlmIChjYWRyIChudGggMiAoY2FkciBmKSkpKQorICAgICAg ICAgKGlmMikpCisgICAgKGNjb252LWNsb3N1cmUtY29udmVydCBmKQorICAgIChzZXRxIGlmMiAo Y2FkciAobnRoIDIgKGNhZHIgZikpKSkKKyAgICAoc2hvdWxkIChlcSBpZiBpZjIpKSkpCisKIChw cm92aWRlICdjY29udi10ZXN0cykKIDs7OyBjY29udi10ZXN0cy5lbCBlbmRzIGhlcmUK --=-cQV0tduUelR8ljl3UFSJ-- --=-KSo9Ok7Greuz1sQEVd6c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmPiS/YACgkQ4/soy2q1 lZibqAgAhiUWmO7fuN01vZdQVyg68BWQilrsjZZc/Yq3/Yjy2MbTTRhd5LsayhDC 8dirQaKCqizlW4+iFzGtfW20H3FYReq4SXR8Yfs2uSEfoviaNwUW68Oq9FTDhJ5T lY59xUagwxg2gOqfse107j2FmHnf5UoC3j+nv33RZqCxj+7KB3wdw7954QXxPOyI yzwChr2LdFhvOA9U7ApZ66AN9MDY1UHorLwhV7PsFMARf0ovM8v6vW30PHTdzW0d 5rlAKvrx0TlaRgD0Z2a+kk5bVm67OKbbVWmEiTcnIfCsk1dmTzp1+ccir/w90rXY ZUkW5n5DBlX3Cru2E1eBUYFpgU2jQw== =Bcpr -----END PGP SIGNATURE----- --=-KSo9Ok7Greuz1sQEVd6c--