From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#57499: Documentation bug in the docstring of set-face-attribute? Date: Thu, 01 Sep 2022 13:15:42 +0000 Message-ID: References: <534c9018d2adffda3e53@heytings.org> <831qswu0p4.fsf@gnu.org> <534c9018d2f372cd7462@heytings.org> <83tu5ssi35.fsf@gnu.org> <534c9018d222586a161c@heytings.org> <83r10wsgu8.fsf@gnu.org> <534c9018d2952b7a6bd0@heytings.org> <83pmggs89x.fsf@gnu.org> <534c9018d2597d4fd752@heytings.org> <83fshcrzth.fsf@gnu.org> <534c9018d2c911550778@heytings.org> <83czcgry5f.fsf@gnu.org> <534c9018d2f901e88b93@heytings.org> <837d2nshh7.fsf@gnu.org> <834jxrscu7.fsf@gnu.org> <831qsvs51j.fsf@gnu.org> <83sflbqotm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="LcF5tTStL5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22530"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57499-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 01 15:16:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTk3M-0005cS-U6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Sep 2022 15:16:17 +0200 Original-Received: from localhost ([::1]:41288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTk3L-00052b-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Sep 2022 09:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTk38-00052I-Di for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 09:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTk38-0002Mh-3P for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTk37-0000km-UD for bug-gnu-emacs@gnu.org; Thu, 01 Sep 2022 09:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Sep 2022 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57499 X-GNU-PR-Package: emacs Original-Received: via spool by 57499-done@debbugs.gnu.org id=D57499.16620381452544 (code D ref 57499); Thu, 01 Sep 2022 13:16:01 +0000 Original-Received: (at 57499-done) by debbugs.gnu.org; 1 Sep 2022 13:15:45 +0000 Original-Received: from localhost ([127.0.0.1]:41596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTk2q-0000eP-WA for submit@debbugs.gnu.org; Thu, 01 Sep 2022 09:15:45 -0400 Original-Received: from heytings.org ([95.142.160.155]:50246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTk2p-0000YT-P0 for 57499-done@debbugs.gnu.org; Thu, 01 Sep 2022 09:15:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1662038142; bh=anaoSsztxB7r9D+yPSrS3IvMDQJh0E09PVR5AlQlWjI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=R4Sav68arwgT1+cEx1eybLZffqSwutYCNHH9JmarjU+Ng2P2O+bf3sVPjIEmwmrtn yA5ioBHtYFEXv3wdsaeJWP6DUhDDt9kZSySiqTci1I+5lssYudWb7yzy7R+Va06rVk Mzow0QAPEtd353vVoSf6VKXCRRKesJhWuZq5Pp/+dTHV2chIoPAaVIRPO/mUlBO9Qn iMsXMqW0Dd2bSuq0t66rwp97nsu61waWlNMCqK9iZ3O7nR2mhrQOXEncGD/b47dcpE 7cDf1sBjHCoKR0ocPOjIg83kS5BcpCOLvQWm0voJPAOHzKmBvalz5UjakzuG4Bt8tE 8JafunoN8OSHg== In-Reply-To: <83sflbqotm.fsf@gnu.org> Content-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241261 Archived-At: --LcF5tTStL5 Content-Type: text/plain; charset=us-ascii; format=flowed Content-ID: >> Would a warning in *Messages* be okay then? > > We could try that, yes. But it has to be only in *Messages*, not an > actual warning, since faces get merged and realized as part of > redisplay, when signaling an error is a bad idea. > Like this? I just checked, it passes make bootstrap and make check. --LcF5tTStL5 Content-Type: text/x-diff; name=Display-a-warning-when-using-nil-as-a-face-attribute.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=Display-a-warning-when-using-nil-as-a-face-attribute.patch RnJvbSBjMzdiMmNmZGY5YzVjYmNiYTdjYzE3NGZjZjhkNmQxNzE1MmM4OGEy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBUaHUsIDEgU2Vw IDIwMjIgMTM6MDI6MjcgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gRGlzcGxh eSBhIHdhcm5pbmcgd2hlbiB1c2luZyBuaWwgYXMgYSBmYWNlIGF0dHJpYnV0 ZSB2YWx1ZS4NCg0KKiBzcmMveGZhY2VzLmMgKEZpbnRlcm5hbF9zZXRfbGlz cF9mYWNlX2F0dHJpYnV0ZSk6IFVzaW5nIHRoZQ0KYXR0cmlidXRlIHZhbHVl IG5pbCBmb3IgdGhlIGZhY2UgYXR0cmlidXRlcyBmb3JlZ3JvdW5kLA0KZGlz dGFudC1mb3JlZ3JvdW5kIGFuZCBiYWNrZ3JvdW5kIGlzIGEgYmFja3dhcmQg Y29tcGF0aWJpbGl0eSBmZWF0dXJlLA0KdGhhdCB3b3JrcyBvbmx5IHdpdGgg ZXhpc3RpbmcgZnJhbWVzLiAgVXNpbmcgaXQgd2l0aCBmcmFtZSA9IHQgKGFu ZA0KdGhlcmVmb3JlIGFsc28gd2l0aCBmcmFtZSA9IG5pbCkgd2lsbCBub3Qg cHJvZHVjZSB0aGUgZXhwZWN0ZWQgZWZmZWN0Lg0KRGlzcGxheSBhIHdhcm5p bmcgaW4gdGhlc2UgY2FzZXMuDQotLS0NCiBzcmMveGZhY2VzLmMgfCAxOSAr KysrKysrKysrKysrKysrKysrDQogMSBmaWxlIGNoYW5nZWQsIDE5IGluc2Vy dGlvbnMoKykNCg0KZGlmZiAtLWdpdCBhL3NyYy94ZmFjZXMuYyBiL3NyYy94 ZmFjZXMuYw0KaW5kZXggNzBkNWNiZWI0Yy4uZGI3YmMwMjhjNSAxMDA2NDQN Ci0tLSBhL3NyYy94ZmFjZXMuYw0KKysrIGIvc3JjL3hmYWNlcy5jDQpAQCAt MzA1MSw2ICszMDUxLDIyIEBAIERFRlVOICgiaW50ZXJuYWwtY29weS1saXNw LWZhY2UiLCBGaW50ZXJuYWxfY29weV9saXNwX2ZhY2UsDQogICByZXR1cm4g dG87DQogfQ0KIA0KK2NoYXIgd2FybmluZ19hdHRyaWJ1dGVfbmlsW10gPQ0K KyAgIldhcm5pbmc6IHVzaW5nIDolcyBuaWwgd2l0aCBmcmFtZSB0IGhhcyBu byBlZmZlY3QuIjsNCisNCisjZGVmaW5lIFdBUk5JTkdfQVRUUklCVVRFX05J TChTKQkJCQkJXA0KKyAgaWYgKE5JTFAgKHZhbHVlKSAmJiBFUSAoZnJhbWUs IFF0KSkJCQkJCVwNCisgICAgewkJCQkJCQkJCVwNCisgICAgICBpZiAocmVk aXNwbGF5aW5nX3ApCQkJCQkJXA0KKwlDQUxMTiAoRm1lc3NhZ2UsCQkJCQkJ XA0KKwkgICAgICAgYnVpbGRfc3RyaW5nICh3YXJuaW5nX2F0dHJpYnV0ZV9u aWwpLAkJCVwNCisJICAgICAgIGJ1aWxkX3N0cmluZyAoUykpOwkJCQkJXA0K KyAgICAgIGVsc2UJCQkJCQkJCVwNCisJRnNpZ25hbCAoUXVzZXJfZXJyb3Is CQkJCQkJXA0KKwkJIGxpc3QxIChDQUxMTiAoRmZvcm1hdCwJCQkJCVwNCisJ CQkgICAgICAgYnVpbGRfc3RyaW5nICh3YXJuaW5nX2F0dHJpYnV0ZV9uaWwp LAlcDQorCQkJICAgICAgIGJ1aWxkX3N0cmluZyAoUykpKSk7CQkJXA0KKyAg ICB9DQogDQogREVGVU4gKCJpbnRlcm5hbC1zZXQtbGlzcC1mYWNlLWF0dHJp YnV0ZSIsIEZpbnRlcm5hbF9zZXRfbGlzcF9mYWNlX2F0dHJpYnV0ZSwNCiAg ICAgICAgU2ludGVybmFsX3NldF9saXNwX2ZhY2VfYXR0cmlidXRlLCAzLCA0 LCAwLA0KQEAgLTMzOTAsNiArMzQwNiw3IEBAIERFRlVOICgiaW50ZXJuYWwt c2V0LWxpc3AtZmFjZS1hdHRyaWJ1dGUiLCBGaW50ZXJuYWxfc2V0X2xpc3Bf ZmFjZV9hdHRyaWJ1dGUsDQogICAgIH0NCiAgIGVsc2UgaWYgKEVRIChhdHRy LCBRQ2ZvcmVncm91bmQpKQ0KICAgICB7DQorICAgICAgV0FSTklOR19BVFRS SUJVVEVfTklMICgiZm9yZWdyb3VuZCIpOw0KICAgICAgIC8qIENvbXBhdGli aWxpdHkgd2l0aCAyMC54LiAgKi8NCiAgICAgICBpZiAoTklMUCAodmFsdWUp KQ0KIAl2YWx1ZSA9IFF1bnNwZWNpZmllZDsNCkBAIC0zNDA5LDYgKzM0MjYs NyBAQCBERUZVTiAoImludGVybmFsLXNldC1saXNwLWZhY2UtYXR0cmlidXRl IiwgRmludGVybmFsX3NldF9saXNwX2ZhY2VfYXR0cmlidXRlLA0KICAgICB9 DQogICBlbHNlIGlmIChFUSAoYXR0ciwgUUNkaXN0YW50X2ZvcmVncm91bmQp KQ0KICAgICB7DQorICAgICAgV0FSTklOR19BVFRSSUJVVEVfTklMICgiZGlz dGFudC1mb3JlZ3JvdW5kIik7DQogICAgICAgLyogQ29tcGF0aWJpbGl0eSB3 aXRoIDIwLnguICAqLw0KICAgICAgIGlmIChOSUxQICh2YWx1ZSkpDQogCXZh bHVlID0gUXVuc3BlY2lmaWVkOw0KQEAgLTM0MjgsNiArMzQ0Niw3IEBAIERF RlVOICgiaW50ZXJuYWwtc2V0LWxpc3AtZmFjZS1hdHRyaWJ1dGUiLCBGaW50 ZXJuYWxfc2V0X2xpc3BfZmFjZV9hdHRyaWJ1dGUsDQogICAgIH0NCiAgIGVs c2UgaWYgKEVRIChhdHRyLCBRQ2JhY2tncm91bmQpKQ0KICAgICB7DQorICAg ICAgV0FSTklOR19BVFRSSUJVVEVfTklMICgiYmFja2dyb3VuZCIpOw0KICAg ICAgIC8qIENvbXBhdGliaWxpdHkgd2l0aCAyMC54LiAgKi8NCiAgICAgICBp ZiAoTklMUCAodmFsdWUpKQ0KIAl2YWx1ZSA9IFF1bnNwZWNpZmllZDsNCi0t IA0KMi4zNS4xDQoNCg== --LcF5tTStL5--