From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#67404: 30.0.50; Issue with :box face attribute Date: Thu, 30 Nov 2023 07:46:02 -0300 Message-ID: References: <986eaa76-521b-4325-a510-e9a8e374bf49@orange.fr> <83cyvwbyic.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31223"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 67404@debbugs.gnu.org To: Eli Zaretskii , David Ponce Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 30 11:47:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8eaB-0007tI-69 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Nov 2023 11:47:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8eZO-0000Bz-TD; Thu, 30 Nov 2023 05:46:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8eZL-0000BM-L0 for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:46:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8eZK-0006b8-Ky for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:46:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8eZS-0004DH-LB for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Nov 2023 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67404 X-GNU-PR-Package: emacs Original-Received: via spool by 67404-submit@debbugs.gnu.org id=B67404.170134118216114 (code B ref 67404); Thu, 30 Nov 2023 10:47:02 +0000 Original-Received: (at 67404) by debbugs.gnu.org; 30 Nov 2023 10:46:22 +0000 Original-Received: from localhost ([127.0.0.1]:52413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8eYn-0004Bq-Px for submit@debbugs.gnu.org; Thu, 30 Nov 2023 05:46:22 -0500 Original-Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:52575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8eYl-0004Ba-UG for 67404@debbugs.gnu.org; Thu, 30 Nov 2023 05:46:20 -0500 Original-Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5c5ff5a69f0so662202a12.1 for <67404@debbugs.gnu.org>; Thu, 30 Nov 2023 02:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701341166; x=1701945966; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UaS1DtWA4YtnDXBaqnH0uX9eZleWw2zvKzhBbsTuaos=; b=jY2NVsClrB24K0WRxdwPG3Zmiug5VKDBHQHuMnXXVhVpO6sfQU9RZ8sOjJQZ9ZNdaZ 5uek0gD46UpbgXa80PiDKCvXxSlw3M/98Vb+A02jrYPCzVuKgWz2/zPYtnnAzRkHzAmi nyQwx3jLGIQyNK87tnDPTu+ezlW6h8Ay4raiAgGCg1VabvGtDBd60bykDSv9EXegkj/A YVV8UfwfVeHgYwtX2En5aCsQ5H5cnySynapI+C/he363A5CQkij3xuETAIwPp7R1p0Ee YUK6FQfeOY/jZmhgTRsSpelvX/TMtfi/NCS/+CtlOGRx8BQkOb0FORPggzSuCQAt7oRM cVJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701341166; x=1701945966; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UaS1DtWA4YtnDXBaqnH0uX9eZleWw2zvKzhBbsTuaos=; b=u4HKGNfCbWJY98QD9S0Dt/hMoNPC/m0uu2gN0x3kgJHQBZK9gdocbr9KIMlaMGmPE4 ZlMpeXuvpUzqLtI/Hx5uZkXr5JuZmvCF8m5bTgeNgcZeUa1g18xn1v1OunqvZJpMjBQE Tl7/QQveZFvo02cde+0xyLwJVbjh0ieM2cqdsTSSUITgNlPI2QawBmTGer5YIH7reEQ4 QkdpAd6UcjJ4bvxQt/5LWh0xecXtln2Np369SyurnW4m2lS+CHi40zIRAXlr9ko5ioJb /vdTJ81xjQTfzNmwK25MM+pBGYwlqdwrSixHBtn2Tgo9Xa3Hs1pxPOkTEpTCNXNWkNDS 1JlA== X-Gm-Message-State: AOJu0YwoF9I28PS4QgOmymHJisK5eCvdB+dufH79Xek/YrBBaDeQtruT LvuJmm87UNVSV9y50v6KuI8= X-Google-Smtp-Source: AGHT+IEDJaIIyt4j1Za6WP+CqO3skIRKek8vtIgXcuan1MWFr+XMNFF/YmnXLUxoY+Dg5wofYe46ww== X-Received: by 2002:a05:6a20:2451:b0:18b:90fc:c266 with SMTP id t17-20020a056a20245100b0018b90fcc266mr24707991pzc.38.1701341166027; Thu, 30 Nov 2023 02:46:06 -0800 (PST) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id v5-20020aa78505000000b006cbadbf20ddsm893728pfn.187.2023.11.30.02.46.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 02:46:05 -0800 (PST) Content-Language: en-US In-Reply-To: <83cyvwbyic.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275284 Archived-At: On 26/11/23 07:27, Eli Zaretskii wrote: >> Date: Thu, 23 Nov 2023 16:23:15 +0100 >> From: David Ponce >> >> Hello, >> >> The below face with specified :box attribute can be defined and further >> used without problem: >> >> (defface test-face >>    '((t >>       (:box (:style released-button :line-width (3 . 0))) >>       )) >>    "Test face.") >> >> (insert (propertize "XXXXX" 'face 'test-face)) >> >> However, it is not possible to apply any change to this face with >> `customize-face', for example to change :line-width (3 . 0) to >> :line-width (2 . 0), or to add a :foreground color, etc. This fails >> with the message "set-face-attribute: Invalid face box: :line-width, >> , :style, ", and the :box attribute is discarded. >> >> AFAICS, :box attribute with any zero :line-width value works as >> expected: the box line with zero width is not displayed. But zero is >> not considered as a valid value by `set-face-attribute' (in fact, the >> internal function `internal-set-lisp-face-attribute'). >> >> For consistency, a zero :line-width value either should be accepted by >> `internal-set-lisp-face-attribute', or never accepted at all. > > Mauro, any comments about these issues? Hi Eli, Not really, no.  The widget used for line-width just assumes 0 is a valid value.  I don't know if that's the case or not, it is not explicitly documented in the ELisp manual and I don't really know the xfaces.c code. For some reason, the code that rejects a value of 0 in Finternal_set_lisp_face_attribute doesn't complain (maybe it does not get to run?) when using defface, but it does complain when Customize tries to set it, by calling face-spec-set. Sorry I can't be of any more help right now.