unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>,
	Eli Zaretskii <eliz@gnu.org>
Cc: 23926@debbugs.gnu.org
Subject: bug#23926: defcustom with STANDARD=<non-pure-expression> gives confusing results
Date: Sat, 9 Jul 2016 14:34:00 +0000 (UTC)	[thread overview]
Message-ID: <f5553151-5e5a-4e98-8b2b-23af63b81cb2@default> (raw)
In-Reply-To: <CAM-tV--4-9NVU3BodydvqE_m1VyFUOmstbaXU7fZfdNA-xbj0w@mail.gmail.com>

> Either really save the original value, or don't call it the "original
> value". We can't use "default value" because that's already used for
> the non-buffer local value, unfortunately. I think "standard value"
> could work, though Drew said it was unclear.

If it is what custom calls the "standard value", which is what
you get when you `Reset to Standard Setting', then I don't
think it is wrong to use that name here.

But I think that `C-h v' - or at a minimum somewhere in the
manual - should point out what is happening here:

The value shown is the result of re-evaluating, in the current
context, the original expression that was used to define the
initial value.

Each part of that sentence is important to understanding what
this is.  We should not just suppose that all of that is
understood by a user, just by providing a label such as
"standard value" (let alone a misleading label such as
"original value").

It's OK to just provide a (reasonable) label, I guess, _if_
it is clearly defined somewhere in the doc.

I really think that it would be good to show in `C-h v'
(also), the original expression.  That is available in
Customize (good), by choosing `Show Saved Lisp Expression'.

But if we are going to show, in `C-h v', what is currently
called "original value" there, then we should (1) use a
better name for it (e.g. "standard value") and (2) provide
also the expression that it was re-evaluated from.

As for how to show that expression: if small, show it inline;
if large, show it on demand (e.g. clicking an expand button).





  parent reply	other threads:[~2016-07-09 14:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09  3:11 bug#23926: defcustom with STANDARD=<non-pure-expression> gives confusing results Noam Postavsky
2016-07-09  6:31 ` Drew Adams
2016-07-09  7:13 ` Eli Zaretskii
2016-07-09 11:54   ` npostavs
2016-07-09 12:31     ` Eli Zaretskii
2016-07-09 12:55       ` Noam Postavsky
2016-07-09 13:14         ` Eli Zaretskii
2016-07-09 13:48           ` Noam Postavsky
2016-07-09 14:03             ` Eli Zaretskii
2016-07-12  3:26               ` npostavs
2016-07-12  5:20                 ` Eli Zaretskii
2016-07-09 14:34             ` Drew Adams [this message]
     [not found]             ` <<8360sehps4.fsf@gnu.org>
2016-07-09 14:54               ` Drew Adams
2016-07-09 15:09                 ` Drew Adams
2016-07-10 17:23                 ` Drew Adams
2023-10-17 14:19 ` bug#23926: defcustom with STANDARD=<non-constant-expression> " Mauro Aranda
2023-10-17 14:29   ` Mauro Aranda
     [not found] <<<<<CAM-tV-8cG3gLgf-A+wBYPZWNy2WPGFV3uEdNE7=ad3oq4rXmnw@mail.gmail.com>
     [not found] ` <<<<<83vb0fgu83.fsf@gnu.org>
     [not found]   ` <<<<443f2e44-5167-48e7-abc6-cce1e243461e@default>
     [not found]     ` <<<<8337nihpdw.fsf@gnu.org>
     [not found]       ` <<<c0dd88c2-51ef-4f4f-964c-f0254db970f7@default>
     [not found]         ` <<<83zipqg3e3.fsf@gnu.org>
     [not found]           ` <<ff33c2cc-337a-433b-a87a-0ea1814311d2@default>
     [not found]             ` <<83bn24c8io.fsf@gnu.org>
2016-07-12  0:53               ` bug#23926: defcustom with STANDARD=<non-pure-expression> " Drew Adams
     [not found] <<<CAM-tV-8cG3gLgf-A+wBYPZWNy2WPGFV3uEdNE7=ad3oq4rXmnw@mail.gmail.com>
     [not found] ` <<<83vb0fgu83.fsf@gnu.org>
     [not found]   ` <<443f2e44-5167-48e7-abc6-cce1e243461e@default>
     [not found]     ` <<8337nihpdw.fsf@gnu.org>
2016-07-09 14:59       ` Drew Adams
2016-07-09 16:52         ` Eli Zaretskii
2016-07-09 20:48           ` npostavs
2016-07-10 14:19             ` Eli Zaretskii
     [not found]           ` <<871t32ilm0.fsf@users.sourceforge.net>
     [not found]             ` <<83k2gtfue4.fsf@gnu.org>
2016-07-10 17:18               ` Drew Adams
2016-07-11 18:40                 ` Eli Zaretskii
     [not found] <<CAM-tV-8cG3gLgf-A+wBYPZWNy2WPGFV3uEdNE7=ad3oq4rXmnw@mail.gmail.com>
     [not found] ` <<83vb0fgu83.fsf@gnu.org>
2016-07-09 14:09   ` Drew Adams
2016-07-09 14:12     ` Eli Zaretskii
     [not found]       ` <<c0dd88c2-51ef-4f4f-964c-f0254db970f7@default>
     [not found]         ` <<83zipqg3e3.fsf@gnu.org>
2016-07-10 17:18           ` Drew Adams
2016-07-11 18:52             ` Eli Zaretskii
     [not found] <<<<CAM-tV-8cG3gLgf-A+wBYPZWNy2WPGFV3uEdNE7=ad3oq4rXmnw@mail.gmail.com>
     [not found] ` <<<<83vb0fgu83.fsf@gnu.org>
     [not found]   ` <<<443f2e44-5167-48e7-abc6-cce1e243461e@default>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5553151-5e5a-4e98-8b2b-23af63b81cb2@default \
    --to=drew.adams@oracle.com \
    --cc=23926@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).