From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Mon, 2 Dec 2019 12:39:47 +0200 Message-ID: References: <87ftj5at1q.fsf@gnus.org> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87pnhl9biu.fsf@gmx.net> <8336egxtja.fsf@gnu.org> <8736e4b34t.fsf@gmx.net> <83k17glyog.fsf@gnu.org> <02a9ce39-b741-e024-3af6-74ad0b841bc4@yandex.ru> <875zizafo1.fsf@rub.de> <835zizmmdq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144082"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 11:40:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibj7k-000bPb-G3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 11:40:12 +0100 Original-Received: from localhost ([::1]:33750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibj7i-0007oP-MV for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 05:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36333) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibj7b-0007oJ-Us for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 05:40:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibj7a-0003EG-R0 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 05:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59404) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibj7a-0003E4-NH for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 05:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibj7a-0004Nh-LO for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 05:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2019 10:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157528319716826 (code B ref 38044); Mon, 02 Dec 2019 10:40:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 2 Dec 2019 10:39:57 +0000 Original-Received: from localhost ([127.0.0.1]:37144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibj7V-0004NK-Cw for submit@debbugs.gnu.org; Mon, 02 Dec 2019 05:39:57 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:35038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibj7T-0004N7-JG for 38044@debbugs.gnu.org; Mon, 02 Dec 2019 05:39:56 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id g17so11513158wro.2 for <38044@debbugs.gnu.org>; Mon, 02 Dec 2019 02:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yNGtQu6Vc1iwg1C9n27Hr8CR5wdys/i+HxgJh+iRmKQ=; b=eOVHXCFpVhcTvUNtoksNEaDpMfaOZazZSnqQ1hFRiHPItvBhfE3RiyMb0Xq7O2retr wHVDoMQYdW+/SUt4JdKSuKWSVWGtoD5aB3ORRqsR9BAIiTJQygNX4V3AFmhE0wo6y909 saUbTbsw7um/AUqKl67UY0oOvS++HRYyHnZC6XYGqA/HtiGGdaaOyRlku1akgrw7A7cD Zi2A9uXbl9YDRMtmYLs1w0Y6DXd6m/ks7nKxvm5fYaWt9qLdjD9hiKIi+w0ujcJON7lu cRVLQEnele9SL5ZaJJ4PH/v94CErkQeQAZHDbLlmLdtkuFELZxB0JGfz8IiG4nj7YFrp 9WWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yNGtQu6Vc1iwg1C9n27Hr8CR5wdys/i+HxgJh+iRmKQ=; b=qvCYFsAP5J68PJcioWOSJ7RDJEnhmQ2BlZCn+dfQGFhnd9CpH9avKLnv/PB+/jgcTn tVosy2LAy+jKeYaTxFMSjD7wRVoocVLiqUTrU8KUdVYIGBzN/lvih9qTeEbzHASe7UJY W/JilcOzSFYKukuocHD0cI2qV0gA0v4bgJp8288qEZL07LzN9oBS1l2ahQgVUPWLuBK6 S0F7ta0ZkQIthwKYpd/pDS5O5psDCbjySqWQeGSXwYWrXfO1joMblUbpRP9PR+xieg2o 5oh5Nrbgb8dYR/XIya4tqBb1hIKikFEknxiuggsgoBvJy7GgEWc9Fzg9Rds6xJ3HnTrf /4JQ== X-Gm-Message-State: APjAAAX6/s67/GJ+rCBMxJiU5mF2lQXlEvoZGWnNqdmOf4WpNHlftwBK EaTLsDfb3MTK7/ral7SBvb0= X-Google-Smtp-Source: APXvYqx+3uJPw66a3UiGdlKWMpwGycEGKl9Cupo10H9tk0C2BGsl5s3WO9uJxEIU5NVjVZOS3iC3Nw== X-Received: by 2002:a5d:5592:: with SMTP id i18mr717088wrv.55.1575283189737; Mon, 02 Dec 2019 02:39:49 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o1sm24459181wrn.84.2019.12.02.02.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2019 02:39:48 -0800 (PST) In-Reply-To: <835zizmmdq.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172760 Archived-At: On 02.12.2019 5:34, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Mon, 2 Dec 2019 00:30:09 +0200 >> Cc: larsi@gnus.org, 38044@debbugs.gnu.org, juri@linkov.net >> >> On 01.12.2019 23:39, Stephen Berman wrote: >>> As mentioned near the start of this bug, I had already written my own >>> command to do essentially what `C-1 C-x v L' now does, but also >>> including the option I proposed. So I'll just keep using that command. >> >> Then we should keep this as is, for now. But thank you for the request, >> and others who need this as well should feel free to speak up. > > What do you think about replacing the call to thing-at-point with > number-at-point, where we look at the revision ID? Probably not: - Git revisions are SHA hashes, not numbers. Hg also has commit hashes, though they are less visible. - I'm pretty sure this command will be just as often used with symbolic refs such as branch names. So I'd rather use (thing-at-point 'symbol t) instead. Or a dedicated "thing" that does not depend on the buffer's syntax (and always includes slashes, hyphens and underscores in addition to alphanumerics).