From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63627: Improve plstore.el and fix various issues of it Date: Fri, 8 Sep 2023 11:16:50 +0200 Message-ID: References: <2063d5d2-ae9e-020a-3c19-54508ddbabab@vodafonemail.de> <37949bc5-c572-ff98-ebe6-9217ab7067cc@vodafonemail.de> <83cz2gfypg.fsf@gnu.org> <0101e7f1-970b-297c-836f-e9c0aa5e38a0@vodafonemail.de> <83cyz3g6oc.fsf@gnu.org> <8b00a564-c0d2-3072-50bc-530c50fa25b2@vodafonemail.de> <83pm319g3i.fsf@gnu.org> <24a502cc-9151-31bf-e0c6-078a400c6761@vodafonemail.de> <83r0naz6s1.fsf@gnu.org> <82b540c7-403b-3904-a16d-bda3c084f78a@vodafonemail.de> <83sf7pxlx9.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9781"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Cc: 63627@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 08 11:18:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeXcz-0002Kk-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Sep 2023 11:18:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeXcp-0006EQ-MW; Fri, 08 Sep 2023 05:18:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeXcn-0006Ds-FY for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 05:18:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeXcl-0002Ys-LN for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 05:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeXcn-0001SI-Hf for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 05:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63627 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63627-submit@debbugs.gnu.org id=B63627.16941646395538 (code B ref 63627); Fri, 08 Sep 2023 09:18:01 +0000 Original-Received: (at 63627) by debbugs.gnu.org; 8 Sep 2023 09:17:19 +0000 Original-Received: from localhost ([127.0.0.1]:42204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeXc7-0001RG-3z for submit@debbugs.gnu.org; Fri, 08 Sep 2023 05:17:19 -0400 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]:60090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeXc2-0001Qz-M5 for 63627@debbugs.gnu.org; Fri, 08 Sep 2023 05:17:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1694164627; bh=pPVRQkyE58e6F5uLce59FH+3tkx3Uw1A59yqOTM0f2g=; h=Message-ID:Date:User-Agent:From:Subject:To:References: Content-Language:In-Reply-To:Content-Type:From; b=c3rHMFa1HZAf09vOOI8AZ83AJIBpiHiEUKqWyUQDGFP8gGX/fgDQ/fKfbbD+EvcqV QsSmr21rb++z97HllfhKHcXrkyPBeywUbfOhuA6DR3gxISkA0hNkelsLDXp12HBoHq Fbd2D3GHBMU+HoRJIRR7pIVGBpQC/aEHCmimOHnU= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4Rhr8z076Vz1y65; Fri, 8 Sep 2023 09:17:06 +0000 (UTC) Original-Received: from [192.168.0.91] (unknown [80.121.255.154]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Rhr8q1FSnzMmXB; Fri, 8 Sep 2023 09:16:56 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <83sf7pxlx9.fsf@gnu.org> X-purgate-type: clean X-purgate: clean X-purgate-size: 1204 X-purgate-ID: 155817::1694164622-F5FF9E6D-A8764A8B/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269742 Archived-At: On 2023-09-08 07:40, Eli Zaretskii wrote: >> Date: Thu, 7 Sep 2023 21:27:13 +0200 >> From: Jens Schmidt >> Cc: 63627@debbugs.gnu.org >> Not sure how you prefer to get such long-running projects presented - >> as a series of minor (but self-contained!) patches over time or at >> once as one big set of patches. > > It is preferable to install separate patches only if each one of them > has merit on its own. E.g., imagine that some "force majeure" will > prevent you from working on further changes, and ask yourself whether > what you already have would make an improvement if installed. > > Changes that only make sense together are better submitted and > installed as a single patch. Good to know, thanks. > But if you personally prefer to submit a series of patches even when> they should be installed together, that's fine, it will just make them > slightly harder to review, especially if they touch the same code. Let's postpone the addition of the last outstanding patch, then. I'll add more tests to it and will come back to you later on this bug. Independently of the tests, I'll do the Emacs 29 bugs next, also on this bug.