From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39379@debbugs.gnu.org, wyuenho@gmail.com
Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode
Date: Tue, 4 Feb 2020 16:19:05 +0300 [thread overview]
Message-ID: <f4fe3bdf-8273-d7ee-6e18-3b9df2ddb6cb@yandex.ru> (raw)
In-Reply-To: <83pnevghgp.fsf@gnu.org>
On 04.02.2020 6:27, Eli Zaretskii wrote:
> I think this is for ido.el to do: it is ido.el that puts the cursor on
> the overlay string, so it is up to it to make sure the cursor can be
> put where it puts the 'cursor' property. It's a simple change: if the
> text to be displayed starts with a newline, prepend a SPC to it when
> defining the after-string.
But... the change in ido-vertical-mode is simpler still: just add an
extra argument to concat.
If we do that in ido.do, the reason why would be fairly non-obvious from
that code. After all, we don't provide any customization points in
there, hooks or otherwise. So we risk accidentally losing that change in
some future version.
next prev parent reply other threads:[~2020-02-04 13:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 23:53 bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Jimmy Yuen Ho Wong
2020-02-01 8:12 ` Eli Zaretskii
2020-02-02 13:58 ` Jimmy Yuen Ho Wong
2020-02-02 16:13 ` Eli Zaretskii
2020-02-02 17:23 ` Eli Zaretskii
2020-02-02 18:06 ` Eli Zaretskii
2020-02-02 18:38 ` Eli Zaretskii
2020-02-02 21:33 ` Jimmy Yuen Ho Wong
2020-02-03 3:21 ` Eli Zaretskii
2020-02-03 13:19 ` Dmitry Gutov
2020-02-03 15:40 ` Eli Zaretskii
2020-02-03 21:51 ` Dmitry Gutov
2020-02-04 3:27 ` Eli Zaretskii
2020-02-04 13:19 ` Dmitry Gutov [this message]
2020-02-04 15:40 ` Eli Zaretskii
2020-02-04 23:55 ` Dmitry Gutov
2020-02-05 3:36 ` Eli Zaretskii
2020-02-10 15:44 ` Eli Zaretskii
2020-02-11 23:42 ` Dmitry Gutov
2020-02-12 18:18 ` Eli Zaretskii
2020-02-12 18:24 ` Dmitry Gutov
2020-02-12 19:42 ` Eli Zaretskii
2020-03-03 14:02 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fe3bdf-8273-d7ee-6e18-3b9df2ddb6cb@yandex.ru \
--to=dgutov@yandex.ru \
--cc=39379@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=wyuenho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).