From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sat, 28 Aug 2021 01:47:12 +0300 Message-ID: References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <87o89ieruy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35843"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: Lars Ingebrigtsen , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 28 00:48:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJkdu-00099p-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 00:48:10 +0200 Original-Received: from localhost ([::1]:56434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJkdt-0000Wv-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 18:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJkdm-0000Wg-0Z for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 18:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJkdl-0002L7-Ot for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 18:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJkdl-0003tC-J9 for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 18:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 22:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163010444814909 (code B ref 39452); Fri, 27 Aug 2021 22:48:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 27 Aug 2021 22:47:28 +0000 Original-Received: from localhost ([127.0.0.1]:53139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJkdC-0003sN-IQ for submit@debbugs.gnu.org; Fri, 27 Aug 2021 18:47:27 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:45761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJkd7-0003s7-0Y for 39452@debbugs.gnu.org; Fri, 27 Aug 2021 18:47:25 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id n5so12526786wro.12 for <39452@debbugs.gnu.org>; Fri, 27 Aug 2021 15:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WDvowFPxpG7n5DDZyICVh7qI+YD1jNUIHyheek00Li0=; b=JxYF2Ov/uoFZ/5FYoy7B3WVJhglPStI9yyqrO7gDjHh+jhL7OREyzDo81zg+ljGmTH KGMsAIwbDdnHb0iv8+3mvjhnoh8LSupKC0p/bmfxSuqBvr1Wh6xo9OtUw57n15F0U/7E +2cCUVuGbzVcgCSag/5cmq+4ukhgCpGMNkN8zCy9Xk102J7lgxYL2tPHSLlvXztzroZB cID+FgW9GHKOGVc2J2HPmHFXQBlJY6gG2PWOQ2bJOPAX5Ah03MbJBNv0musXt+628u6k pmqfScM8FUa6X5wNZP8kzc/fk9FyG20tK+pO4FA0+GupaJBVluRVcZpjKBOl+SqrogRM V08Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WDvowFPxpG7n5DDZyICVh7qI+YD1jNUIHyheek00Li0=; b=QYZpSuhVF3aSCtSp7X53yVUbuYStUaZ7JfzXzbaHwoj5ixkmESXOp/ZieFUGy0ZnRW 0eM3dNFrmRvxbKiWdzWTho/VzFFoGevym/6/orS5i4I/DHIrtr6kh8JH6+n3Niyn+9ZG Z0yWZM3ZjsTSF5ZS+5R5SMITdo58ANXe5ELa86IHiTygXgAyXpcgI+gsk5aqW0eA/K7s LbCUybheMqQWKhtmklMLIXGpdmkaO+oKDQ9FIWCDDkTnuWOZOby7besNmJ4F+f5gDfHz iL88Q3kTO1EcleuEwpeMmSo+ETOCyUX1b3Ldj7akK4aI7VcPs05db+5P9XO4JUpwqCuh PvbA== X-Gm-Message-State: AOAM532+qrzgh0Tra/yKVl+1rPIgc58QwFSrlQtIna08TN0g6NpU2qJq gio1Rf5to3Ib3WhPN3q1+rc= X-Google-Smtp-Source: ABdhPJwJU3IHtpBV4953QM+UxvA7SH3Y2LC2ZjXi156W0b478RPH7fmx9yXIt5rnXx9hFK3hbG44xA== X-Received: by 2002:a5d:678f:: with SMTP id v15mr13155498wru.196.1630104434897; Fri, 27 Aug 2021 15:47:14 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a129sm5096727wme.14.2021.08.27.15.47.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Aug 2021 15:47:14 -0700 (PDT) In-Reply-To: <87o89ieruy.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212850 Archived-At: On 27.08.2021 20:10, Juri Linkov wrote: >>> - (vc-git-command nil 0 (vc-git--literal-pathspecs (list old new)) "mv" "-f" "--")) >>> + (vc-git-command nil 0 (list old new) "mv" "-f" "--")) >> >> Looks like the proper fix, thanks. Feel free to push it right away, if >> you like. > > Pushed now. Thank you. > I wonder how many git commands still remain broken > and will go unnoticed to the release? Such as > vc-git-delete-file and vc-git-mark-resolved, etc. Those two -- probably not. But you're welcome to try and report any problems. I'll try to fix and regressions now, but if people think we should go back to a different approach (for example, go back to the other solution, but use it in an opt-in fashion by passing --literal-pathspecs from every applicable command), we can do so too. >> Would be great to add some test, though. vc-tests.el currently doesn't >> exercise vc-rename-file at all. > > Indeed, covering all git commands will avoid the danger of breaking > some commands. Volunteers welcome.