From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Date: Fri, 20 Jul 2018 09:49:39 -0400 Message-ID: References: <031d18cf-e661-6dea-8882-38d75924d0d4@cornell.edu> <83601c4m37.fsf@gnu.org> <83in5b2w1q.fsf@gnu.org> <83d0vj2tu2.fsf@gnu.org> <6642c8ac-55ff-ca2b-0141-a26b69d082ad@cs.ucla.edu> <83y3e61jl2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1532094495 16794 195.159.176.226 (20 Jul 2018 13:48:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2018 13:48:15 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: p.stephani2@gmail.com, 32189@debbugs.gnu.org To: Eli Zaretskii , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 20 15:48:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgVlP-0004A1-2V for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 15:48:07 +0200 Original-Received: from localhost ([::1]:48314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgVnT-0001xT-NL for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 09:50:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgVnK-0001tq-Mq for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 09:50:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgVnG-0007TU-Rw for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 09:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgVnG-0007TM-MZ for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fgVnG-0002Rc-DP for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jul 2018 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32189-submit@debbugs.gnu.org id=B32189.15320945959374 (code B ref 32189); Fri, 20 Jul 2018 13:50:02 +0000 Original-Received: (at 32189) by debbugs.gnu.org; 20 Jul 2018 13:49:55 +0000 Original-Received: from localhost ([127.0.0.1]:48992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgVn8-0002R8-WA for submit@debbugs.gnu.org; Fri, 20 Jul 2018 09:49:55 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:53587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgVn7-0002Qw-MD for 32189@debbugs.gnu.org; Fri, 20 Jul 2018 09:49:54 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6KDndLL012041; Fri, 20 Jul 2018 09:49:40 -0400 Original-Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6KDncLE010615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 20 Jul 2018 09:49:39 -0400 In-Reply-To: <83y3e61jl2.fsf@gnu.org> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148727 Archived-At: On 7/20/2018 2:56 AM, Eli Zaretskii wrote: >> From: Paul Eggert >> Date: Thu, 19 Jul 2018 16:19:38 -0700 >> Second, the code in question uses snprintf followed by build_string, and can be >> simplified by using vformat_string instead. That would avoid the warnings and >> should make the code more reliable. Something like the attached patch, say. I >> haven't tested it since I don't use MS-Windows. Let's use something like this >> rather than shutting off the warnings. > > Works for me (although vformat_string does exactly what a call to > snprintf does, just with a larger buffer). Ken, could you please > check if this works in the Cygwin build? Yes, although I'm getting the following warning after this change: ../../master/src/w32cygwinx.c: In function ‘format_string’: ../../master/src/w32cygwinx.c:32:3: warning: function ‘format_string’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Lisp_Object str = vformat_string (format, args); ^~~~~~~~~~~ Ken