From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Charl P. Botha" Newsgroups: gmane.emacs.bugs Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Date: Wed, 21 Dec 2022 12:15:47 +0200 Message-ID: References: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Cc: 59945@debbugs.gnu.org To: "Yuan Fu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 21 11:17:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7wAF-0002gq-9i for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Dec 2022 11:17:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7w9w-0000tT-KT; Wed, 21 Dec 2022 05:17:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7w9m-0000n2-BH for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 05:17:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7w9m-0000GI-18 for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 05:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7w9l-000554-Sj for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 05:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Charl P. Botha" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2022 10:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59945-submit@debbugs.gnu.org id=B59945.167161778019504 (code B ref 59945); Wed, 21 Dec 2022 10:17:01 +0000 Original-Received: (at 59945) by debbugs.gnu.org; 21 Dec 2022 10:16:20 +0000 Original-Received: from localhost ([127.0.0.1]:50980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7w95-00054W-MW for submit@debbugs.gnu.org; Wed, 21 Dec 2022 05:16:19 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:55497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7w90-00053y-Nz for 59945@debbugs.gnu.org; Wed, 21 Dec 2022 05:16:17 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A02F732005BC; Wed, 21 Dec 2022 05:16:08 -0500 (EST) Original-Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Wed, 21 Dec 2022 05:16:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1671617768; x= 1671704168; bh=nrMxYTpWVbTa1I0CB9JntWiEL9zo4aHmrb6SiHCFKy0=; b=J tCDB+fxm8M8ORX0mC5NoXHFxsEe+QFBpAYiYftXNcAXmL/8keE0l382wIXJa0QQd EbSyln6nxmrCZ7w1Xdvu6x80ziX1u5gnH5ByrdV4m2DfjzKExIUOhKJYYVxcyIiX zy3cqfl6bhDnvlroRZfv8YriSUJg60MsyUbn7HjtQR6HGlAEfyeCpYFgkwhampB7 +dvQVIzRVsOKxR5KIPpyqD6xHQW9dqA/0IHw6KLHFc6KSRk2qyu6f/GrWNASfEln nEoKeVFkR7C5Bm51g3qOB7HXObubo6i7bnCyBR/Tk/HAkt98jXV08tzm4Pgr0y7z nMvdxH+EDikc+2i+UbTzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671617768; x= 1671704168; bh=nrMxYTpWVbTa1I0CB9JntWiEL9zo4aHmrb6SiHCFKy0=; b=b E2wHiIf1c+deLImWbq7o6lDWdOugLiXS3FUwcIetbzk1ZO4lAzlSInJeXzXMDMTp FG8QZ7555UUI2gCqIbQ5dmSEIfk85dFsTeLK87B/N9Molb241Lch4D9T8IsWQkwb u+TdU37dGshUKY7s0hspI/CgppmN/oCDN/AztaOVJoZy+oLzryDf4KzBuZ0OXb0j BeTAwALaj2K4OrS4bTtDdtVcAyObEn5NqvbrfPuCDerbc5k5ql/1sdxd1KYQX9va 813SglTFVHDzsnRpKeY2lr+yIMfFMjMi1M4c/8Q7Oie8Zg+34YZ6hi9JyLX8d/XK OjK8sjhrp1yApiUSnVjjQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeekgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtgfesth hqredtreerjeenucfhrhhomhepfdevhhgrrhhlucfrrdcuuehothhhrgdfuceotghpsgho thhhrgesvhiglhgrsghsrdgtohhmqeenucggtffrrghtthgvrhhnpedugeeiieehieeftd evteeijefhfeekvefghedtveeitdeuheevueehuefgvdejieenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggssh drtghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 13C4936A0073; Wed, 21 Dec 2022 05:16:07 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251584 Archived-At: Dear Yuan, On Wed, Dec 21, 2022, at 06:48, Yuan Fu wrote: > Thanks! I applied your patch. I made a little change to it so it=E2=80= =99s more > idiomatic. > > Elisp tip of the day: if you want to make a list of possibly nil objec= ts > and don=E2=80=99t want nil=E2=80=99s in the list, you can use append. = Basically change > > (list a b c) > > to > > (append (and xxx (list a)) (and yyy (list b)) (and zzz (list c))) > > If the condition aren=E2=80=99t met, eg, (and xxx (list a)) returns ni= l, append > just appends an empty list. Thank you very much for taking care of this, and thank you for your emac= s-lisp improvement and tip. On that day, I searched for but was not able= to find a better formulation than my klunky one. Kind regards, Charl