From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29321: Isearch hit count Date: Sat, 27 Oct 2018 15:25:30 -0700 (PDT) Message-ID: References: <87o9bfqfc3.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540679050 14012 195.159.176.226 (27 Oct 2018 22:24:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2018 22:24:10 +0000 (UTC) Cc: 29321@debbugs.gnu.org To: Juri Linkov , charles@aurox.ch Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 28 00:24:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGX01-0003Wq-H0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 00:24:05 +0200 Original-Received: from localhost ([::1]:38018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGX28-0002Zr-1r for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Oct 2018 18:26:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGX20-0002Zk-Vn for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 18:26:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGX1w-0006Xy-JJ for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 18:26:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGX1u-0006XK-E2 for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 18:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGX1t-0000yj-Rr for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 18:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Oct 2018 22:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29321 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29321-submit@debbugs.gnu.org id=B29321.15406791503744 (code B ref 29321); Sat, 27 Oct 2018 22:26:01 +0000 Original-Received: (at 29321) by debbugs.gnu.org; 27 Oct 2018 22:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:46022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGX1h-0000yK-Qy for submit@debbugs.gnu.org; Sat, 27 Oct 2018 18:25:50 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:39280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGX1e-0000y6-Lx for 29321@debbugs.gnu.org; Sat, 27 Oct 2018 18:25:47 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9RMPXRn150084; Sat, 27 Oct 2018 22:25:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ZgWxfzHFuGiFTAcNPg3XcXY5/YvJ2kzYMW6764w1MzY=; b=tdOgrQSSe2pEy/ZiLEMLI3nY9umBMbHN55INAVY+oYT0Vtb0O1T0N7soX8I7chzwk+CX cw31kP/IlGlTbVkq3bxuacli8pcMo4AW+dofKqNaELo3J2yGLFSPzvdUCnA2+LcAPddF hCwBv1gSiqq78SYKZU0suw3eyL21Qdk6qYnUtd7jnbXE2J+a7keLbx5UVliEp69q0YDN vQOaqmmXzNp6Mcfdk4gkpWBg2g7W2J9OANOOoUq85vO0IkMRb02PX2o98xjb3/onLpxV daI8EeRxOTYtctAYXAKzxbsBZVCEjyckqeoy3pRuGEyIgj3SntdWS25z4mijEPghcgLN fw== Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2ncfet9a57-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Oct 2018 22:25:33 +0000 Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9RMPVuK020464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Oct 2018 22:25:32 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9RMPVhd011540; Sat, 27 Oct 2018 22:25:31 GMT In-Reply-To: <87o9bfqfc3.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4756.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9059 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=629 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810270205 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151722 Archived-At: > > Isearch could show in the mode line how many matches follow or precede > > the currently highlighted one (or we could write "3 of 4 matches", as, > > e.g., Firefox does). For big files, it could be helpful to calculate > > this information either lazily or in another thread. 1. The doc for `isearch-lazy-count' says this: Counts matches in the full buffer. When non-nil, all matches in the full buffer are counted. The user-visible difference is the indication in the Isearch prompt of the current match number and the total number. The current doc makes it sounds like it maybe counts matches other than for the full buffer when nil, or that this depends in some way on `isearch-lazy-highlight-buffer'. And it doesn't say what is done with the count. Suggested doc (or similar): Show match number in the Isearch prompt. Non-nil means show CURRENT/TOTAL, where CURRENT is the current match number and TOTAL is the number of matches in the buffer (or its restriction). 2. If I set `isearch-lazy-highlight' to nil after using search with it as t, the last lazy count indication remains present, even though the count does not get updated. 3. Since (presumably) this counting feature is available only when `isearch-lazy-highlight' is non-nil, which justifies the use of "lazy" in the option value, this fact should be mentioned in the doc. Suggested doc (or similar): Show match number in the Isearch prompt. When both this option and `isearch-lazy-highlight' are non-nil, show CURRENT/TOTAL, where CURRENT is the current match number and TOTAL is the total number of matches in the buffer (or its restriction). 4. Maybe the option should be called `isearch-show-match-number', but `isearch-lazy-count' sounds better, and it hints that it depends on `isearch-lazy-highlight'.