From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57787: 29.0.50; [PATCH] When using $VAL[INDEX] in Eshell, allow symbols as the index Date: Tue, 13 Sep 2022 16:23:26 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2FBF0D2572B72479BE0DF3F2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39437"; mail-complaints-to="usenet@ciao.gmane.io" To: 57787@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 01:24:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYFGP-000A93-NF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 01:24:21 +0200 Original-Received: from localhost ([::1]:42976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYFGO-0000hh-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 19:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37088) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYFGA-0000hY-Km for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 19:24:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYFG6-00031A-TS for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 19:24:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYFG6-0006HN-CK for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 19:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166311141724097 (code B ref -1); Tue, 13 Sep 2022 23:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Sep 2022 23:23:37 +0000 Original-Received: from localhost ([127.0.0.1]:53126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYFFg-0006Ga-WA for submit@debbugs.gnu.org; Tue, 13 Sep 2022 19:23:37 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:52552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYFFc-0006GP-8p for submit@debbugs.gnu.org; Tue, 13 Sep 2022 19:23:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYFFc-0000gc-3h for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 19:23:32 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:34568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYFFa-0002zm-1K for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 19:23:31 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id e68so13194979pfe.1 for ; Tue, 13 Sep 2022 16:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from:from :to:cc:subject:date; bh=aFZuiqUGC98KpjSpq/RFKg44GTSHZCuVFVCbOd5tL9U=; b=Rmtm8QY3Wuu9dA1IAS931/I2FPZqjNpgHmPEWCDOVOdA8UUhw0j2ZfNd0LpVd6ZNrE pDAUSMtgYOuw/u5JkzOiXT2l83eeogFKRV2Rnz+A++BxmDeBMGW7g8E/fAUF7jbYUAd2 GKsOllPqE4DONxWEYLledPWwvhPrKEqDhvyvz31IwSJBkJjmYIw1GrPKgJZ7rmUF6+qD s+k2mqeNhSPAZVzuD9VSRanc6/QGEr2mvT48xrIBRLfy0hnCeZGCF318monbitBd/jDt /wYh8EHOoRXPbg1FQULp7k07FzsleBjFm92aHDKYC3Q0CwVxVsEF5KjddChB2viY+Dry wM0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from :x-gm-message-state:from:to:cc:subject:date; bh=aFZuiqUGC98KpjSpq/RFKg44GTSHZCuVFVCbOd5tL9U=; b=h/4fjM80dg0E/pYgKWn/IyfgkfG5/HsS9ERo/zLtexI38pweqdhJ49jyiT80ZSKWF9 iMXCX7gQ0xLsk1EoK/M+WwK6T1kBi1MpSj/QdtRoKLlHhVRJAT4EhQobYyg4X7yiLYjq toudRn8syNrEZJHVT2UCcMzO+D8TcM30yKS5LkceHz6uZEKAEKXq3b4uqWB91CF8J5bP 8FKuj7OPYLaae5rW+18iDx4KrBKyvIEuj+hD7xAJiNe7jnAoJcidZccQsN6DggAx24rI WmcJpRdDQrzZszQZqqsU3aFIZrSoiTAwFNAk8wt8gN3sRf+K/InK5ms6aA/41wMqwFXy JOyw== X-Gm-Message-State: ACgBeo3DSzGybnHDlvhCfTiLTFcFCgCXrSzBnuCEwwBFUEwez0V8qazL haV8FlyVDk+nzoewPeHO88ljh6Tziwk= X-Google-Smtp-Source: AA6agR4ApkstG0b/lIQHIIutmdZmPbW5fENhwGbbhzo6gSmF78sQ6dkxphFmZCLvZfj72KT7rBKDmw== X-Received: by 2002:a63:1864:0:b0:439:4c72:429a with SMTP id 36-20020a631864000000b004394c72429amr3434881pgy.35.1663111407917; Tue, 13 Sep 2022 16:23:27 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ij9-20020a170902ab4900b0016ee4b0bd60sm9015950plb.166.2022.09.13.16.23.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 16:23:27 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242418 Archived-At: This is a multi-part message in MIME format. --------------2FBF0D2572B72479BE0DF3F2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eshell variable expansions let you use strings as indices, which will treat the outer value as an alist. For example: (setq foo '(("a" . 1) ("b" . 2))) M-x eshell ~ $ echo $foo[a] 1 However, if the keys in the alist are symbols, that doesn't work: (setq foo '((a . 1) (b . 2))) M-x eshell ~ $ echo $foo[a] ;; no output Attached is a patch to fix this. Now, in the latter case, you'd type: ~ $ echo $foo[#'a] ;; or ~ $ echo $foo[`a] (Note: "#'a" looks like a sharp quote to denote a function, but the # is just Eshell's way of escaping the following single-quote. A bare single-quote is the start of a string literal in Eshell.) --------------2FBF0D2572B72479BE0DF3F2 Content-Type: text/plain; charset=UTF-8; name="0001-Allow-using-a-symbol-as-an-index-into-an-alist-in-Es.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Allow-using-a-symbol-as-an-index-into-an-alist-in-Es.pa"; filename*1="tch" RnJvbSAwYzYwNzE4NjgxNTY4ZjU1MTJhNjM5ZGU4MGI5OWRhZjk1ZjFmYjlkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMTMgU2VwIDIwMjIgMTY6MTQ6MDAgLTA3MDAKU3ViamVjdDogW1BB VENIXSBBbGxvdyB1c2luZyBhIHN5bWJvbCBhcyBhbiBpbmRleCBpbnRvIGFuIGFsaXN0IGlu IEVzaGVsbAoKKiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIChlc2hlbGwtaW5kZXgtdmFsdWUp OiBJZiBJTkRFWCBpcyBhIHN5bWJvbCwKdXNlICdhc3NvYycgZm9yIGluZGV4aW5nLgoqIHRl c3QvbGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbCAoZXNoLXZhci10ZXN0L2ludGVycC12 YXItYXNzb2MpCihlc2gtdmFyLXRlc3QvcXVvdGVkLWludGVycC12YXItYXNzb2MpOiBBZGQg Y2hlY2tzIGZvciBpbmRleGluZyB2aWEKc3ltYm9sLgotLS0KIGxpc3AvZXNoZWxsL2VzaC12 YXIuZWwgICAgICAgICAgICB8IDM1ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0K IHRlc3QvbGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbCB8IDEyICsrKysrKystLS0tCiAy IGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwgYi9saXNwL2VzaGVsbC9lc2gtdmFy LmVsCmluZGV4IGE5ZGYxNzJlODguLjM2ZTU5Y2Q1YTQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNo ZWxsL2VzaC12YXIuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApAQCAtNjQ2LDIz ICs2NDYsMjQgQEAgZXNoZWxsLWluZGV4LXZhbHVlCiAgICJSZWZlcmVuY2UgVkFMVUUgdXNp bmcgdGhlIGdpdmVuIElOREVYLiIKICAgKHdoZW4gKGFuZCAoc3RyaW5ncCBpbmRleCkgKGdl dC10ZXh0LXByb3BlcnR5IDAgJ251bWJlciBpbmRleCkpCiAgICAgKHNldHEgaW5kZXggKHN0 cmluZy10by1udW1iZXIgaW5kZXgpKSkKLSAgKGlmIChzdHJpbmdwIGluZGV4KQotICAgICAg KGNkciAoYXNzb2MgaW5kZXggdmFsdWUpKQotICAgIChjb25kCi0gICAgICgocmluZy1wIHZh bHVlKQotICAgICAgKGlmICg+IGluZGV4IChyaW5nLWxlbmd0aCB2YWx1ZSkpCi0JICAoZXJy b3IgIkluZGV4IGV4Y2VlZHMgbGVuZ3RoIG9mIHJpbmciKQotCShyaW5nLXJlZiB2YWx1ZSBp bmRleCkpKQotICAgICAoKGxpc3RwIHZhbHVlKQotICAgICAgKGlmICg+IGluZGV4IChsZW5n dGggdmFsdWUpKQotCSAgKGVycm9yICJJbmRleCBleGNlZWRzIGxlbmd0aCBvZiBsaXN0IikK LQkobnRoIGluZGV4IHZhbHVlKSkpCi0gICAgICgodmVjdG9ycCB2YWx1ZSkKLSAgICAgIChp ZiAoPiBpbmRleCAobGVuZ3RoIHZhbHVlKSkKLQkgIChlcnJvciAiSW5kZXggZXhjZWVkcyBs ZW5ndGggb2YgdmVjdG9yIikKLQkoYXJlZiB2YWx1ZSBpbmRleCkpKQotICAgICAodAotICAg ICAgKGVycm9yICJJbnZhbGlkIGRhdGEgdHlwZSBmb3IgaW5kZXhpbmciKSkpKSkKKyAgKGlm IChpbnRlZ2VycCBpbmRleCkKKyAgICAgIChjb25kCisgICAgICAgKChyaW5nLXAgdmFsdWUp CisgICAgICAgIChpZiAoPiBpbmRleCAocmluZy1sZW5ndGggdmFsdWUpKQorICAgICAgICAg ICAgKGVycm9yICJJbmRleCBleGNlZWRzIGxlbmd0aCBvZiByaW5nIikKKyAgICAgICAgICAo cmluZy1yZWYgdmFsdWUgaW5kZXgpKSkKKyAgICAgICAoKGxpc3RwIHZhbHVlKQorICAgICAg ICAoaWYgKD4gaW5kZXggKGxlbmd0aCB2YWx1ZSkpCisgICAgICAgICAgICAoZXJyb3IgIklu ZGV4IGV4Y2VlZHMgbGVuZ3RoIG9mIGxpc3QiKQorICAgICAgICAgIChudGggaW5kZXggdmFs dWUpKSkKKyAgICAgICAoKHZlY3RvcnAgdmFsdWUpCisgICAgICAgIChpZiAoPiBpbmRleCAo bGVuZ3RoIHZhbHVlKSkKKyAgICAgICAgICAgIChlcnJvciAiSW5kZXggZXhjZWVkcyBsZW5n dGggb2YgdmVjdG9yIikKKyAgICAgICAgICAoYXJlZiB2YWx1ZSBpbmRleCkpKQorICAgICAg ICh0CisgICAgICAgIChlcnJvciAiSW52YWxpZCBkYXRhIHR5cGUgZm9yIGluZGV4aW5nIikp KQorICAgIDs7IElOREVYIGlzIHNvbWUgbm9uLWludGVnZXIgdmFsdWUsIHNvIHRyZWF0IFZB TFVFIGFzIGFuIGFsaXN0LgorICAgIChjZHIgKGFzc29jIGluZGV4IHZhbHVlKSkpKQogCiA7 OztfKiBWYXJpYWJsZSBuYW1lIGNvbXBsZXRpb24KIApkaWZmIC0tZ2l0IGEvdGVzdC9saXNw L2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRl c3RzLmVsCmluZGV4IGJlYmM1N2QzNTkuLmNiNWIxNzY2YmIgMTAwNjQ0Ci0tLSBhL3Rlc3Qv bGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2Vz aC12YXItdGVzdHMuZWwKQEAgLTEwNSw5ICsxMDUsMTEgQEAgZXNoLXZhci10ZXN0L2ludGVy cC12YXItcmVnZXhwLXNwbGl0LWluZGljZXMKIAogKGVydC1kZWZ0ZXN0IGVzaC12YXItdGVz dC9pbnRlcnAtdmFyLWFzc29jICgpCiAgICJJbnRlcnBvbGF0ZSBhbGlzdCB2YXJpYWJsZSB3 aXRoIGluZGV4IgotICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygoImZvbyIgLiAxKSkp KQorICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygoImZvbyIgLiAxKSAoYmFyIC4gMikp KSkKICAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsICJlY2hvICRlc2hlbGwtdGVz dC12YWx1ZVtmb29dIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMSkpKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMSkKKyAgICAoZXNoZWxsLWNvbW1h bmQtcmVzdWx0LWVxdWFsICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZVsjJ2Jhcl0iCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAyKSkpCiAKIChlcnQtZGVmdGVzdCBlc2gt dmFyLXRlc3QvaW50ZXJwLXZhci1sZW5ndGgtbGlzdCAoKQogICAiSW50ZXJwb2xhdGUgbGVu Z3RoIG9mIGxpc3QgdmFyaWFibGUiCkBAIC0yNTcsOSArMjU5LDExIEBAIGVzaC12YXItdGVz dC9xdW90ZWQtaW50ZXJwLXZhci1yZWdleHAtc3BsaXQtaW5kaWNlcwogCiAoZXJ0LWRlZnRl c3QgZXNoLXZhci10ZXN0L3F1b3RlZC1pbnRlcnAtdmFyLWFzc29jICgpCiAgICJJbnRlcnBv bGF0ZSBhbGlzdCB2YXJpYWJsZSB3aXRoIGluZGV4IGluc2lkZSBkb3VibGUtcXVvdGVzIgot ICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygoImZvbyIgLiAxKSkpKQorICAobGV0ICgo ZXNoZWxsLXRlc3QtdmFsdWUgJygoImZvbyIgLiAxKSAoYmFyIC4gMikpKSkKICAgICAoZXNo ZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsICJlY2hvIFwiJGVzaGVsbC10ZXN0LXZhbHVlW2Zv b11cIiIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIxIikpKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIjEiKQorICAgIChlc2hlbGwtY29tbWFuZC1y ZXN1bHQtZXF1YWwgImVjaG8gXCIkZXNoZWxsLXRlc3QtdmFsdWVbIydiYXJdXCIiCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiMiIpKSkKIAogKGVydC1kZWZ0ZXN0IGVz aC12YXItdGVzdC9xdW90ZWQtaW50ZXJwLXZhci1sZW5ndGgtbGlzdCAoKQogICAiSW50ZXJw b2xhdGUgbGVuZ3RoIG9mIGxpc3QgdmFyaWFibGUgaW5zaWRlIGRvdWJsZS1xdW90ZXMiCi0t IAoyLjI1LjEKCg== --------------2FBF0D2572B72479BE0DF3F2--