From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Sat, 5 Sep 2020 12:10:59 -0400 Message-ID: References: <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <83eengpgdn.fsf@gnu.org> <83d030pfrf.fsf@gnu.org> <5bd82b3a-0108-5dd4-88dd-e3def6b77e01@cornell.edu> <835z8sp5pi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25209"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: larsi@gnus.org, dmoncayo@gmail.com, 25542@debbugs.gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 18:12:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEanT-0006QL-Qx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 18:12:11 +0200 Original-Received: from localhost ([::1]:36300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEanS-0008IM-Qq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 12:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEanK-0008IF-Vv for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEanK-0000nl-MS for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEanK-0005c8-He for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159932226821515 (code B ref 25542); Sat, 05 Sep 2020 16:12:02 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 5 Sep 2020 16:11:08 +0000 Original-Received: from localhost ([127.0.0.1]:43951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEamS-0005ax-92 for submit@debbugs.gnu.org; Sat, 05 Sep 2020 12:11:08 -0400 Original-Received: from mail-dm6nam12on2103.outbound.protection.outlook.com ([40.107.243.103]:2305 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEamQ-0005aT-NR for 25542@debbugs.gnu.org; Sat, 05 Sep 2020 12:11:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YySUWhPCIzExIqmYR9SdVYJEiLsjCPlJXXwkmjjtpsSF8ucPBdYeFB2CMYw/7fdqFIL2jh0aT7MlflXgCjKdCiDDstkMLwo3h6PeXeP7tiLE+gZZrrLmEfOtAS9q0amOCblN8tt8ku06n/IQr3K7rdcdm9HjxcfQGcpiSxCwNVOCVERlNleMijZwl6RIxPP+bFrrmL9FphGxKXbim/0UFr0ZHeOjddnqzPu1M6ErcrX2v/g0MCRKRqcPi6SYi3EmodfEj0Z9IKuV92jA4Y8flxbrBPwS/OCmR+iPcAkgorGnbQdyt9v5K/BXjfo7bbdqfOBR6NcgtSQHyyv9VAjN6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjGpfYXY3RdcTxUqE8G8jrmyWJHnfTMXI8fCNMSC+rM=; b=oPGuSxPvEpEPfbjPNdu/tocFgeXIJ7r/ztVQF4kDe3uI1gHjMLGNAFgiDBu3zhfPaJ5aLXRCFOFPGvcQNYQfPHJfAStRlIr4Qobj8tqjbPGhqv/erkJA3bRwTpLVEIkj+AUTdpG31HgpuVMxmczyYK5l5dc4w6hkmiPHPvhVL6q2UpqCDwT8U13T+rxlCw8b2Namb0+EXq/7ykVYrnd6+1tWvKIhPtNoMtPdMWKDsDetVkcLstJwnTciZg0hmCYkpTxRZ8f26NPYlUeusxVHJEhfSNiRee6EKIba0qmZJS5P4m164pvtS1yrQI4VepgMCAektvSdNxiNMplksIphKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjGpfYXY3RdcTxUqE8G8jrmyWJHnfTMXI8fCNMSC+rM=; b=dnTgIHBfCWDA+RLR4/hVnlSpQDKVGdI3hn+kuF+qcOd0V69ArTRssAWwPcq16dQe+/5kJKhOghr9C8WLb7Fiuj973MXIByaro4as4hCUk4IhlAvM1cXeEH7e6b3rcmb8HN2mwmwXC674iRDXyHtWUuZWXIL0tMbFhM/aTsuRWZQ= Authentication-Results: gmx.at; dkim=none (message not signed) header.d=none;gmx.at; dmarc=none action=none header.from=cornell.edu; Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5647.namprd04.prod.outlook.com (2603:10b6:208:3f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Sat, 5 Sep 2020 16:11:00 +0000 Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44%7]) with mapi id 15.20.3348.017; Sat, 5 Sep 2020 16:11:00 +0000 In-Reply-To: <835z8sp5pi.fsf@gnu.org> Content-Language: en-US X-ClientProxiedBy: CH2PR04CA0022.namprd04.prod.outlook.com (2603:10b6:610:52::32) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [IPv6:2604:6000:b407:7f00:6c3f:b207:591d:92fb] (2604:6000:b407:7f00:6c3f:b207:591d:92fb) by CH2PR04CA0022.namprd04.prod.outlook.com (2603:10b6:610:52::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15 via Frontend Transport; Sat, 5 Sep 2020 16:10:59 +0000 X-Originating-IP: [2604:6000:b407:7f00:6c3f:b207:591d:92fb] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00938533-a2b3-4a76-9d4d-08d851b647b0 X-MS-TrafficTypeDiagnostic: MN2PR04MB5647: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7dZ+NVDVh/KbI79LhvzNh3cKVOxwDGkeH/GXssRSRLJVhGjDUQPKF0YuZA07LO0scH69UaWqKVa588c82+vikBLRwlJgbigwdN5HoH6qUNvaoAjb4Jn5mrDFVXb0aExvDC1GiYUvTrZFOn+Iq7N7eByhXgs3vN/PoHmrUxJykkokbMAeckGkk9kKMY98mPzYHNPIrXj2pCrk8Lc/3NE3aYduTC7SUF4ltmbPU0dmOCdnZpokYZKokrnJ3naB9cyz56ar1zWzJqrNy6u2k+A7XaCRV2bTL7nR5un+URnOmF+9AEGUCkFrQj3LsGeA9pHJ6D4oiMykZYKq8ehGdItWNZmaCf2TKNI4YgomyB2SkVB7P0FFjwMiq4EwWinjqBI4A5/HMiTluhxa3j2dWG0CAA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(86362001)(186003)(16526019)(4326008)(83380400001)(66556008)(66476007)(5660300002)(31686004)(66946007)(8676002)(52116002)(8936002)(6486002)(478600001)(2906002)(75432002)(316002)(786003)(2616005)(6916009)(31696002)(53546011)(36756003)(14963001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: K/RJxv1AJU9j6h12EAU81BBwwcV7WRk13w5Ri6lMkTMx28A5rfXyViPYw2qgMf/QyEVu3leRsgm9yH0bWGmzR8lqpyWEEnB6eVvzZa3P+yN7sjMQI9Ubslvu279qfTK/o3CIRHUCwKznZOwuAWmRAUj9SZ9JUMLv+cXAXouX6QQ6qfwSmKVF7q+HBp2H8aCVJGMGPp4aAQ9zwPYtj5AZuk1tqFNzJLlSjcdaDdyoKL6kWq6OWceATGrabS3mbJ9dK1OGw0BDQsDZYvyio1sXYCsfE0ZVYogr0TSIYbZSR/U1LoFnKz6C5CNSxa8mMs5R0AAAUAOavl6GaSsT+gmIgGEzOAWYyzxS+mG0Ll7Y7tmqLjObs0s2c+xX+jQidjozLg3hj1108IZTajcCy6P+pW9l0D1opXSwBjm4QgdEZTOOJ9K9PITFq/dOYY8bK4ft54O4vIYNx0/rx6/CiXFuJLadCS2/U+OwuBYFrOT8kM/qh/weliTNjkfG22WDveEluhKrYXGFaXFDrwyi74LwWRy5awBq1thE2GCb9Pz7J9/iNVhdippDhVbJQQcJESwEy0Ug+zokknwyVTyRXR6kl52DQ4Xh4M1i/7NzdPXpGz/4G+4IuULVdo3hNUeYJjerbwq+Q3jzWImB3doobJmljpdZGVnnzAlagSfAOPXMa4mvFnF79LSfhxcC5tOJE5EfrqunLkj6xZYQxmMlyVwqng== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 00938533-a2b3-4a76-9d4d-08d851b647b0 X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2020 16:11:00.3278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z++LgdeRg+hrwN4Cqbu2tg8oVm7GlsZ65HFYyy7fn9UjHztiRbLQOl61wKC3l3+Hysv/zkHNcwSgcQPJV/p8yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5647 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187276 Archived-At: On 9/5/2020 12:07 PM, Eli Zaretskii wrote: >> Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, >> Noam Postavsky , >> martin rudalics >> From: Ken Brown >> Date: Sat, 5 Sep 2020 11:10:31 -0400 >> >> diff --git a/src/w32term.c b/src/w32term.c >> index 76cf6bd696..c7da95528b 100644 >> --- a/src/w32term.c >> +++ b/src/w32term.c >> @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal, >> simple hack to check that based on the fact that >> only a maximized fullscreen frame should have both >> top/left outside the screen. */ >> - if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight) >> - || NILP (fullscreen)) >> - { >> - int x, y; >> - >> - w32_real_positions (f, &x, &y); >> - if (x < 0 && y < 0) >> - store_frame_param (f, Qfullscreen, Qmaximized); >> - } >> + store_frame_param (f, Qfullscreen, Qmaximized); >> } >> >> break; >> >> If I make this change and follow Dani's recipe from the original bug report, the >> second F11 press doesn't restore the previous state. Instead, the frame appears >> to get slightly smaller for an instant and then immediately reverts to >> fullscreen mode. > > Thanks for testing. It sounds like the proposed change leaves the > original incorrect behavior unchanged, so we need to look for some > different way of fixing this. It's not unchanged, it's just wrong in a different way. Previously the second F11 resulted in an unmaximized frame. Ken