unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 29957-done@debbugs.gnu.org
Subject: bug#29957: 27.0.50; xgettype (and friends) don't know about Lisp_Word
Date: Tue, 2 Jan 2018 22:40:41 -0800	[thread overview]
Message-ID: <f277758f-219e-39f1-82ea-1d95e7d28f86@cs.ucla.edu> (raw)
In-Reply-To: <jwvwp0zy3lc.fsf@iro.umontreal.ca>

[-- Attachment #1: Type: text/plain, Size: 53 bytes --]

Thanks for reporting that; I installed the attached.

[-- Attachment #2: 0001-Fix-.gdbinit-to-work-with-Lisp_Word.patch --]
[-- Type: text/x-patch, Size: 1323 bytes --]

From f8b4e87d5d4f57954b50677add76ce5136211dc1 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 2 Jan 2018 22:38:01 -0800
Subject: [PATCH] Fix .gdbinit to work with Lisp_Word

Problem reported by Stefan Monnier (Bug#29957).
* src/.gdbinit (xgetptr, xgetint, xgettype):
Cast Lisp_Word value to EMACS_INT, since it might be a pointer now.
---
 src/.gdbinit | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/.gdbinit b/src/.gdbinit
index de35ef1..a5411e6 100644
--- a/src/.gdbinit
+++ b/src/.gdbinit
@@ -49,7 +49,7 @@ define xgetptr
   else
     set $bugfix = $arg0
   end
-  set $ptr = $bugfix & VALMASK
+  set $ptr = (EMACS_INT) $bugfix & VALMASK
 end
 
 define xgetint
@@ -58,7 +58,7 @@ define xgetint
   else
     set $bugfix = $arg0
   end
-  set $int = $bugfix << (USE_LSB_TAG ? 0 : INTTYPEBITS) >> INTTYPEBITS
+  set $int = (EMACS_INT) $bugfix << (USE_LSB_TAG ? 0 : INTTYPEBITS) >> INTTYPEBITS
 end
 
 define xgettype
@@ -67,7 +67,7 @@ define xgettype
   else
     set $bugfix = $arg0
   end
-  set $type = (enum Lisp_Type) (USE_LSB_TAG ? $bugfix & (1 << GCTYPEBITS) - 1 : (EMACS_UINT) $bugfix >> VALBITS)
+  set $type = (enum Lisp_Type) (USE_LSB_TAG ? (EMACS_INT) $bugfix & (1 << GCTYPEBITS) - 1 : (EMACS_UINT) $bugfix >> VALBITS)
 end
 
 define xgetsym
-- 
2.7.4


      reply	other threads:[~2018-01-03  6:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03  4:21 bug#29957: 27.0.50; xgettype (and friends) don't know about Lisp_Word Stefan Monnier
2018-01-03  6:40 ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f277758f-219e-39f1-82ea-1d95e7d28f86@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=29957-done@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).