From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Wed, 30 Sep 2020 14:28:27 -0700 (PDT) Message-ID: References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20593"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , 43702@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 23:29:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNjfD-0005HM-If for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 23:29:27 +0200 Original-Received: from localhost ([::1]:57712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNjfC-0005tg-LG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 17:29:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNjep-0005nG-Mf for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 17:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNjen-0002x4-Uo for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 17:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNjen-0008NX-R5 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 17:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.160150132532182 (code B ref 43702); Wed, 30 Sep 2020 21:29:01 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 30 Sep 2020 21:28:45 +0000 Original-Received: from localhost ([127.0.0.1]:33312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNjeX-0008N0-BF for submit@debbugs.gnu.org; Wed, 30 Sep 2020 17:28:45 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNjeS-0008Mk-OF for 43702@debbugs.gnu.org; Wed, 30 Sep 2020 17:28:44 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UL9BxA130276; Wed, 30 Sep 2020 21:28:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Mm2XgXnQ9x8XSLc1s+j3me+tB+JRfaNQH2Hsq+Z19o4=; b=uUlLO1TPJ3SbQuqdj2PWO4Pgjhip1oqYiqIp2jiLghT0VdTRF/BYnAZBLFYlDSdFo1aP jSoOsZ2OE3439ZdwNrQcr7RUAr0uV/ifPRSNWZlYoeh/XSoctRHfGMnK1g4Q2npFtuik AB0SJQBas9lPBV8mZQA4qvrVvceQ5Wxpf8g/jWO61ytve8ln5Dgae024Tb10MLv2eVWv ZpoyvhWwVdmqCNceFgeTH1FsXc0Uj7WBSXOEkNo/31hN8AgbD8pyP/DdPBaqccsTDsH5 vlXmFnI0dlJ9rrCJ97F7Hfujr1xyBYb7+KGhrFCaNvXJm+YqMKOH8NPW3OqGfRgnKoG7 XA== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 33sx9natne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Sep 2020 21:28:34 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08ULOnXu073877; Wed, 30 Sep 2020 21:28:34 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 33tfdumw1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Sep 2020 21:28:34 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08ULSStU029768; Wed, 30 Sep 2020 21:28:28 GMT In-Reply-To: <87y2krdqsk.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9760 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300174 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9760 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300173 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189435 Archived-At: > Also I don't understand why users would need so many faces (9!) >=20 > Maybe better to do what Drew proposed: to distinguish the odd groups > from the even groups, i.e. to have only 2 additional faces > (a brighter face like the current isearch-group-1 for the odd groups, > and a darker face for the even groups). To be clear, I didn't propose that. My code has 8 levels (groups), with 8 faces. What I mentioned about even and odd is for lazy-highlighting. I use a different face, `isearchp-lazy-odd-regexp-groups', for odd subgroups - for lazy-highlighting only. (And that face is used, like the group highlighting for the current search hit, only when option `isearchp-highlight-regexp-group-levels-flag' is non-nil.) I provide 8 levels/groups for the current search hit. I agree that most regexp searches don't use anywhere near that many groups. But it costs nothing to provide for them. Here's a screenshot with 5 levels shown: https://www.emacswiki.org/emacs/Icicles_-_Search_Commands%2c_Overview#Searc= hHighlightingContextLevels (That's an Icicles-search screenshot, but the effect is the same. I added this regexp-group highlighting to Icicles nine years before I got around to adding it to Isearch+.)