From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16996: 24.3.50; [ruby-mode] Incorrect indentation for implicit hash arguments Date: Sat, 29 May 2021 21:25:22 +0300 Message-ID: References: <0CEC46C2A06B4B8DB6502F39A05D5E45@gmail.com> <87eh278mza.fsf@yandex.ru> <87zgwd7wd5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32022"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: 16996@debbugs.gnu.org, Bozhidar Batsov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 29 20:26:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ln3fF-0008BJ-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 20:26:25 +0200 Original-Received: from localhost ([::1]:35566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ln3fE-000805-71 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 14:26:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ln3es-0007zx-Db for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 14:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ln3es-0003hg-62 for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 14:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ln3es-0003aP-1E for bug-gnu-emacs@gnu.org; Sat, 29 May 2021 14:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2021 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16996 X-GNU-PR-Package: emacs Original-Received: via spool by 16996-submit@debbugs.gnu.org id=B16996.162231273113740 (code B ref 16996); Sat, 29 May 2021 18:26:01 +0000 Original-Received: (at 16996) by debbugs.gnu.org; 29 May 2021 18:25:31 +0000 Original-Received: from localhost ([127.0.0.1]:57709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ln3eN-0003ZY-Li for submit@debbugs.gnu.org; Sat, 29 May 2021 14:25:31 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:36821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ln3eM-0003ZM-VI for 16996@debbugs.gnu.org; Sat, 29 May 2021 14:25:31 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so6343443wmk.1 for <16996@debbugs.gnu.org>; Sat, 29 May 2021 11:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q0r1D8NT+E5/prrT8hA/D4yRhJbRZOwCzM0RNUWSfLU=; b=XuYoLRI4WVgltV/Q5noslj9bbYUZfg02evrutdYc/fPr9IsVEv0QJnAxhVu/cvlzB/ s7nDlhOzj4hvmXN947X0EphCSPK76jjMvPXCO61nFmr/munLCX2RUmikuG0+GDrDJtT/ +A25FZJRkxNLMPDU8oPok75SqzeXjky+rl9uvVTMU4kLEnCJjTwXlapo4+1+MIZrEAgq 1xIf/Aafy0HZwXAZglukJw+162N3wiZXkARM9AM8x0EfcH13QX0CimvBXTLHlBsSEyJv 9V8XHnn7I9eVNNxnE3prfxcNGZWVeA/k+ZM/sXtsLnBP0WwI1gmCDwfzP8fJDRWNe85+ evcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q0r1D8NT+E5/prrT8hA/D4yRhJbRZOwCzM0RNUWSfLU=; b=Zfggr6zXEKoX8E7gbiYyKAMw+k2lCEVAmveZ0sEuVhFClOGFEED+Ze7iG8MZ8iljrr ux2pwaw0D0dMA0UCqybhEBQrcJbT1rREjTFpBAFX5wql20Q+ls9tUgBHnlWTGDyWJkR+ W3Pq8O1j6fOME5NOKk4nQ1qwcMgTZfqTDAtfyP88FZiKjWM2rJDQCnkRItg1d/ztk+nI QqkRTjiBsDOt7Tdfa6bAc4y6IRbDpcHuCJHl+rEgvj3XMUJuHDmWtPNSemjbPr+XiesP Td5NNYY2T81QCUETTRp9Uu5rkIK5M5cb6uvJdHhclnzEHv6udTYpv6ooO9J0EU2vEu4o DoZA== X-Gm-Message-State: AOAM530x+pNaWLoBU9NalixG1tJdelrgIHBMUnfg6VblFKZjE/CTNMHP HItr3L9o6T+TuJ8y9XYldb2HETGpuKE= X-Google-Smtp-Source: ABdhPJxJW1AevL/+ddQTENZfPQp8sSJIFsAxrZu0GGK87gwJi1H+8+39OivwRJVeP2eF8HeKgLa9+A== X-Received: by 2002:a05:600c:1910:: with SMTP id j16mr13503983wmq.39.1622312724921; Sat, 29 May 2021 11:25:24 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v15sm17990984wmj.39.2021.05.29.11.25.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 May 2021 11:25:24 -0700 (PDT) In-Reply-To: <87zgwd7wd5.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207547 Archived-At: On 29.05.2021 11:55, Lars Ingebrigtsen wrote: > The current indentation in Ruby here seems pretty natural to me, so I'm > closing this bug report. We should probably reopen it. It's not very urgent (as the bug creation date will confirm), but I wanted to get around to this someday. Bozhidar, could you confirm it's still needed (or good to have)? I wanted to find some style guide or other solid description of this style, but haven't managed to. Ruby Style Guide strategically avoids this example, and https://www.rubydoc.info/gems/rubocop/0.83.0/RuboCop/Cop/Layout/HashAlignment and https://www.rubydoc.info/gems/rubocop/0.83.0/RuboCop/Cop/Layout/ArgumentAlignment do that too. Despite that, I actually have to deal with this implicit recommendation on a regular basis at work, because when both cops are enabled, Rubocop will frown on top(1, :a => 1, :b => 2 and top 1, a: 1, b: 2 I do remember style like top(1, :a => 1, :b => 2) being popular back in the day, but AFAICT a lot of editors now (like Atom and VS Code) don't support it either.