From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text Date: Sun, 8 Sep 2024 05:41:45 +0300 Message-ID: References: <83e5b9c4-0f5f-49c4-a4b2-fe553c59b2f6@gutov.dev> <86o75bftql.fsf@gnu.org> <119819e3-fc54-4f9a-9075-b07af637db12@gutov.dev> <864j71dw8e.fsf@gnu.org> <48e0fa23-623e-4a73-b968-ba10d766cf37@gutov.dev> <87y14bwvyd.fsf@gmail.com> <9a5884da-44cc-4f9a-9d4a-caf830617c7f@gutov.dev> <6805f597-20ab-4c97-b1bf-1b15856364e0@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19709"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , 72765@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 04:42:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sn7sZ-0004zr-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 04:42:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sn7sK-0007yI-UV; Sat, 07 Sep 2024 22:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sn7sI-0007y5-BS for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 22:42:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sn7sH-0006Pb-9W for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 22:42:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=BswxUyzdWgCSINnBDJ366Et/UhVt2pA7TPp9iSNlFFo=; b=eE5tm2yB9biuZbz7fA/Euud4lzc5kNb4EknAmt9GLw1eCkmei7QcYZGceg/ocm1M7fXv42J5nWtiMIHDo9h/roSzy5MYn1vuJsxZIO2aKty2gJD4Zj5pVpck7FNqruZwFh3zyi7xhzMh1HHiskAMN35oVbXlqZjHWVj1saO+397zOr3bZOu7Rg0DLoxIJD7wjHkNnOXSm3fLn90FrZDiZcVWd5F/sb/y8nlLnVc06pRpq4xF1U9xsJ4JL1qc8szr5Ic5fXCg8bwtcN4tnG/vqgDQP4X0x8kPV1bWmOQoGVfdvUGGZQfIyYxxiWIUTv1KRF6eQ4NJBdvQwQT8WYzDLA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sn7sI-0004o6-Eq for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 22:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 02:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72765 X-GNU-PR-Package: emacs Original-Received: via spool by 72765-submit@debbugs.gnu.org id=B72765.172576331918465 (code B ref 72765); Sun, 08 Sep 2024 02:42:02 +0000 Original-Received: (at 72765) by debbugs.gnu.org; 8 Sep 2024 02:41:59 +0000 Original-Received: from localhost ([127.0.0.1]:57828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sn7sF-0004nk-D6 for submit@debbugs.gnu.org; Sat, 07 Sep 2024 22:41:59 -0400 Original-Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:43729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sn7sD-0004nT-CZ for 72765@debbugs.gnu.org; Sat, 07 Sep 2024 22:41:58 -0400 Original-Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 68B5311400C5; Sat, 7 Sep 2024 22:41:49 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Sat, 07 Sep 2024 22:41:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1725763309; x=1725849709; bh=BswxUyzdWgCSINnBDJ366Et/UhVt2pA7TPp9iSNlFFo=; b= IGUNUqLlSBCggOqpBqHq/2+gi29w5GTHIVKC39jJFVgIKfhWt+jjxD0J/cAKD25t ahG4WFqL3fskkGYO+8QEcra/Rhta92nprhKglaBcUz5wmMNe7CnvPV2G80MlboIM UcSlNBbwRyDwXMbjkcO+kh7bHLIiIxuU/OpMH71lgbTzy+Be4fa00o0B/GpDtP6Y /EdZtVUEXs6vUlV1ZB3ksMESg1JeZJA+Xs1ByX2fPzpYLAbmdhruPVrNinERUv7J 2RIpikPj2Cp9kU2ItGfLj3HlGJ0QLMsdbbe+e5t1utY/V0wPTOzZUKVTo9vguiJM XL7cEJffBeTMgGES9v01Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725763309; x= 1725849709; bh=BswxUyzdWgCSINnBDJ366Et/UhVt2pA7TPp9iSNlFFo=; b=P lHZASn2YR3MgxLPmJpFdsd9ZWnv4wJzq/UlhlgJGBtCQGaNYqVMINE7kP+zwzGEW UkY5hSvtuVQ5/6sIyQOhv0KiccK7yVJZXdNaq6B7qZTMeRTnvQsIxGxfSc2fYWLE Hy+vwv8g2173Coxr54/h1hR0sFC0AUJfKnzgP39srnA8bG7syJ/3NS0ZqKzYHQqN iYGLRSDhIHqbvg4XDpUIFcsr5QlsnMkRmjzjr+osUl15yTnrtcNY38BieQESNTap QbWMs4AXkynzUSnWO98otKYhxnB/FqGomOI4qCRnpsOGBe6rlDu8GnCXNCginlKv CW8YRaL9q2Og/myjFXquw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeigedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveeg tedthefhudekteehffeukeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjohgrohhtrghvohhrrgesgh hmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthho peejvdejieehseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Sep 2024 22:41:47 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291418 Archived-At: On 03/09/2024 16:43, João Távora wrote: > On Tue, Sep 3, 2024 at 2:20 PM Dmitry Gutov wrote: >> On 01/09/2024 17:28, Dmitry Gutov wrote: >>>> * the rust-analyzer test you added recently -- and which you said was >>>> very brittle -- is indeed very brittle: I cannot get it to pass. We >>>> should fix it, or just delete it and do those rust-analyzer tests >>>> manually each time we touch this area. >>> Could you give more details? It is indeed more brittle in theory, but on >>> my machine it's passing every time. >> Yeah, I see it now - it succeeds in an interactive session and fails in >> batch mode. Not sure it was the same when the patch was committed >> (hopefully not). >> >> Might be due to window configuration being different... > Yes, I was trying batch mode. make -C test eglot-tests or something > similar. Please fix it or delete it (or disable it). Looking at minibuffer-tests.el, the above might be a solution, but it gets me a core dump instead: diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eglot-tests.el index e0168baee54..fa3b63b38dc 100644 --- a/test/lisp/progmodes/eglot-tests.el +++ b/test/lisp/progmodes/eglot-tests.el @@ -711,7 +711,8 @@ eglot-test-rust-completion-exit-function (search-forward "v.count_on") (let ((minibuffer-message-timeout 0) ;; Fail at (ding) if completion fails. - (executing-kbd-macro t)) + (executing-kbd-macro t) + (redisplay-skip-initial-frame nil)) (when (buffer-live-p "*Completions*") (kill-buffer "*Completions*")) ;; The design is pretty brittle, we'll need to monitor the Will follow up later if nobody beats me to it (can others reproduce the crash?)