From: Dmitry Gutov <dmitry@gutov.dev>
To: "João Távora" <joaotavora@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 72765@debbugs.gnu.org
Subject: bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text
Date: Sun, 8 Sep 2024 05:41:45 +0300 [thread overview]
Message-ID: <f062daaf-d4f1-43ce-abdf-d23e48d86e98@gutov.dev> (raw)
In-Reply-To: <CALDnm50tOCpF3TeWAFaGgSEC7Lz3Kqc_TQB5TfE46bmYZ5bQ2w@mail.gmail.com>
On 03/09/2024 16:43, João Távora wrote:
> On Tue, Sep 3, 2024 at 2:20 PM Dmitry Gutov<dmitry@gutov.dev> wrote:
>> On 01/09/2024 17:28, Dmitry Gutov wrote:
>>>> * the rust-analyzer test you added recently -- and which you said was
>>>> very brittle -- is indeed very brittle: I cannot get it to pass. We
>>>> should fix it, or just delete it and do those rust-analyzer tests
>>>> manually each time we touch this area.
>>> Could you give more details? It is indeed more brittle in theory, but on
>>> my machine it's passing every time.
>> Yeah, I see it now - it succeeds in an interactive session and fails in
>> batch mode. Not sure it was the same when the patch was committed
>> (hopefully not).
>>
>> Might be due to window configuration being different...
> Yes, I was trying batch mode. make -C test eglot-tests or something
> similar. Please fix it or delete it (or disable it).
Looking at minibuffer-tests.el, the above might be a solution, but it
gets me a core dump instead:
diff --git a/test/lisp/progmodes/eglot-tests.el
b/test/lisp/progmodes/eglot-tests.el
index e0168baee54..fa3b63b38dc 100644
--- a/test/lisp/progmodes/eglot-tests.el
+++ b/test/lisp/progmodes/eglot-tests.el
@@ -711,7 +711,8 @@ eglot-test-rust-completion-exit-function
(search-forward "v.count_on")
(let ((minibuffer-message-timeout 0)
;; Fail at (ding) if completion fails.
- (executing-kbd-macro t))
+ (executing-kbd-macro t)
+ (redisplay-skip-initial-frame nil))
(when (buffer-live-p "*Completions*")
(kill-buffer "*Completions*"))
;; The design is pretty brittle, we'll need to monitor the
Will follow up later if nobody beats me to it (can others reproduce the
crash?)
next prev parent reply other threads:[~2024-09-08 2:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 23:07 bug#72765: Eglot + Clangd + Company + non-empty suffix = duplicate text Dmitry Gutov
2024-08-29 11:34 ` Eli Zaretskii
2024-08-30 21:23 ` Dmitry Gutov
2024-08-31 6:47 ` Eli Zaretskii
2024-08-31 12:03 ` João Távora
2024-09-01 1:43 ` Dmitry Gutov
2024-09-01 9:43 ` João Távora
2024-09-01 14:28 ` Dmitry Gutov
2024-09-03 13:20 ` Dmitry Gutov
2024-09-03 13:43 ` João Távora
2024-09-08 2:41 ` Dmitry Gutov [this message]
2024-09-08 15:51 ` João Távora
2024-09-09 0:20 ` Dmitry Gutov
2024-09-09 11:46 ` Eli Zaretskii
2024-09-10 0:58 ` Dmitry Gutov
2024-09-10 11:47 ` Eli Zaretskii
2024-09-10 13:20 ` Dmitry Gutov
2024-09-10 1:40 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f062daaf-d4f1-43ce-abdf-d23e48d86e98@gutov.dev \
--to=dmitry@gutov.dev \
--cc=72765@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).