From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Date: Wed, 6 Jul 2016 22:35:49 +0000 (UTC) Message-ID: References: <7cb215b9-a70d-472a-ba85-15a9bc613a5e@default> <87h9ejkqqs.fsf@gnus.org> <3fe660b7-2b95-4e4a-a2c6-f03c751135d8@default> <87eg9nf0vu.fsf@gnus.org> <7a1d1091-78cc-4e88-b2d4-95d36e641ee5@default> <87poqyi05f.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1467844740 24142 80.91.229.3 (6 Jul 2016 22:39:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2016 22:39:00 +0000 (UTC) Cc: Lars Ingebrigtsen , 19362@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 07 00:38:47 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bKvSw-0004ub-T6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 00:38:47 +0200 Original-Received: from localhost ([::1]:36156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKvSv-0001iv-Om for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2016 18:38:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKvRL-0000Tw-CD for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 18:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKvRH-0000ju-69 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 18:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKvRH-0000jq-2d for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 18:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bKvRG-0007O0-Td for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2016 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2016 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 19362-submit@debbugs.gnu.org id=B19362.146784456228290 (code B ref 19362); Wed, 06 Jul 2016 22:37:02 +0000 Original-Received: (at 19362) by debbugs.gnu.org; 6 Jul 2016 22:36:02 +0000 Original-Received: from localhost ([127.0.0.1]:39967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKvQI-0007M8-0f for submit@debbugs.gnu.org; Wed, 06 Jul 2016 18:36:02 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:32269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKvQG-0007Ln-Bh for 19362@debbugs.gnu.org; Wed, 06 Jul 2016 18:36:00 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u66MZqXO005752 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 22:35:52 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u66MZp3d004563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2016 22:35:52 GMT Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u66MZoqV003867; Wed, 6 Jul 2016 22:35:51 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120535 Archived-At: > But do you know of any concrete cases where there is a difference in > behaviour? Or is this report just about code duplication (or lack > thereof)? 1. I don't know about concrete cases; sorry. 2. This report is an enhancement request; it doesn't report a bug. In the past, `eval-last-sexp' and `pp-eval-last-sexp' did about the same thing, apart from the pretty-printing part (which the latter farms out to another function). My guess is that _improvements_ were made to the former case (only). Just what those improvements were and why they were made I don't know. > I found #10495 "pp-eval-last-sexp doesn't work on a `symbol' in > quotes", but that was reported against 24.0.92, so perhaps these > functions were in fact never "aligned"? The functions used to be mostly "aligned", but it's possible that the difference Michael points out in #10495 was present. I don't know. In any case, I was not really referring to the interactive behavior but to the code/behavior after the sexp has been determined. In the case of `eval-last-sexp' I guess that means the code other than `elisp--preceding-sexp'. I'm interested in both, but I don't think I was paying attention to differences that are covered by the `elisp--preceding-sexp' code. Michael's bug is all about extending what `elisp--preceding-sexp' does to pp.el. It could perhaps be a good start, in terms of realignment. On the other hand, that behavior seems to be overly DWIM, making heuristic assumptions about what sexp you _really_ wanted to evaluate. I'm not sure that's always such a good thing. I'd probably rather have that DWIM be a user choice (option). `pp-eval-last-sexp' is much simpler. In any case, what `elisp--preceding-sexp' is/does is not really what I had in mind about the code divergence, as you rightfully observed. So I guess this bug report is somewhat complementary to Michael's report.