unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Takafumi Arakaki <aka.tkf@gmail.com>
To: 11469@debbugs.gnu.org
Subject: bug#11469: [PATCH] Fix bug #11469; propagate url-request-* vars properly
Date: Thu, 20 Dec 2012 21:13:31 +0100	[thread overview]
Message-ID: <ezbodofnmj.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAPM+gBTGYPiGP0-baYM8Kox18d4moxTCLvCU4f1sf8fCSPSRgA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi,

This is a patch to fix bug #11469
24.1.50; url-retrieve with PUT method fails every two times
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11469

Best,
Takafumi

[-- Attachment #2: 0001-Fix-bug-11469-propagate-url-request-vars-properly.patch --]
[-- Type: application/octet-stream, Size: 1297 bytes --]

From 3d1e5c7dd14d5b47749b9a1c727deb64abcb5bba Mon Sep 17 00:00:00 2001
From: Takafumi Arakaki <aka.tkf@gmail.com>
Date: Thu, 20 Dec 2012 20:06:00 +0100
Subject: [PATCH] Fix bug #11469; propagate url-request-* vars properly

url-retrieve with PUT method failed every two times prior to this
patch, as url-request-method was not propagated to the nested call
of url-http.
---
 lisp/url/url-http.el |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 73d53e0..1f705f6 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -890,8 +890,11 @@ should be shown to the user."
 		 (url-http-activate-callback)
 	       ;; Call `url-http' again if our connection expired.
 	       (erase-buffer)
-	       (url-http url-current-object url-callback-function
-			 url-callback-arguments (current-buffer))))
+               (let ((url-request-method url-http-method)
+                     (url-request-extra-headers url-http-extra-headers)
+                     (url-request-data url-http-data))
+                 (url-http url-current-object url-callback-function
+                           url-callback-arguments (current-buffer)))))
 	    ((url-http-parse-headers)
 	     (url-http-activate-callback))))))
 
-- 
1.7.5.4


  reply	other threads:[~2012-12-20 20:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 11:31 bug#11469: 24.1.50; url-retrieve with PUT method fails every two times Takafumi Arakaki
2012-12-20 20:13 ` Takafumi Arakaki [this message]
2012-12-22  2:59   ` bug#11469: [PATCH] Fix bug #11469; propagate url-request-* vars properly Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ezbodofnmj.fsf@fencepost.gnu.org \
    --to=aka.tkf@gmail.com \
    --cc=11469@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).