From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kira Bruneau via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56957: [PATCH] Fix ignored-local-variable-values for non-primitive values Date: Wed, 03 Aug 2022 18:17:16 +0000 Message-ID: References: <9RWG0AQeAiQorgDI765IlZT2f_67aE7wMa0PPZRiNSZmMIOI_Hvz6fer6Ph4HvujTNd4mv2aoqXHryzvKX_pcpgu7itrz5tdNdDdoUGarY8=@pm.me> Reply-To: Kira Bruneau Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_jFn3PTzAnIXLDLCNH1byunJA00Vvqeg1J6kwAi1v7sk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30874"; mail-complaints-to="usenet@ciao.gmane.io" To: 56957@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 03 20:54:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJJVj-0007tJ-G9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Aug 2022 20:54:27 +0200 Original-Received: from localhost ([::1]:50340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJJVi-0008B6-DT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Aug 2022 14:54:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJJVK-0007nu-Tk for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 14:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJJVK-0008Aj-LL for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJJVK-0002Sv-HG for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kira Bruneau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.16595528159442 (code B ref -1); Wed, 03 Aug 2022 18:54:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Aug 2022 18:53:35 +0000 Original-Received: from localhost ([127.0.0.1]:49971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJJUr-0002SD-Nt for submit@debbugs.gnu.org; Wed, 03 Aug 2022 14:53:35 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJIvq-0001Ua-PC for submit@debbugs.gnu.org; Wed, 03 Aug 2022 14:17:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJIvq-0005BI-Jz for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 14:17:22 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]:50841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJIvo-0000KF-Ug for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 14:17:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1659550639; x=1659809839; bh=6gyY5eO/FV93gWS0zUB5uJGo1RoLQ1QCx2Qxhlg0RLk=; h=Date:To:From:Reply-To:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=NaDhWnNeeqJDvN7iuZ1S1tQeBjaUZFVW6KRFxd55hiamFEEew5M7Kb16jEnaWsDUS tubSxW2iUY9ViTPAiNsCOCztX4isX/79T2x4aarMgbd0vtKJW3aYsk3MtfPn2/88M5 pGjN4MB7Wm6F45+UgNfpTjcdSGNsGefeX7fLazijPVSaeayf/VdX8t9Ii0L04vP732 YxzfY2j4aPqCaZ+5eDSHkUMWuMv/XHpTw6idW2oRqt5N0ZT5c7ofi6m+EycZcehq9R sx9QJ1MbcrXAIJpJSGgT83+bO4ZdfVR9qcgc1t8fELyCocrZQS2mnLnm82mdTs5TmJ aTe6DLlqjhfDw== In-Reply-To: <9RWG0AQeAiQorgDI765IlZT2f_67aE7wMa0PPZRiNSZmMIOI_Hvz6fer6Ph4HvujTNd4mv2aoqXHryzvKX_pcpgu7itrz5tdNdDdoUGarY8=@pm.me> Feedback-ID: 31546501:user:proton Received-SPF: pass client-ip=185.70.43.16; envelope-from=kira.bruneau@pm.me; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 03 Aug 2022 14:53:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , Kira Bruneau Xref: news.gmane.io gmane.emacs.bugs:238647 Archived-At: This is a multi-part message in MIME format. --b1_jFn3PTzAnIXLDLCNH1byunJA00Vvqeg1J6kwAi1v7sk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oh sorry, I just noticed I had my old email configured for my local git rep= o. Here's a patch with my updated email. ------- Original Message ------- On Wednesday, August 3rd, 2022 at 2:09 PM, Kira Bruneau wrote: > > > I noticed that structural comparison wasn't being done to ignore values i= n `ignored-local-variable-values', so it could only ever ignore primitive v= alues. --b1_jFn3PTzAnIXLDLCNH1byunJA00Vvqeg1J6kwAi1v7sk Content-Type: text/x-patch; name=0001-Fix-ignored-local-variable-values-for-non-primitive-.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-ignored-local-variable-values-for-non-primitive-.patch RnJvbSA2YWU5YTllZTlhMTc3ZGE5ZmJiYzNlMzFmYWYwMjAyZmI4NDZhZWJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLaXJhIEJydW5lYXUgPGtpcmEuYnJ1bmVhdUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMyBBdWcgMjAyMiAxMzo0Nzo0NyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBpZ25vcmVkLWxvY2FsLXZhcmlhYmxlLXZhbHVlcyBmb3Igbm9uLXByaW1pdGl2ZSB2YWx1ZXMK ClRoaXMgd2FzIHByZXZpb3VzbHkgdXNpbmcgc2VxLXNvbWUgKyBlcSB0byBjb21wYXJlIGFnYWlu c3QgaWdub3JlZAp2YWx1ZXMsIGJ1dCBub3cgd2UgdXNlIG1lbWJlciB0byBzdHJ1Y3R1cmFsbHkg Y29tcGFyZSB2YWx1ZXMgbGlrZSB3ZQpkbyBmb3IgYHNhZmUtbG9jYWwtdmFyaWFibGUtdmFsdWVz Jy4KKiBsaXNwL2ZpbGVzLmVsIChoYWNrLWxvY2FsLXZhcmlhYmxlcy1maWx0ZXIpOiBGaXgKYGln bm9yZWQtbG9jYWwtdmFyaWFibGUtdmFsdWVzJyBmb3Igbm9uLXByaW1pdGl2ZSB2YWx1ZXMuCi0t LQogbGlzcC9maWxlcy5lbCB8IDUgKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxl cy5lbAppbmRleCA1ZGYxOTY2MTkzLi4yMTVlN2RiN2Q4IDEwMDY0NAotLS0gYS9saXNwL2ZpbGVz LmVsCisrKyBiL2xpc3AvZmlsZXMuZWwKQEAgLTM4NDgsMTAgKzM4NDgsNyBAQCBESVItTkFNRSBp cyB0aGUgbmFtZSBvZiB0aGUgYXNzb2NpYXRlZCBkaXJlY3RvcnkuICBPdGhlcndpc2UgaXQgaXMg bmlsLiIKIAkoY29uZCAoKG1lbXEgdmFyIGlnbm9yZWQtbG9jYWwtdmFyaWFibGVzKQogCSAgICAg ICA7OyBJZ25vcmUgYW55IHZhcmlhYmxlIGluIGBpZ25vcmVkLWxvY2FsLXZhcmlhYmxlcycuCiAJ ICAgICAgIG5pbCkKLSAgICAgICAgICAgICAgKChzZXEtc29tZSAobGFtYmRhIChlbGVtKQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGFuZCAoZXEgKGNhciBlbGVtKSB2YXIpCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChlcSAoY2RyIGVsZW0pIHZhbCkpKQotICAgICAgICAg ICAgICAgICAgICAgICAgIGlnbm9yZWQtbG9jYWwtdmFyaWFibGUtdmFsdWVzKQorICAgICAgICAg ICAgICAoKG1lbWJlciBlbHQgaWdub3JlZC1sb2NhbC12YXJpYWJsZS12YWx1ZXMpCiAgICAgICAg ICAgICAgICBuaWwpCiAJICAgICAgOzsgT2JleSBgZW5hYmxlLWxvY2FsLWV2YWwnLgogCSAgICAg ICgoZXEgdmFyICdldmFsKQotLSAKMi4zNy4xCgo= --b1_jFn3PTzAnIXLDLCNH1byunJA00Vvqeg1J6kwAi1v7sk--