From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 08 Feb 2024 00:19:55 +0900 Message-ID: References: <83zfx39mcy.fsf@gnu.org> <87a5og8m7t.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Eli Zaretskii , 68559@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 07 16:21:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXjjY-0000ls-Vi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Feb 2024 16:21:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXjjG-0002pM-9g; Wed, 07 Feb 2024 10:20:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXjjE-0002oZ-LB for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 10:20:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXjjE-00089w-DD for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 10:20:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXjjS-0000Yt-5J for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 10:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Feb 2024 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.17073192202096 (code B ref 68559); Wed, 07 Feb 2024 15:21:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 7 Feb 2024 15:20:20 +0000 Original-Received: from localhost ([127.0.0.1]:57620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXjim-0000Xj-DD for submit@debbugs.gnu.org; Wed, 07 Feb 2024 10:20:20 -0500 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:49378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXjik-0000XV-56 for 68559@debbugs.gnu.org; Wed, 07 Feb 2024 10:20:18 -0500 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d953fa3286so6393475ad.2 for <68559@debbugs.gnu.org>; Wed, 07 Feb 2024 07:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707319198; x=1707923998; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=4Oa+093vJ/su9qkJ+AcO64FcV+8fgsY4AGvC7Ag2p3w=; b=bYBJSNfMWhbefLkYMytcIKmI2qOFW8DFfqReytAKZBUco8aLWgyvJzewg7htH+E37g yqW9c7i3nTblG7BnIlUA5q7vAsLBmy3F16wd/RZa4sdtkzaM+5ErqQ05uSFLmWMbNV0B Rz+btBsUp+QRuVfkonHsSnaoi2/rwent+aYS4Jhw2gL6eM1Un1pw8NyegfNa13grqkLN vTAYoCO7lTi9oAd2vX0tkfTlCB/0Y1JuqoS2sj1wQlnzsX9y03P80xmrhLvoKsY1D7mt EvRPGZR8rSzUG7aYxpog5DRmnGfaIXszGMN0BVf1YQsleB2/87+O79uxXhJXvWLqVLRF wbjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707319198; x=1707923998; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4Oa+093vJ/su9qkJ+AcO64FcV+8fgsY4AGvC7Ag2p3w=; b=fqRMZAKTWlfNJG3/OZxAK5PhM089tfgEHuq6mXOlbzMebvtS2t09VvfbF0RUn1imUW suE6ynGU35rRbtsbbSoZCA/iPqjRzlgSa7OPzLGmDS4BZcDGQFdvW7AZP5pwpmZBoWIt BszwxA10QED8jzXq8Cu5bOpoWdrGchXcqpT4B4V3uyy20LdWSXmINMrYxJX+2xS/6LsX +oqYO8rYPp7MPxWoApvzJiwkSDeDsoOw9UUceP9w6B8pi+uOFpuxQjUBaa5oEffYkntf HJTyAqJoERcTlzeOCevuFATQNiIlfvEFELNLKHXYY/lMQydF4zAVgvApAfQvvDC23wQv Dk+w== X-Gm-Message-State: AOJu0Yy2ymd95ivfHDRQhYUL+gSRDOwafo9t/MBVnqojMazBxzEl14UB BVXyxfI+64rA7tNph1cin9SyEiC3s/rqQe5PKF4kNR8NcHez2avo X-Google-Smtp-Source: AGHT+IFbAiUjzXsjg+JqzjsAs5zdF4fvrC2CwoS08Ixlu2VCxkIfGrQQ656ZWGS1okF61ERCszuSmg== X-Received: by 2002:a17:902:bb10:b0:1d9:ed80:607f with SMTP id im16-20020a170902bb1000b001d9ed80607fmr2194197plb.41.1707319197783; Wed, 07 Feb 2024 07:19:57 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUMT21Ys/flZNzIYlczG0ioRaSoQEQae9LVsVMeNhDYzQy9R1DYH9ckuPOAqKl4m+I1rQ66vrvfzeiDy1hOGqO0KFy9m7c= Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id kh13-20020a170903064d00b001d94a461d2dsm1560866plb.73.2024.02.07.07.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 07:19:57 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279555 Archived-At: Liu Hui wrote: > On Tue, Feb 6, 2024 at 11:12=E2=80=AFPM kobarity wro= te: >=20 > > Sorry, I noticed one more thing. As written in the comments below, it > > would be better to use `line-beginning-position' and > > `line-end-position' instead of `pos-bol' and `pos-eol'. > > > > ;; This is a GNU ELPA :core package. Avoid functionality that is not > > ;; compatible with the version of Emacs recorded above. >=20 > Thanks for pointing it out! `pos-bol' was used because it can ignore > the prompt in `python-shell--get-multiline-input'. Fortunately, I find > `pos-bol' and `pos-eol' are available in the compat package since > 29.1.1.0, so it should be enough to upgrade the compat version in > Package-Requires. I have updated the attached patch. I see. The patch looks good to me. I appreciate your efforts!