From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#59477: python-tests fail without tree-sitter Date: Tue, 29 Nov 2022 00:18:10 +0900 Message-ID: References: <207B066C-2C1F-40B3-9E13-9DFC3ABCF92F@gmail.com> <0AAD0494-CF2D-4AE1-B939-4C610CC4018A@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Tue_Nov_29_00:17:52_2022-1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Yuan Fu , Stefan Monnier , 59477@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 16:19:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozfv1-0002e9-2D for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 16:19:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozfui-0007od-B7; Mon, 28 Nov 2022 10:19:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfuQ-0007kQ-Qy for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 10:19:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozfuQ-0008DN-G9 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 10:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozfuQ-0005Kq-1q for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 10:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59477 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 59477-submit@debbugs.gnu.org id=B59477.166964870720488 (code B ref 59477); Mon, 28 Nov 2022 15:19:02 +0000 Original-Received: (at 59477) by debbugs.gnu.org; 28 Nov 2022 15:18:27 +0000 Original-Received: from localhost ([127.0.0.1]:49187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozftq-0005KN-M7 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:18:26 -0500 Original-Received: from mail-pl1-f177.google.com ([209.85.214.177]:38644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfto-0005K6-H6 for 59477@debbugs.gnu.org; Mon, 28 Nov 2022 10:18:25 -0500 Original-Received: by mail-pl1-f177.google.com with SMTP id j12so10443796plj.5 for <59477@debbugs.gnu.org>; Mon, 28 Nov 2022 07:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=s54rQwIGEfhJFT2QrOBXLOJbq7593rJDBLSwOmsB9e4=; b=oGDnfd9hbrStNNZnObxJdnhFB8prixl/c7hjGSO+SLL18hN+QF8fY+BzIN7Z9iL982 JEc7f4Z7h1CukWhoE902exMxuU27HkovHbPKchVfvAL4PE1MDHQ3LfwGvOSDSzLIuxi0 YRAhNDkcQnxFMWzWos8KYuP/yCqo0awYTJ9uexshJ9cWfeXpg/nfVHUMyhlyPmUfStO4 Uia9HBLpNw0Gx2qY7+4JVUnluTYoRP9sw1/EhAT3C8vGFItjT36t5Tu/x1zNdmcQusCk eTDaSfkgTn/8F+kRKkzR7tjeVTjug4U6GPDbnMGpEFN62RzDKi8xqvJYh1mYxwc/uSqa ikQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s54rQwIGEfhJFT2QrOBXLOJbq7593rJDBLSwOmsB9e4=; b=pCf89r1qwrFR9dwoxKzMY6or5xLmRKtop9FY6UEUrsh1IpBmd8NEmJiP07G4eiZ534 9HlB2NX1xzI/gzJTYEwqmHzFuWx96vJgl880IfPHqVXkb8tca0kO5ru0Qf/COwM5augX DX0hqrtgG2x0Yq+771iw639qTbktE69Thre7CwCVac1oioAQFdsUAONAV7+17bUrr+kN uTEuPrTa8bS27ZVLDxcsiNf7aRi3i6QcrCN7DWgHiuI/JQdT8XRgqqOgqSnIt94u6jJo 3t4tgRbORoeEELgcP+9dMyFU/zZOz0gHJ4ti8vBXMRmyjgF0FNqXZxigJLGbsUgbJaWO AFPg== X-Gm-Message-State: ANoB5pnPpMMQMPmbBHbPhHJhqHAdQC/ootqucYFs2spMrvx8ABuZEk1M POtXAnDGCB4fcUkmDTit0ks= X-Google-Smtp-Source: AA0mqf7mKeLVXDNSz+9bsCpmAZXy+3+zmPz/0F5FTg2mWXs9xXzsMFuxHxse5KNHKme2IoYRUyoAmQ== X-Received: by 2002:a17:90b:711:b0:210:9858:2b2c with SMTP id s17-20020a17090b071100b0021098582b2cmr55724293pjz.191.1669648698523; Mon, 28 Nov 2022 07:18:18 -0800 (PST) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id y185-20020a6264c2000000b0056bc30e618dsm8160755pfb.38.2022.11.28.07.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 07:18:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249318 Archived-At: --Multipart_Tue_Nov_29_00:17:52_2022-1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=E5rd wrote: > > 1. emacs -Q > > 2. Open Python file. (Empty file is OK) > > 3. C-c C-p (M-x run-python) > > 4. C-x o (Back to the Python mode buffer) > > 5. M-: (python-shell-send-string-no-output "print('a')") > >=20 > > My expectation is "a". >=20 > The result here is >=20 > "__PYTHON_EL_eval(\"print('a')\", \"/Users/mattias/emacs/asdf.py\")\r\na" >=20 > which is consistent with the test failure -- something in python-mode is = having trouble parsing the reply. I traced `python-shell-output-filter`; se= e attached file. >=20 > This might be bug#25753 again (via a comment in etc/PROBLEMS). Even if no= effort is made to fix the bug properly, we should make sure the test doesn= 't fail. Thank you for the logs and letting me know about bug#25753. It seems to be a bug that has existed for some time on Mac. Here is the trace on my Ubuntu. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter ">>> ") 1 <- python-shell-output-filter: "" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter ">>> ") 1 <- python-shell-output-filter: "" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter "python.el: native completion setup loaded= \n") 1 <- python-shell-output-filter: "" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter ">>> ") 1 <- python-shell-output-filter: "" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter "a\n") 1 <- python-shell-output-filter: "" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (python-shell-output-filter ">>> ") 1 <- python-shell-output-filter: "" As for `python-ffap-module-path-1', it assumes that `python-ffap-module-path' and its underlying `python-shell-send-string-no-output' operate correctly. So I think the first option is to mark as an expected failure on Mac as the attached patch. However, I'm not sure if it fails on all Macs. Another option may be to add :unstable tag. Which do you think is better? --Multipart_Tue_Nov_29_00:17:52_2022-1 Content-Type: application/octet-stream; type=patch; name="0001-Mark-python-ffap-module-path-1-as-an-expected-failur.patch" Content-Disposition: attachment; filename="0001-Mark-python-ffap-module-path-1-as-an-expected-failur.patch" Content-Transfer-Encoding: 7bit >From b560b9744d6db7d0107a16699c95c91a7a4d6efc Mon Sep 17 00:00:00 2001 From: kobarity Date: Tue, 29 Nov 2022 00:05:23 +0900 Subject: [PATCH] Mark python-ffap-module-path-1 as an expected failure on Mac * test/lisp/progmodes/python-tests.el (python-ffap-module-path-1): Mark as an expected failure on Mac. (Bug#59477) --- test/lisp/progmodes/python-tests.el | 1 + 1 file changed, 1 insertion(+) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index f871b7bc7d..2bfaa33634 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -4565,6 +4565,7 @@ python-completion-at-point-native-with-eldoc-1 ;;; FFAP (ert-deftest python-ffap-module-path-1 () + :expected-result (if (eq system-type 'darwin) :failed :passed) (skip-unless (executable-find python-tests-shell-interpreter)) (python-tests-with-temp-buffer-with-shell " -- 2.34.1 --Multipart_Tue_Nov_29_00:17:52_2022-1--