From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string Date: Sat, 22 Jun 2024 23:16:51 +0900 Message-ID: References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14522"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 71720@debbugs.gnu.org To: Eli Zaretskii , James Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 16:19:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sL1aB-0003W2-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 16:19:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sL1a4-0006vK-O2; Sat, 22 Jun 2024 10:19:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL1a3-0006vB-Ay for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 10:19:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sL1a2-0006eP-9Z for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 10:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sL1a2-00071g-2w for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71720-submit@debbugs.gnu.org id=B71720.171906588326906 (code B ref 71720); Sat, 22 Jun 2024 14:19:02 +0000 Original-Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 14:18:03 +0000 Original-Received: from localhost ([127.0.0.1]:47560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL1Z4-0006zu-Ro for submit@debbugs.gnu.org; Sat, 22 Jun 2024 10:18:03 -0400 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:44342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL1Z3-0006zH-3o for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 10:18:01 -0400 Original-Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1f9c2847618so25271495ad.1 for <71720@debbugs.gnu.org>; Sat, 22 Jun 2024 07:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719065815; x=1719670615; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=QLrQ9EyhauWv6g7zWgeO+j7TXSVt5+4pGqU/bFRNZg8=; b=KIaGT5bj3xGpRtNYHutMhT1p8pgLyxpGvOxFswqFR4NcDjvp2DG+bVDN0cH4XUkIfc Bb4ATnmK3t1BATuQfvbevSPt0UdR1AXrgRQwf/DVCi4enntWp2zvq6SGsw+m12mKot4g mwTQ7/BtjZubHyUy+mfg1AMrfQRnCjJqhA682MNXzWqsk+64IjNu1sQD6RPp6RD0H108 cMfKrSunIcJn9HMBdSGEy67BFxWVpzcMPcVimY3sYlRlNgdrcCISPca8X16DN1vCsZ+o OcpVxGgIp4wKesFMnbDAa6TLTK1PseHnK5ajwr8BDBR1GGZtKKSZZd6fTKvyT6+x0dVi ee2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719065815; x=1719670615; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QLrQ9EyhauWv6g7zWgeO+j7TXSVt5+4pGqU/bFRNZg8=; b=U6OJMqt3R/kj8luTgiqVTOMpZsMpC0bCr+mrLuDQC8j5KxLKC9LlqH0r/1M8SPhCsa 1mGhtnYjmOIHz3KhAuu64JNqWiCRDN8CRfZhxvxTU16POCBzUmRsLLJFkwI6+42G/ndb B8yah1QL3eVMg2PSHoUBCOkjt5dQmKgMDpyofAV5BGMRxu0JaHM/GN6jXcFAeULRxprN gNOWHOT2AyaxXABQy2x5tZw/URV5YwAMHmcRxK+OQNHmjotyU0JBEXQHuolI9F2+kWfH u0RdQKugYnfTr5mhwRyuRxISXaJ3k8LmynBvAu1qIJZnOSzWOvBE3a3U49QSE/g3q05p vnYw== X-Gm-Message-State: AOJu0YxrLNUVeH3q+4GFmcm6wf/defIcSOP8WaO2hRrvRQnVes0tCViF ZrodVndb6mG3CsGeosILqDIdPVccoocDxSNHmRVd9s6/hdkNqSZY X-Google-Smtp-Source: AGHT+IGx/L1fMO+p0Iwhs0j74mwVv4rlwjqsBNh6BhV3mBNglb0o1DYBrCX6GyyUX7Bx4KL1R4yG7A== X-Received: by 2002:a17:902:dac9:b0:1fa:781:bb38 with SMTP id d9443c01a7336-1fa15937c43mr7342395ad.51.1719065815035; Sat, 22 Jun 2024 07:16:55 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9eb2f10fasm31501845ad.15.2024.06.22.07.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 07:16:54 -0700 (PDT) In-Reply-To: <86jzihgmet.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287710 Archived-At: Eli Zaretskii wrote: > > > Date: Sat, 22 Jun 2024 18:14:21 +0530 > > From: James Thomas via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > - emacs -Q > > - C-x C-f test.py > > - M-x run-python > > - C-x o > > - Type: print( > > > > Only one line is shown, even with: > > > > - M-x eldoc-doc-buffer. > > > > > > From 9fb4b45ef2c408ff76d5e145ea3c38eac60b4d16 Mon Sep 17 00:00:00 2001 > > From: James Thomas > > Date: Sat, 22 Jun 2024 17:57:00 +0530 > > Subject: [PATCH] Do not prematurely truncate python eldoc string > > > > 'eldoc-echo-area-use-multiline-p' is there for that. > > * lisp/progmodes/python.el (python-eldoc-setup-code): > > Make the change. > > --- > > lisp/progmodes/python.el | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > index bb2bf1731b4..a52e21f625e 100644 > > --- a/lisp/progmodes/python.el > > +++ b/lisp/progmodes/python.el > > @@ -5607,8 +5607,6 @@ python-eldoc-setup-code > > doc = '{objtype} {name}{args}'.format( > > objtype=objtype, name=name, args=args > > ) > > - else: > > - doc = doc.splitlines()[0] > > except: > > doc = '' > > return doc" > > -- > > 2.43.0 > > kobarity, any comments? I agree with this fix. For those who want the same behavior as before, setting eldoc-echo-area-use-multiline-p to nil should be sufficient. It might be better to make this change known in etc/NEWS, though.