From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string Date: Sun, 23 Jun 2024 12:53:04 +0900 Message-ID: References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> <86bk3s9xac.fsf@gmx.net> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 71720@debbugs.gnu.org To: James Thomas , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 05:55:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLEK6-0007gr-VA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 05:55:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLEJk-0003wS-91; Sat, 22 Jun 2024 23:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLEJi-0003wK-BM for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLEJi-00052x-2i for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLEJi-0003OD-0y for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 03:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71720-submit@debbugs.gnu.org id=B71720.171911485612927 (code B ref 71720); Sun, 23 Jun 2024 03:55:01 +0000 Original-Received: (at 71720) by debbugs.gnu.org; 23 Jun 2024 03:54:16 +0000 Original-Received: from localhost ([127.0.0.1]:42658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLEIx-0003MQ-TJ for submit@debbugs.gnu.org; Sat, 22 Jun 2024 23:54:16 -0400 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:55783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLEIv-0003M9-Ug for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 23:54:15 -0400 Original-Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f9aeb96b93so23801795ad.3 for <71720@debbugs.gnu.org>; Sat, 22 Jun 2024 20:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719114788; x=1719719588; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=qfFJDVQvxSTrX7M7CLhH28PJTOkEGnck8rR5mHDxU3M=; b=HQ2NDyJ6ME4i39rnjuVsUQLRZ3Svqnd/QaUvTfzxZdGJKVGyOwFElIPXop2tzIGk+I 0k5FjdZ817nd0Eq1KrQI5QQ76Bhrr2AJ5HRYE5DX6tKw+D7f3H2YNoAmjqmuHfivaIj4 I3ngkunQOiSrUVN/c7h56Hi/1jQ18zlMuwWDbaRCLKSIJoGdT/Rq7ik3nELBy7hvc9Wu HkGmdWSuClLwSL6gEIJlcCY9zXbhUTdMr1BS5oB3r0Dppb2vO2rW2hM2lWBYac6uxseB bpUJFQQa+EeDAL7uO+plKvOZF9ycy8QGSfN4DsInshLYPPiXezSlmqN6QNhofdrcmpi+ 92KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719114788; x=1719719588; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qfFJDVQvxSTrX7M7CLhH28PJTOkEGnck8rR5mHDxU3M=; b=HWM67nZ87JTBHm+mDxS26ehixyygNNEieSIIi/wNMQQ6bZvHAC8mRqrN7IBJTmBm3I 4eQ9sImgKtBpTi8jwvfeDgDk534t3w6jyWMiWy2YJxpFlNGm1Nt1jvwS+h5QXxQJgGQ/ Ml0zynLH6xyG1Y2csZnaRkveYpABl1AbgkFZN97FbihQ+nXwjuOb94KqEbZudaxQEtHV a2lJA9vQ+YW3kDWtso+u5KldSG7hHwtVkPKunZbCn0bPvLMrwQXRXxxN+02EnzU32hZY +a/ItX2VjnHu67JuHt/NYmhxl5+P6HnHG9coocJp0V1vUvL0MjQGrmfWtKEuslLSPGtF 5bkA== X-Gm-Message-State: AOJu0YzPmU73R1b1kOOdZcbVGeaUf1sbrNlF+M/IyYvW/ubjqZJAJQr8 q8Od8BUjckceCBYohOaiQRKRjztnWCu3Odz35/n0CZIQ4xietY2w X-Google-Smtp-Source: AGHT+IFrvlyjoo6fuA4nUVK1OtyYH6WhpQGJCIsxyRhvqDCs4w7uJrl5CD6/hvWavlyeSCYeI6tEPg== X-Received: by 2002:a17:902:f70f:b0:1fa:2b89:f53f with SMTP id d9443c01a7336-1fa2b89f7a7mr8395265ad.52.1719114787489; Sat, 22 Jun 2024 20:53:07 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbb5d03sm38326265ad.258.2024.06.22.20.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 20:53:07 -0700 (PDT) In-Reply-To: <86bk3s9xac.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287753 Archived-At: James Thomas wrote: > kobarity wrote: > > > James Thomas wrote: > >> Eli Zaretskii wrote: > >> > >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 > >> >> From: kobarity > >> >> Cc: 71720@debbugs.gnu.org > >> >> > >> >> Eli Zaretskii wrote: > >> >> > > >> >> > kobarity, any comments? > >> >> > >> >> I agree with this fix. For those who want the same behavior as > >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be > >> >> sufficient. It might be better to make this change known in etc/NEWS, > >> >> though. > >> > > >> > Thanks. > >> > > >> > James, can you add a NEWS entry and resubmit? > >> > >> How about this? > > > >> +*** 'eldoc' no longer truncates to a single line by default. > >> +Previously, the entire docstring was not available to eldoc, which made > >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be > >> +kept by setting that. > >> + > > > > Thanks, I think the content is perfect, but from other examples, it > > might be better to have two spaces after the period. > > Fixed: Thanks, it looks good to me.