From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#70609: 30.0.50; [PATCH] New function 'python-shell-send-block' for python-mode Date: Tue, 30 Apr 2024 16:28:26 +0900 Message-ID: References: <86zftcqqby.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20445"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 70609@debbugs.gnu.org To: Lin Sun , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 30 09:29:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1hvz-0005D3-KU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Apr 2024 09:29:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1hvr-00080X-FM; Tue, 30 Apr 2024 03:29:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1hvp-00080A-Un for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 03:29:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1hvp-0002Us-Jl for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 03:29:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s1hw9-0002DK-V9 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 03:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2024 07:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70609-submit@debbugs.gnu.org id=B70609.17144621448474 (code B ref 70609); Tue, 30 Apr 2024 07:30:01 +0000 Original-Received: (at 70609) by debbugs.gnu.org; 30 Apr 2024 07:29:04 +0000 Original-Received: from localhost ([127.0.0.1]:59155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1hvE-0002Cc-Ay for submit@debbugs.gnu.org; Tue, 30 Apr 2024 03:29:04 -0400 Original-Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]:58584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1hv7-0002C6-8j for 70609@debbugs.gnu.org; Tue, 30 Apr 2024 03:29:02 -0400 Original-Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-5aa400b917dso3598043eaf.0 for <70609@debbugs.gnu.org>; Tue, 30 Apr 2024 00:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714462111; x=1715066911; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=LziF320Fob2GtdT3A1XICFn30DC/tjaw4pu+9RYMrLc=; b=O7nt2ZgDwaGQAjNK6PuD83rswdhhssTLk4RS0xYHf56rww+3HWgI9dAPVha7Hbo8nU +yhLeXJK6p06C8GmDVno6Z5BnGdclgGwY2/1PCptJAEsOt3wVXQKSo6Wl1s2lfp2Do9F kbsi/nG0sDlTxSqZYdMa5Iw16wz8zLVhEOMMbD7dxNLakR5GH38hz2LEmI4QM8H815il H7Vyn6bXBYGSQxmf0b70/rvbq4jn9c4QxD9C8xDaZQ1kGE0UT5YcPszSwDQ1tvufHJtd GxqCij8N7AZhI9nQJOD/hZdTqa+rECHaJWO/agseJY9idFsSFKTBa1WY0NbCSDkjBtBS cUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714462111; x=1715066911; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LziF320Fob2GtdT3A1XICFn30DC/tjaw4pu+9RYMrLc=; b=wUlUZf8ikF5MIny+kRG3Dv8XyaXSPCl1oCR+WpCHwJkfwvEXR/vNqi5RR8h+KNFuQ2 RmIrmYlIL6ft91WrMREva/0RU9edJD0aP9I3Fko6cvXbQAP75Ux9qY7ycq/7IzeSkqJl x7jEnNoUXug6Qop0Og7veYNW4vn31fMYKhH6V5/jcjg/o6uDot8jIIxNrNnjWUfHI1Fs fshiFrxvtr1OHCssuqXuMk0ljb6byW+GBOzX5bUTs/4Pk9xJv+F6Mj9mfIUGKqfjjSNe r7ESUapE+j1519SnJybKgx1ev+/GlFZ29FzioHw/9kmt+JuAtfTvlTSG/DEsjzF0ciVF jQUw== X-Gm-Message-State: AOJu0YxI+v4A7onu2ZlM5gOmqS+673EalLmLdx+vytVXqlVyDLtjM3cq gsutBrIUQivHQ2rYIPZgPmGimOwH17nI/9b8DaC17HYaMy7rWRm6KPszGw== X-Google-Smtp-Source: AGHT+IGQbCh/Vhzc6YJifw8F68msLBE9k0+LFTqTi2ocdupOVgnsIXakKPPV/LCx5BWP0Nb/AGXMog== X-Received: by 2002:a05:6358:ed09:b0:18b:d44:52b6 with SMTP id hy9-20020a056358ed0900b0018b0d4452b6mr13558588rwb.16.1714462110823; Tue, 30 Apr 2024 00:28:30 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id r30-20020a638f5e000000b005f7f51967e9sm18772672pgn.27.2024.04.30.00.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 00:28:30 -0700 (PDT) In-Reply-To: <86zftcqqby.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284189 Archived-At: Eli Zaretskii wrote: > > > From: Lin Sun > > Date: Sat, 27 Apr 2024 14:14:06 +0000 > > > > Here is a function 'python-shell-send-block' to send a block to the > > python interpreter in python mode, it's similar to > > `python-shell-send-defun` but works on block. > > > > The implementation and testing are included in that patch. > > > > Please help review the changes. > > > > [PATCH] New function 'python-shell-send-block' for python-mode > > > > * lisp/progmodes/python.el: Add implemention of the function. > > * test/lisp/progmodes/python-tests.el: Test case for the function. > > * etc/NEWS: Document for the function. > > kobarity, any comments? I think `python-shell-send-block' itself is good, but there may be room for improvement in the test case. It is better not to use f-strings as much as possible because it depends on the Python version. `python-tests-look-at' is basically for moving point. Since it looks for the next occurrence of the specified string, it may move the point to an unexpected location. For testing, it would be better to use `looking-at', etc. or compare the point after moving with `python-tests-look-at' to the expected value.