unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: kobarity <kobarity@gmail.com>
To: "Jakub Ječmínek" <jecminek.k@gmail.com>
Cc: 45897@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#45897: [PATCH] 27.1; python mode font-lock confused by string concatenation
Date: Sun, 21 Jan 2024 16:39:43 +0900	[thread overview]
Message-ID: <eke7fryr6sow.wl-kobarity@gmail.com> (raw)
In-Reply-To: <m2le8j4m1o.fsf@gmail.com>

Jakub Ječmínek wrote:
> kobarity <kobarity@gmail.com> writes:
> 
> > Thank you for the patch.  I tried it and confirmed that the example
> > shown by Tom Tromey is fixed.
> >
> > I think ppss and line-ppss would be the same in this example.  Can you
> > give an example of a case where ppss and line-ppss are different?
> 
> Well, it would be different in case like this:
> 
> #+BEGIN_SRC python
> " # <- forgotten quote
> a = "abc"""
> #+END_SRC
> 
> `ppss' would in the context of `python-syntax-stringify' evaluate to
> '(0 nil 8 nil nil nil 0 nil nil nil nil), while `line-ppss' to
> '(0 nil 5 34 nil nil 0 nil 7 nil nil). Note the 3rd and 8th
> element. Here's the snippet to test it:
> 
> #+BEGIN_SRC emacs-lisp
> (with-temp-buffer
>   (insert "\"
> a = \"abc\"\"\"")
>   (backward-char 3)
>   (syntax-ppss)
>   (parse-partial-sexp (line-beginning-position) (point)))
> #+END_SRC
> 
> I was thinking that we want to consider only cases where the quote is on
> the same line but I guess I wanted to solve a problem we don't
> have. I've revised the patch to be more simple, please see attached.
> 
> > I noticed an error in the commit-msg hook when applying the patch.
> > CONTRIBUTE states the following:
> >
> > - Lines in ChangeLog entries should preferably be not longer than 63
> >   characters, and must not exceed 78 characters, unless they consist
> >   of a single word of at most 140 characters; this 78/140 limit is
> >   enforced by a commit hook.
> 
> Thanks, fixed.
> 
> > Also, the indentation still looks wrong to me.  It might be better to
> > attach the patch instead of pasting it into the body of the mail.
> 
> Please see attached.
> 
> > Attached is a patch to add an ERT that identifies this issue.  Please
> > add it to your patch if you like.
> 
> Thanks, I've added it to my patch and added 'Co-authored-by:' to commit
> description.

Thank you.  The revised patch looks good to me.





  reply	other threads:[~2024-01-21  7:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 18:03 bug#45897: 27.1; python mode font-lock confused by string concatenation Tom Tromey
2024-01-19 16:01 ` Jakub Ječmínek
2024-01-19 17:25   ` bug#45897: [PATCH] " Jakub Ječmínek
2024-01-20 10:09     ` Eli Zaretskii
2024-01-20 15:41       ` kobarity
2024-01-20 23:33 ` Jakub Ječmínek
2024-01-21  7:39   ` kobarity [this message]
2024-01-27 10:06     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eke7fryr6sow.wl-kobarity@gmail.com \
    --to=kobarity@gmail.com \
    --cc=45897@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jecminek.k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).