From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#70815: [PATCH] ; Enahnce python-tests.el to adapt different python interpreters Date: Wed, 05 Jun 2024 20:52:36 +0900 Message-ID: References: <6057C283-20C5-4A91-9CD4-EBA521B8C893@gmail.com> <7CF65AE1-B3AC-40C5-AC82-CE575E5E1831@gmail.com> <86h6ekwoxb.fsf@gnu.org> <7440E11E-25EF-44C4-A2D8-7F95C2C20466@gmail.com> <3D254E7C-5F1D-4F93-84AB-26FA0BD880D4@gmail.com> <66149F45-F722-4FF8-B99D-72E338BDF6CB@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28846"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: Eli Zaretskii , Lin Sun , Stefan Kangas , 70815@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 13:54:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEpEH-0007Mu-MP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 13:54:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEpEA-00016M-Cz; Wed, 05 Jun 2024 07:54:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEpE8-00015H-Ow for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:54:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEpE8-0002Do-FW for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:54:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEpEM-00021i-Bt for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70815-submit@debbugs.gnu.org id=B70815.17175884437554 (code B ref 70815); Wed, 05 Jun 2024 11:55:02 +0000 Original-Received: (at 70815) by debbugs.gnu.org; 5 Jun 2024 11:54:03 +0000 Original-Received: from localhost ([127.0.0.1]:55507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpDP-0001xl-AP for submit@debbugs.gnu.org; Wed, 05 Jun 2024 07:54:03 -0400 Original-Received: from mail-pg1-f174.google.com ([209.85.215.174]:43432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEpDN-0001wk-9U for 70815@debbugs.gnu.org; Wed, 05 Jun 2024 07:54:01 -0400 Original-Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-6c702226b0aso648582a12.1 for <70815@debbugs.gnu.org>; Wed, 05 Jun 2024 04:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717588361; x=1718193161; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=n5jk54hxnMuoREZcnBgF9fwSK43BArbu5o4m67f69sc=; b=aR45o/pYzbTHUVBQM/+kBZuUTxGs6WgXiL6UqaaWgoxsi6ZOrrJ+g/lQSMs8iiw2DS YmvGKWUD2k2TsT9X9eMdQihyvloelKK0i/Hw3qKijUzfunRIEqUxZHC16Dy8PKHZhaLN afN798aG1gp+WDi7Qmg5fh5WVpr90kabNcmqh+ddlLo9TuYgdBDhehFWQHZa9qqeXy3q oS0pYHVGRsQJqlAC8etFGAEYho/zkKtgjOIWmTsIkD921KeV2BE9XmmUBR3Nzv9ZL856 T+P4zPDZgshVIWKpZWmCZ/1OIdTJ8/EAJ9VnbUzR8aivRezGl/s4XgqdLgbFos58PPBl vsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717588361; x=1718193161; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=n5jk54hxnMuoREZcnBgF9fwSK43BArbu5o4m67f69sc=; b=ECzOePuKM/KykcAZ6/j9jI/kDacDzChjyg8r7e4qjG0KGjb6mw0empjn+dvorqBkPt F1urOCG5EP9nKu0XbDUx3yEgKQYvHKuT+pmNzGhS81/oI2Hu3IOaec1PbupVyuViVPUb vTHEjeKlvqcHORnmxks1Y3kwNtU15eWk570tRo2AJvsNk+EeETJrPiuwZ+Ccbxy0FBC9 Oi5rQyD/jYVO0MpgVQN3WYDoG3xFIsZzc2qbjl7m/nw5VGXVn1OBeednNOHzc0fKIVr3 3B4909LuTUTFXXer1QX5PMfDRJL8OJ7lD7Sso0mrW6n3q9ftlUgz+mmXnpCgwlsv0evI NBAw== X-Forwarded-Encrypted: i=1; AJvYcCUuwgpcFWQR9MaKrbEolXU07sOwxcRMhSz5EZ0SYM8eLmth0LWIRnbCaVM7RxzvRuVSgy7QGveNnkEEeDHHwn17TTZNZ8c= X-Gm-Message-State: AOJu0YxOD4gFG57xQKgN4PbaD6nZ4hMBgv9ldNNX/BRe4FaIRI2GkMga CsMYR05wl4BPGiA93KrGTnaZnCA5KqfJpiT3h0c9z/B17EnA3D/Y X-Google-Smtp-Source: AGHT+IHQxgo7UlyPgsPmQCd/+0ayeHEkfwYY3Ec+vvm1aSRSsjbSn4okA1/TrDXjN/Htb2bmIbWbSw== X-Received: by 2002:a17:90a:ce0a:b0:2b0:e883:270d with SMTP id 98e67ed59e1d1-2c25303f994mr7676257a91.1.1717588360892; Wed, 05 Jun 2024 04:52:40 -0700 (PDT) Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c28067b1easm1279616a91.17.2024.06.05.04.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 04:52:40 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286595 Archived-At: Mattias Engdeg=E5rd wrote: >=20 > 4 juni 2024 kl. 16.29 skrev kobarity : >=20 > > The attached is the revised patch. In order to bind > > `python-shell-interpreter' consistently, new macros > > `python-tests-with-shell-interpreter' and > > `python-tests-with-temp-buffer-with-shell-interpreter' were > > introduced. The patch is larger because some of the indentations have > > been changed by using new macros. I have fixed > > `python-shell-interpreter' was not bound correctly in some ERTs, so > > you might find new ERTs that fail with Python 2 on Mac. >=20 > It works here. >=20 > > 1. Set EMACS_PYTHON_INTERPRETER environment variable to "python" and > > run ERTs. The expectation is that the 7 ERTs that previously > > resulted in errors will be skipped. >=20 > Yes. >=20 > > 2. Change the order of the interpreters in > > `python-tests-get-shell-interpreter' to "python" "python3" > > "python2" and run ERTs. The expectation is that the 7 ERTs that > > previously failed will succeed. >=20 > Yes. >=20 > > However, if the interpreter specified by EMACS_PYTHON_INTERPRETER is > > not found, it is likely that EMACS_PYTHON_INTERPRETER is incorrectly > > configured, and I would prefer to let it fail rather than let it be > > skipped. >=20 > Yes, which is what happens with your patch, and I agree that this is the = best outcome. Thanks for the early confirmation. > Would you like me to push your patch? Thanks again. I will wait a few days to see if I can get feedback from others.