From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: kobarity Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 01 Feb 2024 23:39:58 +0900 Message-ID: References: <83zfx39mcy.fsf@gnu.org> <865xz81pgs.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: liuhui1610@gmail.com, 68559@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 15:41:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVYFf-0001ty-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 15:41:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVYFQ-0004AF-5u; Thu, 01 Feb 2024 09:41:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVYFL-00049z-Mg for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 09:40:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVYFI-00065f-BF for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 09:40:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVYFS-00058a-67 for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 09:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170679842319678 (code B ref 68559); Thu, 01 Feb 2024 14:41:02 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 1 Feb 2024 14:40:23 +0000 Original-Received: from localhost ([127.0.0.1]:40712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVYEp-00057K-5Y for submit@debbugs.gnu.org; Thu, 01 Feb 2024 09:40:23 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:44319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVYEm-000575-P6 for 68559@debbugs.gnu.org; Thu, 01 Feb 2024 09:40:21 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1d932f6ccfaso7848915ad.1 for <68559@debbugs.gnu.org>; Thu, 01 Feb 2024 06:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706798405; x=1707403205; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=+bp1dmsftqDTDcRStwEPfUxisyviyELLaHTQvhO4gEk=; b=MQptbmhCwGY/h1HEDH5BwBmoFWbaevVN0L0rU8GIitNg5q2xxJyHcwaqCgvDViWK/e RoHhXfmTX0q97wZyNfwPTMGgDyQYXnS/LEtjGBRO74dkpOG1QrxQ8BJTe4j1LxYKzPPK FMWpAh4pBKmtwi4TchuY1o51zWbb08R2iQma6+AY85PnklVZhHEAwTFF/mEz38Y9vcqC aHyEIsCkW/3sbU4Gz/lwrXQx8g1t+jjCP47F6eJr+O37PlGxZALbjXQk2s7GCo1joXmx e6PYVGbtl/YLnEjo38X0i8d+gzj9embQH6dudEMqxmUrmj+DMSbRmr0izOHr6cPmi6ql vbqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706798405; x=1707403205; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+bp1dmsftqDTDcRStwEPfUxisyviyELLaHTQvhO4gEk=; b=OX18+nEvZIABtMQGMPPn30THN5tAP0Y+HCSBIVTMsoOvDA7ZXZShiQojJqUC3amZQG SqMPxzGSJfuFHgEMFThK8L4pXDdmmNH7BTKXx7c8mMi0SDl93Y2TfhDKT+64fCqGbgYg ZZLTCddjf2HrC/qT0/E+3lyqDaEvaulNFCV/a5nLiTJ4eomVP1Qxaw3pNw11cwD+huh8 5nXqFIem8M/fz3WNnvkQscRXP7FrqGm5tslA4eRzZFlzxsDFEobeuItG1CAkG6RUeBlE EaZt55imTSWL3ThYylLn0OrDyy94SO89cmAxQOTinBnimiIR0A75exwpvVHzjbRgeHpv /AVw== X-Gm-Message-State: AOJu0YzUgmvUg2sGH0ZAghR6wugbdNLcLr0XJHrBT1s2k61FPgiJdCTq dB9KW6ndQmLrTLeMVcoQUNNI/lQ41BNqvmrIiYKqWOvvgDf1sflK X-Google-Smtp-Source: AGHT+IH5mSTqJWjkU59tIdB6EqvTyTOOqCBJ0q9i77VC4tmnz0MsqKttwxGsNrLmGx2nkZLoJeecqA== X-Received: by 2002:a17:90a:8682:b0:296:e93:cdc with SMTP id p2-20020a17090a868200b002960e930cdcmr2130825pjn.16.1706798404693; Thu, 01 Feb 2024 06:40:04 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXmFbobpGEG/iBguV3k3Fama3ySrY7Ysenv6FzOr9SxSvatA/ilhISgIgQEhkxReCELk6oCkRM644NS4/6tzAA+N8Uhdwc= Original-Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id db16-20020a17090ad65000b0029608793122sm1931767pjb.20.2024.02.01.06.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 06:40:04 -0800 (PST) In-Reply-To: <865xz81pgs.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279292 Archived-At: Eli Zaretskii wrote: > > Date: Mon, 29 Jan 2024 22:15:20 +0900 > > From: kobarity > > Cc: Eli Zaretskii , > > 68559@debbugs.gnu.org > > > > kobarity wrote: > > > Liu Hui wrote: > > > > Thanks for pointing it out. The attached patch should now restore > > > > previous basic completion behavior in comments. > > > > > > Thanks, I confirmed that basic completion (without keyword argument > > > completion) can be performed within comments. > > > > One additional comment regarding ERT. pyenv installs an ipython shim > > to the shims directory, if there is at least one virtualenv providing > > ipython. It can be found by `executable-find'. However, it is not > > usable unless the virtualenv is activated. As a result, the > > `python-shell-completion-at-point-ipython' ERT would fail unless a > > virtualenv which provides ipython is activated. > > > > This may be something pyenv users should take care of, but it is more > > convenient for pyenv users like me to make the following changes. > > Do we have a consensus about this issue? Should I install the > original patch, or are you still discussing it, and an updated patch > will be posted soon? > > Thanks. Although I think there are a few things left unanswered, the latest patch sent on Jan 26th is very worthwhile and stable enough to be installed. So, unless Liu is preparing a new patch, I agree that the latest patch should be installed. That way more people can try it and find the problem, if any.