From: Dmitry Gutov <dgutov@yandex.ru>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 43086@debbugs.gnu.org
Subject: bug#43086: [PATCH] Allow tags backend to not query for TAGS file
Date: Sat, 7 Sep 2024 01:16:46 +0300 [thread overview]
Message-ID: <ef6452be-d2d2-40f9-9302-d3c7c245f3ce@yandex.ru> (raw)
In-Reply-To: <87zfoog084.fsf@posteo.net>
On 03/09/2024 19:39, Philip Kaludercic wrote:
>>> I could imagine this might be extended to allow an auto-generate option,
>>> but that feature seems out of scope of this patch, and probably would
>>> require some interoperation with project.el.
>> Indeed. Actually, I have an old, WIP patch for tag file
>> auto-generation which, yes, uses project.el. I can post it again if
>> you're curious.
> Hasn't this issue been resolved by `etags-regen-mode'?
The part quoted above was, I think.
What might still be missing, is functioning better without having a tags
table generated - after all etags-regen-mode is off by default, and it
might not work for certain projects anyway.
Maybe just like this? This makes Xref identifier completion not query
for TAGS unless already loaded. In many cases that would be TRT,
although `C-u M-.` seems to regress (seems like we *would* want to query
eagerly there).
Adding a user option is still... an option.
diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index d3eb0d46e9b..a4e9abe9b7a 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -2102,7 +2102,9 @@ xref-backend-identifier-at-point
(cl-defmethod xref-backend-identifier-completion-table ((_backend
(eql 'etags)))
- (tags-lazy-completion-table))
+ (and (or tags-file-name
+ tags-table-list)
+ (tags-lazy-completion-table)))
(cl-defmethod xref-backend-identifier-completion-ignore-case ((_backend
(eql
'etags)))
next prev parent reply other threads:[~2024-09-06 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 12:50 bug#43086: [PATCH] Allow tags backend to not query for TAGS file Philip K.
2020-09-05 0:45 ` Dmitry Gutov
2020-09-06 21:50 ` Philip K.
2020-09-16 10:53 ` Dmitry Gutov
2021-11-12 8:25 ` Lars Ingebrigtsen
2021-11-14 0:02 ` Philip Kaludercic
2022-09-11 11:36 ` Lars Ingebrigtsen
2022-09-13 4:07 ` Richard Stallman
2024-09-03 16:39 ` Philip Kaludercic
2024-09-06 22:16 ` Dmitry Gutov [this message]
2024-09-07 6:18 ` Eli Zaretskii
2024-09-09 0:29 ` Dmitry Gutov
2024-09-09 11:54 ` Eli Zaretskii
2024-09-09 23:32 ` Dmitry Gutov
2024-09-10 11:41 ` Eli Zaretskii
2024-09-10 12:45 ` Eli Zaretskii
2024-09-10 13:32 ` Dmitry Gutov
2024-09-10 13:30 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6452be-d2d2-40f9-9302-d3c7c245f3ce@yandex.ru \
--to=dgutov@yandex.ru \
--cc=43086@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).