From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#73258: 31.0.50; w32 drag-n-dropping multiple files is broken Date: Fri, 20 Sep 2024 13:20:05 +0200 Message-ID: References: <86a5g9e32p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------NxPfhW3SSmk087hMAHaEqkMk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4011"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73258@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 20 13:21:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srbh8-0000ng-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Sep 2024 13:21:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srbgt-00046p-Pw; Fri, 20 Sep 2024 07:20:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srbgr-00046a-2M for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 07:20:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srbgq-0003f3-NU for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 07:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:From:MIME-Version:Date:To:Subject; bh=tsBPyTEipA918b3lJ2mY7NDxlhHYBauWz8p8UmFj2HM=; b=tWzmWu+zTS44P+rCQbkLb1Vnm/ii9y3UapunuKv0jRXp5x7Avmyvl+WkNwR58SYeKQb1ifl55QIkhTe5ajJajWf7TLQXmFWcQnM06iuEPzxmnMyNepkKtyw4CUsiAPnFahgkHl2oH++akjJTxSVG+5s7StjQ+MJPX3kv4kjWuKTIfie12FddcwF31Bn7TnaWy7byXje8RdXaqyV5ao5VGCADpQxPYLLnPrtTrN1l63kY0yueMKOHrR2ZVl5d8c4AsbepLUzHdOIzgonFnWzvXWLqj12sygV7UkSMz+Jj/JiLhXqHuzuqdyvx18es6tqlBH8RMCqvuz4MlK6xKiLuHg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srbh8-0003ow-Gp for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 07:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73258 X-GNU-PR-Package: emacs Original-Received: via spool by 73258-submit@debbugs.gnu.org id=B73258.172683123514637 (code B ref 73258); Fri, 20 Sep 2024 11:21:02 +0000 Original-Received: (at 73258) by debbugs.gnu.org; 20 Sep 2024 11:20:35 +0000 Original-Received: from localhost ([127.0.0.1]:34255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srbgh-0003o1-88 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 07:20:35 -0400 Original-Received: from mail.imayhem.com ([82.223.54.191]:51163 helo=zealous-pike.82-223-54-191.plesk.page) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1srbge-0003kP-7V for 73258@debbugs.gnu.org; Fri, 20 Sep 2024 07:20:33 -0400 Original-Received: from [10.0.12.77] (66.red-2-136-43.staticip.rima-tde.net [2.136.43.66]) by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id 412F185457; Fri, 20 Sep 2024 11:20:07 +0000 (UTC) Authentication-Results: zealous-pike.82-223-54-191.plesk.page; spf=pass (sender IP is 2.136.43.66) smtp.mailfrom=cpardo@imayhem.com smtp.helo=[10.0.12.77] Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is authenticated) Content-Language: es-ES In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292106 Archived-At: This is a multi-part message in MIME format. --------------NxPfhW3SSmk087hMAHaEqkMk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Did you get a chance to review this? On 15/09/2024 21:22, Cecilio Pardo wrote: > > On 15/09/2024 10:25, Eli Zaretskii wrote: >> We cannot remove or make backward-incompatible changes in a public >> API.  So removing/renaming w32-handle-dropped-file and/or changing its >> signature is out of the question.  Can you rewrite the patch such that >> it keeps this function and its arguments, and just change the >> implementation to fix the problem? >> >> Also, please accompany your changes with a ChangeLog-style description >> (see CONTRIBUTE for the details), to make the job of installing the >> changes easier. > > See the attached patch. Hope I did it right, let me know. > > Thanks. --------------NxPfhW3SSmk087hMAHaEqkMk Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Did you get a chance to review this?

On 15/09/2024 21:22, Cecilio Pardo wrote:

On 15/09/2024 10:25, Eli Zaretskii wrote:
We cannot remove or make backward-incompatible changes in a public
API.  So removing/renaming w32-handle-dropped-file and/or changing its
signature is out of the question.  Can you rewrite the patch such that
it keeps this function and its arguments, and just change the
implementation to fix the problem?

Also, please accompany your changes with a ChangeLog-style description
(see CONTRIBUTE for the details), to make the job of installing the
changes easier.

See the attached patch. Hope I did it right, let me know.

Thanks.
--------------NxPfhW3SSmk087hMAHaEqkMk--