From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 15 Aug 2022 15:06:35 +0300 Message-ID: References: <83k07jx5jn.fsf@gnu.org> <866e510d-a060-7daa-d002-97861d056fa7@yandex.ru> <1144021660321893@iva5-64778ce1ba26.qloud-c.yandex.net> <12348081660379417@sas2-a098efd00d24.qloud-c.yandex.net> <66bbbb95983414e79637@heytings.org> <66bbbb95983475c5f3b0@heytings.org> <0d67f253-c080-d750-c2cb-4a9591ff8c6c@yandex.ru> <83lerrl734.fsf@gnu.org> <83wnbbj7v4.fsf@gnu.org> <75c316c0-3346-e702-b114-41a7f899deb1@yandex.ru> <5900f20836ca3f305df8@heytings.org> <8ef8eaba-1add-e87e-247e-71888beaf1f8@yandex.ru> <837d3ak8lf.fsf@gnu.org> <14516fce-8c35-1ce7-1314-44a3d79e8ba7@yandex.ru> <834jyek7df.fsf@gnu.org> <29b571a3-5a47-fed9-3147-f30864134c41@yandex.ru> <83tu6ei6e0.fsf@gnu.org> <83a685iv2d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26661"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 14:08:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNYt4-0006kU-IE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 14:08:06 +0200 Original-Received: from localhost ([::1]:37528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNYt1-0007iW-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 08:08:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNYs2-0007UB-B5 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 08:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNYs2-0005Wi-2w for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 08:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNYs1-0007SL-Tw for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 08:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 12:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166056520728641 (code B ref 56682); Mon, 15 Aug 2022 12:07:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 15 Aug 2022 12:06:47 +0000 Original-Received: from localhost ([127.0.0.1]:41109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNYrm-0007Rs-Ia for submit@debbugs.gnu.org; Mon, 15 Aug 2022 08:06:46 -0400 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:42979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNYrk-0007Re-OX for 56682@debbugs.gnu.org; Mon, 15 Aug 2022 08:06:45 -0400 Original-Received: by mail-wm1-f47.google.com with SMTP id s11-20020a1cf20b000000b003a52a0945e8so3814765wmc.1 for <56682@debbugs.gnu.org>; Mon, 15 Aug 2022 05:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc; bh=GNCK464zh6N1C/85gxc9Ddz/QGfnmg2uIVR7zmrNJhY=; b=UUome7bBm2xlpVupKaODbF0zPAC4vyV6G34fzYnf7uRx4g7pIF1g9GrUezvHd41Niq A97YiI6/ucQZNu2UeQCSFObP1OkSwaFe8yOJS/JNme/YjZO7UZjFk0M5lO7hr0iaaG13 mxiTfPgw+ii63/2DHmFbxpNcxZQxz7hpokMvm0VOk2m5IUo/zLy8ChU99cFm2y/I6zvK ba3prTuF4UufXqGsg7NzN9Y1x+I5rOSFPRYTDRcK2jpugA8lmR3p/vJyJRo6p9CYwx1J kxAPXjZ9zwhaMkFH0O6mxaib/O37DyjiEYh4KSR8il/2X6Z+Kz6x2bJ5ZEwj2oltSUv7 qQqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc; bh=GNCK464zh6N1C/85gxc9Ddz/QGfnmg2uIVR7zmrNJhY=; b=a0uJnar5wi7tcY94eHY6x8C1AheLeHwfLsRNMeUQCG9GziI22NFlCmmLvFNo09fv0H w/RYFkFPKuq1w5LUZENZRXGvqcDAn/DIu2AeKHwLdYOdZvLkdWkYw6eJHh5Op5Mh8awH DkxLhbVJqQCSy7g6Na9yUdK4tnJjYicDQeARMu9+hSJkOGSXGDXTbBaMA5zdNP5yIs+O pm5pNTR1u7co1kMMmzkLcx/KXw9kKEPu36nZf8vzyQGCEmTc75nPM/+8iv5Q4H0rweaz KWSB/lfoDuZhqCKIBJ5DvIryimu5EZjUzIhPISS40Fm2TC5VG/bywGHsSIJzXagaN7pN wBOQ== X-Gm-Message-State: ACgBeo1EAnBDgT4Y2kUfQkaxqnx5S7LV4Z+81uvgJ2QDvFMqKR6UC2S8 5zoqip7PKBjTpLZ4+UTkoDQ= X-Google-Smtp-Source: AA6agR4oM0Y6ddf64urtLBiPyew52Uw+UkARw8h2MzdKIu1khpzThQJunH4CARgt0VBC/lsycdB1rg== X-Received: by 2002:a7b:c852:0:b0:3a5:407a:76df with SMTP id c18-20020a7bc852000000b003a5407a76dfmr9825995wml.101.1660565198837; Mon, 15 Aug 2022 05:06:38 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bg7-20020a05600c3c8700b003a5c1e916c8sm17438078wmb.1.2022.08.15.05.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 05:06:38 -0700 (PDT) Content-Language: en-US In-Reply-To: <83a685iv2d.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239785 Archived-At: On 15.08.2022 14:51, Eli Zaretskii wrote: >> Date: Mon, 15 Aug 2022 13:06:14 +0300 >> Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >>> And btw, I have very different impression of what happens with 100x >>> larger narrowing on my machine and with unoptimized builds. >> >> Given what we've seen about your parse-partial-sexp's performance (10x >> slower than mine), I would hope for someone to figure out why it's so >> slow in your unoptimized build. But if it doesn't happen, you would >> probably use a different threshold/narrowing radius (through customization). >> >> It would make sense for our defaults not to be tailored to this very >> particular development rig. > > If you are willing to lose my ability to debug complex redisplay > problems in many cases, sure, go ahead. Why? You would customize an option to a lower value, and go on to debugging. Though I guess reproducing the exact conditions on the user's machine might get harder sometimes. >>>> So yeah, the font-lock related widen/narrowing logic should indeed live >>>> in one place. And until now it has resided in font-lock-fontify-region. >>> >>> Since when is font-lock-fontify-region specific to a language? It is >>> as general as xdisp.c. >> >> syntax-propertize is general, and yet it invokes language-specific rules >> (through syntax-propertize-function). > > Nothing prevents xdisp.c from invoking those same rules if needed. True. We could basically rewrite any Lisp function we have in C (font-lock-fontify-region, for example). And by doing that bar a lot of power users/potential developers from being able to read that code, debug and contribute improvements.