From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq Date: Thu, 28 Mar 2019 20:51:40 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142851"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 28 20:52:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9b4T-000b1S-K3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 20:52:17 +0100 Original-Received: from localhost ([127.0.0.1]:41314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9b4S-0004AI-Km for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 15:52:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9b4M-0004A4-9M for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 15:52:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9b4I-0004BL-E3 for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 15:52:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49458) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9b4E-0004A9-OB for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 15:52:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h9b4D-0005CQ-TS for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Mar 2019 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34781-submit@debbugs.gnu.org id=B34781.155380271919977 (code B ref 34781); Thu, 28 Mar 2019 19:52:01 +0000 Original-Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 19:51:59 +0000 Original-Received: from localhost ([127.0.0.1]:34769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b4A-0005C9-PM for submit@debbugs.gnu.org; Thu, 28 Mar 2019 15:51:58 -0400 Original-Received: from mail157c50.megamailservers.eu ([91.136.10.167]:52218 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9b48-0005Bz-RR for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 15:51:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1553802704; bh=7Kllq/Z+7b0TOJgf/0X9y69zxqX+3rm5w39Vi4CH7GI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mE7+FGv9ul71LqiTKa06INoMHyB8fPJFt+YOnlyljtg7ZdrqgjwCSCKw457Q90pOa xzefUhY96sxRvcpcX5TbAiIXmKYhJhLysD5mwhBYb+V4WqCMeahlSgnllUHOOO2+ze 9BcdXIvQvMqakjWkN2f8Cb+CVm6d/ZYL/yyEwIYA= Feedback-ID: mattiase@acm.or Original-Received: from dhcppc1 (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2SJpejc000527; Thu, 28 Mar 2019 19:51:42 +0000 In-Reply-To: X-CTCH-RefID: str=0001.0A0B0201.5C9D25D0.0064, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a8seC3aF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=QQUOvgvckhQt0zx9LMwA:9 a=QEXdDO2ut3YA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156895 Archived-At: tor 2019-03-28 klockan 11:25 -0700 skrev Paul Eggert: > > Thanks, it looks good to me; please install into the master branch > > What happens if a source file that uses pcase is compiled on a 64-bit > machine that has wide fixnums, and is then loaded and run on a 32-bit > machine that has narrow fixnums? Will this pcase code still work? And > if > not, are there similar bugs elsewhere in the pcase code? Not that I can see; the singular case uses eql for integerp. I didn't think of the case you described, thanks. We then need a new function: portable-fixnum-p guaranteed-fixnum-p always-fixnum-p fixnum-everywhere-p here-a-fixnum-there-a-fixnum-everywhere-a-fixnum-p and names for the bounds: portable-most-{positive,negative}-fixnum ... Name suggestions welcome. Meanwhile, I'll make a new patch.