From: "Mattias Engdegård" <mattiase@acm.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: monnier@iro.umontreal.ca, 34781@debbugs.gnu.org
Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq
Date: Thu, 28 Mar 2019 20:51:40 +0100 [thread overview]
Message-ID: <edad99daf2b77f8da07209b3112978a8f38eee63.camel@acm.org> (raw)
In-Reply-To: <e14a8227-3c34-0789-c400-5cb07301f465@cs.ucla.edu>
tor 2019-03-28 klockan 11:25 -0700 skrev Paul Eggert:
>
> Thanks, it looks good to me; please install into the master branch
>
> What happens if a source file that uses pcase is compiled on a 64-bit
> machine that has wide fixnums, and is then loaded and run on a 32-bit
> machine that has narrow fixnums? Will this pcase code still work? And
> if
> not, are there similar bugs elsewhere in the pcase code?
Not that I can see; the singular case uses eql for integerp.
I didn't think of the case you described, thanks. We then need a new
function:
portable-fixnum-p
guaranteed-fixnum-p
always-fixnum-p
fixnum-everywhere-p
here-a-fixnum-there-a-fixnum-everywhere-a-fixnum-p
and names for the bounds:
portable-most-{positive,negative}-fixnum
...
Name suggestions welcome. Meanwhile, I'll make a new patch.
next prev parent reply other threads:[~2019-03-28 19:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:13 bug#34781: 27.0.50; integer in pcase sometimes compared by eq Mattias Engdegård
[not found] ` <handler.34781.B.15519717565134.ack@debbugs.gnu.org>
2019-03-12 12:24 ` bug#34781: Acknowledgement (27.0.50; integer in pcase sometimes compared by eq) Mattias Engdegård
2019-03-16 19:09 ` bug#34781: 27.0.50; integer in pcase sometimes compared by eq Mattias Engdegård
2019-03-28 18:25 ` Paul Eggert
2019-03-28 19:47 ` Michael Heerdegen
2019-03-28 20:33 ` Paul Eggert
2019-03-28 21:30 ` Michael Heerdegen
2019-03-28 19:51 ` Mattias Engdegård [this message]
2019-03-28 20:30 ` Paul Eggert
2019-03-28 21:51 ` Mattias Engdegård
2019-03-28 22:10 ` Paul Eggert
2019-03-28 22:11 ` Stefan Monnier
2019-03-28 22:20 ` Mattias Engdegård
2019-03-28 22:38 ` Paul Eggert
2019-03-28 23:03 ` Mattias Engdegård
2019-03-29 8:48 ` Eli Zaretskii
2019-03-29 9:52 ` Mattias Engdegård
2019-03-29 12:33 ` Eli Zaretskii
2019-03-28 19:43 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edad99daf2b77f8da07209b3112978a8f38eee63.camel@acm.org \
--to=mattiase@acm.org \
--cc=34781@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).