From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#34910: 27.0.50; Too much matching reentrancy Date: Sat, 30 Mar 2019 07:52:12 -0700 Message-ID: References: <834l7zuw4x.fsf@gnu.org> <443195D9-DFEB-4E67-AEFE-556C3D900113@acm.org> <8336njuqrd.fsf@gnu.org> <66172e4bc6e70e23d7bf3175a5c83519a43c1a66.camel@acm.org> <83sgv4iu9d.fsf@gnu.org> <62AAF86C-0A25-4FD3-9F35-D2D100F78D6E@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="100453"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: Stefan Monnier , 34910@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 30 15:53:36 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAFMU-000PxS-Je for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Mar 2019 15:53:35 +0100 Original-Received: from localhost ([127.0.0.1]:55123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAFMT-0004wp-Ji for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Mar 2019 10:53:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAFMJ-0004wW-U2 for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 10:53:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAFM4-00065c-MB for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 10:53:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAFLy-00063e-LB for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 10:53:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAFLy-0003Ui-GU for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2019 10:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2019 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34910-submit@debbugs.gnu.org id=B34910.155395754313383 (code B ref 34910); Sat, 30 Mar 2019 14:53:02 +0000 Original-Received: (at 34910) by debbugs.gnu.org; 30 Mar 2019 14:52:23 +0000 Original-Received: from localhost ([127.0.0.1]:37504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAFLL-0003Tn-93 for submit@debbugs.gnu.org; Sat, 30 Mar 2019 10:52:23 -0400 Original-Received: from dancol.org ([96.126.100.184]:41256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAFLI-0003Te-LT for 34910@debbugs.gnu.org; Sat, 30 Mar 2019 10:52:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=jzbMIZD4gc0MGeCQk7t+SW3QM+qHUaXCySlZ1emHe30=; b=fkpfv4Hmi4qVLjdSfY8ecbX0RCODVeMv0q2hBOdxMSQcppu070bxENYlLsE9DoL6V1O3oNrbwL2c3iU5OxjubYsMfJHt6Ui55W1iUD5XqE2mrqiyAu8yd89OLfY2v5QxrYaaEwbQGkAcUNRx5c+RNURdlkAT1ciQ5sf+IyPWKfV+Sxkpjlm9zrdGnGliq22PQxWtG6R9sChKt9V5x5BWNBqxMDCuODoUqXwu6Ugcbz6TkroYtFVBfBFd5+x7dFC/6r42wXcX5OsnJ+JIQYxEu8ZgqaI4PPR9VPrBL7ISTGQb77VM3h2ghyS+nIUsjaKPnUvnZ5okUQWf3BxXh34MPQ==; Original-Received: from [2604:4080:1321:9a00:fc2a:787c:f84c:2105] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1hAFLG-00036F-NP; Sat, 30 Mar 2019 07:52:18 -0700 In-Reply-To: <62AAF86C-0A25-4FD3-9F35-D2D100F78D6E@acm.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156950 Archived-At: On 3/30/19 4:18 AM, Mattias Engdegård wrote: > 30 mars 2019 kl. 10.30 skrev Eli Zaretskii : >> >>> Here is another improvement: there should be no reason to keep the >>> regexp busy during the overflow error processing, so release it first. >> >> Looks OK to me. > > Thank you, both pushed. Thanks! > >>> By the way, is there any reason why only calls to re_search_2 are made >>> with a busy-marked regexp buffer, not calls to re_search? Are the >>> latter guaranteed not to be reentrant? >> >> Not sure. Stefan, any thoughts? > > Maybe Daniel only had reentrancy concerns about regexp matching on buffers, not on strings? We do automatic syntax discovery on buffers, not strings.