From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35702@debbugs.gnu.org, juri@linkov.net
Subject: bug#35702: xref revert-buffer
Date: Fri, 24 May 2019 13:09:50 +0300 [thread overview]
Message-ID: <ed6a3e45-b010-2d73-e8d2-8afb44c9c5c3@yandex.ru> (raw)
In-Reply-To: <838suw5jvh.fsf@gnu.org>
On 24.05.2019 11:36, Eli Zaretskii wrote:
> Thanks, but that changeset has a few problems:
>
> . the new command xref--revert-xref-buffer uses an internal name,
Is that a problem by itself? We have other bindings that use internal
command names as well.
> and has no doc string
How about something like:
Refresh the search results by repeating the search.
> . neither NEWS nor the user manual document the 'g' key in XREF
> buffers
I can add the NEWS entry.
> . it looks like this new command is not useful after M-., because I
> get an error message when I try using it (perhaps this is because
> I didn't understand its use case due to lack of docs)
It has been a deliberate choice to simplify the implementation. IME, you
don't ever want to refresh the list of definitions. But for other search
results (references, apropos, project-find-regexp, dired-do-find-regexp)
it's a lot more common.
Commit 49a363c875 also brings in another difference between the
behaviors of xref-find-definitions and xref-find-references: the latter
now shows the xref buffer even when there is just one hit.
> Let me know if I can help in fixing any of the above. (I tried to
> figure out what this command does and how, but quickly got lost in a
> chain of indirections via undocumented internal functions and
> variables, sorry.)
Do you have a better idea now? Please let me know if you have any
further questions.
next prev parent reply other threads:[~2019-05-24 10:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 19:45 bug#35702: xref revert-buffer Juri Linkov
2019-05-24 1:51 ` Dmitry Gutov
2019-05-24 8:36 ` Eli Zaretskii
2019-05-24 10:09 ` Dmitry Gutov [this message]
2019-05-24 12:25 ` Eli Zaretskii
2019-05-24 12:57 ` Dmitry Gutov
2019-05-24 14:10 ` Eli Zaretskii
2019-05-24 14:26 ` Dmitry Gutov
2019-05-24 15:02 ` Eli Zaretskii
2019-05-24 22:35 ` Dmitry Gutov
2019-05-24 15:15 ` Dmitry Gutov
2019-05-24 19:35 ` Eli Zaretskii
2019-05-24 20:51 ` Dmitry Gutov
2019-05-25 7:39 ` Eli Zaretskii
2019-05-25 15:47 ` Dmitry Gutov
2019-05-25 16:06 ` Eli Zaretskii
2019-05-25 16:14 ` Dmitry Gutov
2019-05-25 16:49 ` Eli Zaretskii
2019-05-25 21:33 ` Dmitry Gutov
2019-05-26 16:44 ` Eli Zaretskii
2019-05-27 14:54 ` Dmitry Gutov
2019-05-27 16:31 ` Eli Zaretskii
2019-05-28 14:10 ` Dmitry Gutov
2019-05-28 18:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed6a3e45-b010-2d73-e8d2-8afb44c9c5c3@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35702@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).